Phoenix: error: extra ‘;’ on boost/phoenix/core/environment.hpp

Hi, There is an error on In file included from ../../../boost/phoenix/core/call.hpp:12, from ../../../boost/conversion/fp/convert_to.hpp:15, from builtins.cpp:16: ../../../boost/phoenix/core/environment.hpp:446: error: extra ‘;’ It seems that the error: extra ‘;’ are on lines 433 and 444 at the end of two functions definitions. Could this be fixed? Thanks, Vicente

On 14 May 2011 18:44, Vicente BOTET <vicente.botet@wanadoo.fr> wrote:
There is an error on
In file included from ../../../boost/phoenix/core/call.hpp:12, from ../../../boost/conversion/fp/convert_to.hpp:15, from builtins.cpp:16: ../../../boost/phoenix/core/environment.hpp:446: error: extra ‘;’
It seems that the error: extra ‘;’ are on lines 433 and 444 at the end of two functions definitions.
Could this be fixed?
Can you describe how to reproduce this?

Daniel James-3 wrote:
On 14 May 2011 18:44, Vicente BOTET <vicente.botet@wanadoo.fr> wrote:
There is an error on
In file included from ../../../boost/phoenix/core/call.hpp:12, from ../../../boost/conversion/fp/convert_to.hpp:15, from builtins.cpp:16: ../../../boost/phoenix/core/environment.hpp:446: error: extra ‘;’
It seems that the error: extra ‘;’ are on lines 433 and 444 at the end of two functions definitions.
Could this be fixed?
Can you describe how to reproduce this?
I'm compiling on Darwin gcc 4.2.1 with -Wextra -Wno-long-long -pedantic Vicente -- View this message in context: http://boost.2283326.n4.nabble.com/Phoenix-error-extra-on-boost-phoenix-core... Sent from the Boost - Dev mailing list archive at Nabble.com.

On 5/15/2011 12:44 AM, Vicente BOTET wrote:
Hi,
There is an error on
In file included from ../../../boost/phoenix/core/call.hpp:12, from ../../../boost/conversion/fp/convert_to.hpp:15, from builtins.cpp:16: ../../../boost/phoenix/core/environment.hpp:446: error: extra ‘;’
It seems that the error: extra ‘;’ are on lines 433 and 444 at the end of two functions definitions.
Could this be fixed?
This is trivial, so I hope Thomas doesn't mind that I just went ahead and fixed it. Merged to release as well, since it's pretty safe. I resisted the urge to fix a bunch of incorrect uses of inline, such as: type inline function_name( /*...*/ ) { } According to (my reading of) the standard, the inline and all other so-called function specifiers must come before the return type. Thomas, could you please fix this throughout Phoenix? -- Eric Niebler BoostPro Computing http://www.boostpro.com

On 14 May 2011 20:27, Eric Niebler <eric@boostpro.com> wrote:
This is trivial, so I hope Thomas doesn't mind that I just went ahead and fixed it. Merged to release as well, since it's pretty safe.
It would still help to know which compiler reports this error, since that's a compiler it hasn't been tested with.

Eric Niebler-3 wrote:
On 5/15/2011 12:44 AM, Vicente BOTET wrote:
Hi,
There is an error on
In file included from ../../../boost/phoenix/core/call.hpp:12, from ../../../boost/conversion/fp/convert_to.hpp:15, from builtins.cpp:16: ../../../boost/phoenix/core/environment.hpp:446: error: extra ‘;’
It seems that the error: extra ‘;’ are on lines 433 and 444 at the end of two functions definitions.
Could this be fixed?
This is trivial, so I hope Thomas doesn't mind that I just went ahead and fixed it. Merged to release as well, since it's pretty safe.
Thanks, Vicente -- View this message in context: http://boost.2283326.n4.nabble.com/Phoenix-error-extra-on-boost-phoenix-core... Sent from the Boost - Dev mailing list archive at Nabble.com.

On Saturday, May 14, 2011 09:27:34 PM Eric Niebler wrote:
On 5/15/2011 12:44 AM, Vicente BOTET wrote:
Hi,
There is an error on
In file included from ../../../boost/phoenix/core/call.hpp:12, from ../../../boost/conversion/fp/convert_to.hpp:15, from builtins.cpp:16: ../../../boost/phoenix/core/environment.hpp:446: error: extra ‘;’
It seems that the error: extra ‘;’ are on lines 433 and 444 at the end of two functions definitions.
Could this be fixed?
This is trivial, so I hope Thomas doesn't mind that I just went ahead and fixed it. Merged to release as well, since it's pretty safe.
Thanks for fixing this.
I resisted the urge to fix a bunch of incorrect uses of inline, such as:
type inline function_name( /*...*/ ) { }
According to (my reading of) the standard, the inline and all other so-called function specifiers must come before the return type. Thomas, could you please fix this throughout Phoenix?
Right ... It was me being sloppy. Interestingly enough, compilers didn't catch this problem. Fixed on trunk.
participants (5)
-
Daniel James
-
Eric Niebler
-
Thomas Heller
-
Vicente Botet
-
Vicente BOTET