[property-map] Generalizing identity_property_map for arbitrary types

Hi, I've found the property map library to be very useful and would like to propose a minor enhancement to permit the identity_property_map to work for arbitrary types. The reason for this is that some computationally intensive algorithms suffer noticeable performance degradation when I convert them to generic algorithms using property maps. Having a typed identity property map that returns, for example, the double passed into it significantly speeds up our algorithms, at least for those fields that are not mutable. I've attached a patch, and could supply a motivating example, if anyone is interested. -- Noel

On Tue, 8 Dec 2009, Belcourt, Kenneth wrote:
Hi,
I've found the property map library to be very useful and would like to propose a minor enhancement to permit the identity_property_map to work for arbitrary types. The reason for this is that some computationally intensive algorithms suffer noticeable performance degradation when I convert them to generic algorithms using property maps. Having a typed identity property map that returns, for example, the double passed into it significantly speeds up our algorithms, at least for those fields that are not mutable.
I've attached a patch, and could supply a motivating example, if anyone is interested.
-- Noel
I don't see a patch attached to your email. Could you please file a feature request on Trac for property_map? Thank you. -- Jeremiah Willcock

On Dec 8, 2009, at 3:57 PM, Jeremiah Willcock wrote:
On Tue, 8 Dec 2009, Belcourt, Kenneth wrote:
I've found the property map library to be very useful and would like to propose a minor enhancement to permit the identity_property_map to work for arbitrary types. The reason for this is that some computationally intensive algorithms suffer noticeable performance degradation when I convert them to generic algorithms using property maps. Having a typed identity property map that returns, for example, the double passed into it significantly speeds up our algorithms, at least for those fields that are not mutable.
I've attached a patch, and could supply a motivating example, if anyone is interested.
I don't see a patch attached to your email. Could you please file a feature request on Trac for property_map? Thank you.

On Tue, 8 Dec 2009, Belcourt, Kenneth wrote:
On Dec 8, 2009, at 3:57 PM, Jeremiah Willcock wrote:
On Tue, 8 Dec 2009, Belcourt, Kenneth wrote:
I've found the property map library to be very useful and would like to propose a minor enhancement to permit the identity_property_map to work for arbitrary types. The reason for this is that some computationally intensive algorithms suffer noticeable performance degradation when I convert them to generic algorithms using property maps. Having a typed identity property map that returns, for example, the double passed into it significantly speeds up our algorithms, at least for those fields that are not mutable.
I've attached a patch, and could supply a motivating example, if anyone is interested.
I don't see a patch attached to your email. Could you please file a feature request on Trac for property_map? Thank you.
https://svn.boost.org/trac/boost/ticket/3739
-- Noel
This is applied in r58246. Thank you for your patch. -- Jeremiah Willcock
participants (2)
-
Belcourt, Kenneth
-
Jeremiah Willcock