I know it has been asked in the past, but I still don't understand why scoped_ptr lacks this feature. The "noncopyable nature" of scoped_ptr allows to support deleters with simply an extra template parameter (default value is boost::checked_deleter): this change doesn't require extra memory overhead (like in shared_ptr) and it consists of 2 lines. template<class T, class D = boost::checked_deleter> // first patch line class scoped_ptr { // ... public: ~scoped_ptr() { // ... deleter()(ptr); // second patch line, instead of boost::checked_delete } }; Any hope to apply this patch? _________________________________________________________________ Gossip, Sport, Notizie... Accendi la Messenger TV! http://www.messenger.it/messengerTV.aspx
Berserker wrote:
The "noncopyable nature" of scoped_ptr allows to support deleters with simply an extra template parameter (default value is boost::checked_deleter): this change doesn't require extra memory overhead (like in shared_ptr) and it consists of 2 lines.
That change creates multiple, distinct classes. shared_ptr<T,boost::checked_deleter<T>> is not the same as shared_ptr<T,my_deleter<T>>. By embedding the deleter in the shared_ptr with type erasure, shared_ptr<T> is shared_ptr<T> is shared_ptr<T>, regardless of the deleter.
Any hope to apply this patch?
None, unless I'm much mistaken. _____ Rob Stewart robert.stewart@sig.com Software Engineer, Core Software using std::disclaimer; Susquehanna International Group, LLP http://www.sig.com IMPORTANT: The information contained in this email and/or its attachments is confidential. If you are not the intended recipient, please notify the sender immediately by reply and immediately delete this message and all its attachments. Any review, use, reproduction, disclosure or dissemination of this message or any attachment by an unintended recipient is strictly prohibited. Neither this message nor any attachment is intended as or should be construed as an offer, solicitation or recommendation to buy or sell any security or other financial instrument. Neither the sender, his or her employer nor any of their respective affiliates makes any warranties as to the completeness or accuracy of any of the information contained herein or that this message or any of its attachments is free of viruses.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Tuesday 15 September 2009, Stewart, Robert wrote:
Berserker wrote:
The "noncopyable nature" of scoped_ptr allows to support deleters with simply an extra template parameter (default value is boost::checked_deleter): this change doesn't require extra memory overhead (like in shared_ptr) and it consists of 2 lines.
That change creates multiple, distinct classes. shared_ptr<T,boost::checked_deleter<T>> is not the same as shared_ptr<T,my_deleter<T>>. By embedding the deleter in the shared_ptr with type erasure, shared_ptr<T> is shared_ptr<T> is shared_ptr<T>, regardless of the deleter.
Any hope to apply this patch?
None, unless I'm much mistaken.
There is nothing wrong with the design, it is just called unique_ptr. Also, there is already a boost::interprocess::unique_ptr in boost which I've only played with a little but seems to work ok. It is missing a default_delete however. I imagine once boost gets a move library, boost::unique_ptr will follow. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAkqvlc0ACgkQ5vihyNWuA4WzmwCfYzmkJNBDE+nmnLHt1fVa4BVG QZkAoMnzpLmWGJ4ovPxqvVmwoGWq9Vi2 =caGR -----END PGP SIGNATURE-----
participants (3)
-
Berserker -
Frank Mori Hess -
Stewart, Robert