I have a bug fix for Spirit pending which I still would like to get into the release, if possible. It's changeset 84814: Bugfix: =================================================================== --- omit.hpp (revision 84813) +++ omit.hpp (revision 84814) @@ -77,7 +77,7 @@ if (Execute) { // wrap the given output iterator to avoid output detail::disable_output<OutputIterator> disable(sink); - subject.generate(sink, ctx, d, attr); + return subject.generate(sink, ctx, d, attr); } return true; New test: =================================================================== --- omit.cpp (revision 84813) +++ omit.cpp (revision 84814) @@ -47,6 +47,21 @@ BOOST_TEST(test("15", r, a)); } + // even if omit[] never fails, it has to honor the result of the + // embedded generator + { + typedef std::pair attribute_type; + rule r; + + r %= omit[double_(1.0) << double_] | "42"; + + attribute_type p1 (1.0, 2.0); + BOOST_TEST(test("", r, p1)); + + attribute_type p2 (10.0, 2.0); + BOOST_TEST(test("42", r, p2)); + } + // skip[] is not supposed to execute the embedded generator { using boost::spirit::karma::double_; Thanks! Regards Hartmut --------------- http://boost-spirit.com http://stellar.cct.lsu.edu

-----Original Message----- From: Boost [mailto:boost-bounces@lists.boost.org] On Behalf Of Marshall Clow Sent: Thursday, June 27, 2013 8:45 AM To: boost@lists.boost.org List Subject: [boost] [1.54.0] Release candidates available

Release candidate files for 1.54.0 are available at http://boost.cowic.de/rc/

As always, the release managers would appreciate it if you download the candidate of your choice and give building it a try. Please report both success and failure, and anything else that is noteworthy.

This helps ensure the candidates build OK before we push them out to SourceForge.

The files (and associated md5s) are: efbfbff5a85a9330951f243d0a46e4b9 *boost_1_54_0_rc1.tar.gz 15cb8c0803064faef0c4ddf5bc5ca279 *boost_1_54_0_rc1.tar.bz2 78a35834c45220a6164310e280abe675 *boost_1_54_0_rc1.zip 89e734ffd2afe0982b2d9fc21d033dba *boost_1_54_0_rc1.7z

Thanks!

-- The release managers

_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost

I forgot to explicitly ask for permission to merge this. Am I allowed to do so? Regards Hartmut --------------- http://boost-spirit.com http://stellar.cct.lsu.edu

-----Original Message----- From: Hartmut Kaiser [mailto:hartmut.kaiser@gmail.com] Sent: Thursday, June 27, 2013 9:11 AM To: 'boost@lists.boost.org' Subject: RE: [boost] [1.54.0] Release candidates available

I have a bug fix for Spirit pending which I still would like to get into the release, if possible. It's changeset 84814:

Bugfix:

=================================================================== --- omit.hpp (revision 84813) +++ omit.hpp (revision 84814) @@ -77,7 +77,7 @@ if (Execute) { // wrap the given output iterator to avoid output detail::disable_output<OutputIterator> disable(sink); - subject.generate(sink, ctx, d, attr); + return subject.generate(sink, ctx, d, attr); } return true;

New test:

=================================================================== --- omit.cpp (revision 84813) +++ omit.cpp (revision 84814) @@ -47,6 +47,21 @@ BOOST_TEST(test("15", r, a)); }

+ // even if omit[] never fails, it has to honor the result of the + // embedded generator + { + typedef std::pair attribute_type; + rule r; + + r %= omit[double_(1.0) << double_] | "42"; + + attribute_type p1 (1.0, 2.0); + BOOST_TEST(test("", r, p1)); + + attribute_type p2 (10.0, 2.0); + BOOST_TEST(test("42", r, p2)); + } + // skip[] is not supposed to execute the embedded generator { using boost::spirit::karma::double_;

Thanks! Regards Hartmut --------------- http://boost-spirit.com http://stellar.cct.lsu.edu

...

-----Original Message----- From: Boost [mailto:boost-bounces@lists.boost.org] On Behalf Of Marshall Clow Sent: Thursday, June 27, 2013 8:45 AM To: boost@lists.boost.org List Subject: [boost] [1.54.0] Release candidates available

Release candidate files for 1.54.0 are available at http://boost.cowic.de/rc/

As always, the release managers would appreciate it if you download the candidate of your choice and give building it a try. Please report both success and failure, and anything else that is noteworthy.

This helps ensure the candidates build OK before we push them out to SourceForge.

The files (and associated md5s) are: efbfbff5a85a9330951f243d0a46e4b9 *boost_1_54_0_rc1.tar.gz 15cb8c0803064faef0c4ddf5bc5ca279 *boost_1_54_0_rc1.tar.bz2 78a35834c45220a6164310e280abe675 *boost_1_54_0_rc1.zip 89e734ffd2afe0982b2d9fc21d033dba *boost_1_54_0_rc1.7z

Thanks!

-- The release managers

_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost