intrusive containers review

What is your evaluation of the design?
Very good. It was a pleasure to use. I have long wanted an easy way to apply C techniques in a true to C++ style, and this nails it.
What is your evaluation of the implementation?
I did not review the r/b tree, but everything else seemed well written.
What is your evaluation of the documentation?
I found documentation lacking. I would like to see full class references: it took me a bit of hunting to find a commonly used function container::current() which was very frustrating.
What is your evaluation of the potential usefulness of the library?
I believe this is very useful for implementing complex data structures that must be memory efficient, or require knowing the exact size of their data.
Did you try to use the library? With what compiler? Did you have any problems?
Yes, tested with VC++ 2005 SP1, on x86 and x64. No problems.
How much effort did you put into your evaluation? A glance? A quick reading? In-depth study?
In depth, other than the r/b tree. I reviewed the implementation and built several benefiting data structures using it to get a full feel for the library.
Are you knowledgeable about the problem domain?
Sure.
And finally, every review should answer this question: Do you think the library should be accepted as a Boost library?
Absolutely, I vote to accept. -- Cory Nelson

Cory Nelson wrote:
What is your evaluation of the design?
Very good. It was a pleasure to use. I have long wanted an easy way to apply C techniques in a true to C++ style, and this nails it.
What is your evaluation of the implementation?
I did not review the r/b tree, but everything else seemed well written.
Thanks.
What is your evaluation of the documentation?
I found documentation lacking. I would like to see full class references: it took me a bit of hunting to find a commonly used function container::current() which was very frustrating.
What do you mean with full class references? Current reference http://ice.prohosting.com/newfunk/boost/libs/intrusive/doc/html/intrusive/re... lists all the operations of every public class. What do you think is missing?
And finally, every review should answer this question: Do you think the library should be accepted as a Boost library?
Absolutely, I vote to accept.
Thanks for you vote! Regards Ion

On 3/17/07, Ion Gaztañaga <igaztanaga@gmail.com> wrote:
Cory Nelson wrote:
What is your evaluation of the design?
Very good. It was a pleasure to use. I have long wanted an easy way to apply C techniques in a true to C++ style, and this nails it.
What is your evaluation of the implementation?
I did not review the r/b tree, but everything else seemed well written.
Thanks.
What is your evaluation of the documentation?
I found documentation lacking. I would like to see full class references: it took me a bit of hunting to find a commonly used function container::current() which was very frustrating.
What do you mean with full class references? Current reference
http://ice.prohosting.com/newfunk/boost/libs/intrusive/doc/html/intrusive/re...
lists all the operations of every public class. What do you think is missing?
Never mind, I apologize for that. I was taking a some notes while checking the library out and had written that down before finding the reference area, and it got mixed up while writing the final review. Who knew writing a review at 2am before going to bed would turn out to be a bad thing? :)
And finally, every review should answer this question: Do you think the library should be accepted as a Boost library?
Absolutely, I vote to accept.
Thanks for you vote!
Regards
Ion _______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
-- Cory Nelson http://www.int64.org
participants (2)
-
Cory Nelson
-
Ion Gaztañaga