Additions to optional<>

Hello I have a couple of pending additions to the Optional library. These are _new_ functions, so they shouldn't disrupt the release. Specifically: from_optional(o,default_value) and make_optional(condition,value) Given that the release is still ahead, is it OK to merge these additions to RC_1_34_0 or should I keep them in the trunk? TIA -- Fernando Cacciola SciSoft http://fcacciola.50webs.com/

"Fernando Cacciola" <fernando_cacciola@hotmail.com> wrote in message news:e4neec$u77$1@sea.gmane.org...
Hello
I have a couple of pending additions to the Optional library. These are _new_ functions, so they shouldn't disrupt the release. Specifically:
from_optional(o,default_value)
and
make_optional(condition,value)
Given that the release is still ahead, is it OK to merge these additions to RC_1_34_0 or should I keep them in the trunk?
TIA
-- Fernando Cacciola
I think these are wonderful additions and would love for them to be in 1.34! Michael Goldshteyn

Fernando Cacciola wrote:
make_optional(condition,value)
I think it would be best to also add such a constructor to optional (that will accept a value and a condition). Sometimes it would be both more convenient and more efficient this way. make_optional can simply call this constructor. It would be even better if the value could also be a parameter to T's constructor, including in_place. I hope I didn't throw too much at you... :-) Yuval
participants (3)
-
Fernando Cacciola
-
Michael Goldshteyn
-
Yuval Ronen