I would like to add boost::algorithm::is_clamped, how to proceed?
Hi, I would like to add is_clamped (that tests if the value is clamped, similar how we have std::is_sorted, std::sort). What would be the proper procedure? I have never committed to boost, so I have no access to any repository, no "contacts", so I have no idea if small proposals like this require just approval from owner or it needs broader discussion(for example in some cases it would be nice fix for missing chain comparison <https://www.geeksforgeeks.org/chaining-comparison-operators-python/> in core language, but then is_clamped name is not that nice, is_between might be nicer,...). Also I am not sure if this is the best place to ask for directions and do discussions, if you have some slack channel or forum you prefer please let me know. There was a proposal <http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p1440r0.html>for std::, but it is not in C++20. I have no relation to that proposal. regards, Ivan
On 7/24/2021 10:22 AM, Ivan Matek via Boost wrote:
Hi, I would like to add is_clamped (that tests if the value is clamped, similar how we have std::is_sorted, std::sort).
What would be the proper procedure?
I have never committed to boost, so I have no access to any repository, no "contacts", so I have no idea if small proposals like this require just approval from owner or it needs broader discussion(for example in some cases it would be nice fix for missing chain comparison <https://www.geeksforgeeks.org/chaining-comparison-operators-python/> in core language, but then is_clamped name is not that nice, is_between might be nicer,...).
Also I am not sure if this is the best place to ask for directions and do discussions, if you have some slack channel or forum you prefer please let me know.
You have posted to the right place. You can also, if you like, open https://github.com/boostorg/algorithm and create an issue or program a pull request if you like. With a pull request you do not have to have write access to a repository in order to create a programming change.
There was a proposal <http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p1440r0.html>for std::, but it is not in C++20. I have no relation to that proposal.
You have posted to the right place. You can also, if you like, open https://github.com/boostorg/algorithm and create an issue or program a pull request if you like. With a pull request you do not have to have write access to a repository in order to create a programming change.
I can not figure out how to enable tests on my local machine(I am opening
Thank you for reply, that will work for me, but I have a question wrt testing: On Sat, Jul 24, 2021 at 10:11 PM Edward Diener via Boost < boost@lists.boost.org> wrote: project as CMake project using VS). I found this in algorithm CMakeLists.txt but CMakeLists.txt does not exist in test folder:
if(BUILD_TESTING AND EXISTS "${CMAKE_CURRENT_SOURCE_DIR} /test/CMakeLists.txt") add_subdirectory(test)
endif()
Am I correct to assume that algorithm does not have it's tests enabled when building with CMake or am I missing something?
Please ignore last question, I will try to clone modular boost as per instructions here, and see how that goes (if I can get algorithm tests to run). https://github.com/boostorg/wiki/wiki/Getting-Started%3A-Overview On Sun, Jul 25, 2021 at 5:53 PM Ivan Matek <libbooze@gmail.com> wrote:
Thank you for reply, that will work for me, but I have a question wrt testing:
Hi everybody. I have a "culture" question: What is considered polite amount of time before pinging people about pull request on github? Also should I ping the individuals I guess are OWNERS of that code, or make general post here? regards, Ivan On Sun, Jul 25, 2021 at 7:46 PM Ivan Matek <libbooze@gmail.com> wrote:
Please ignore last question, I will try to clone modular boost as per instructions here, and see how that goes (if I can get algorithm tests to run). https://github.com/boostorg/wiki/wiki/Getting-Started%3A-Overview
On Sun, Jul 25, 2021 at 5:53 PM Ivan Matek <libbooze@gmail.com> wrote:
Thank you for reply, that will work for me, but I have a question wrt testing:
On 8/7/21 05:59, Ivan Matek via Boost wrote:
Hi everybody. I have a "culture" question: What is considered polite amount of time before pinging people about pull request on github? Also should I ping the individuals I guess are OWNERS of that code, or make general post here?
regards, Ivan
Generally, the ML here is a good place to follow-up. If a library isn't getting enough attention, the community can figure out how to help. Also on the "culture", please do not top post: <https://www.boost.org/community/policy.html#quoting> michael -- Michael Caisse Ciere Consulting ciere.com
On Sun, Aug 8, 2021 at 5:42 PM Michael Caisse via Boost < boost@lists.boost.org> wrote:
Also on the "culture", please do not top post: <https://www.boost.org/community/policy.html#quoting>
Thank you. On unrelated note: Are those docs also in some publicly available github repo? I would like to remove " Some people have to pay for, or wait for, each byte that they download from the list. " , seems a decade or so dated.
On 8/8/2021 1:24 PM, Ivan Matek via Boost wrote:
On Sun, Aug 8, 2021 at 5:42 PM Michael Caisse via Boost < boost@lists.boost.org> wrote:
Also on the "culture", please do not top post: <https://www.boost.org/community/policy.html#quoting>
Thank you. On unrelated note: Are those docs also in some publicly available github repo? I would like to remove " Some people have to pay for, or wait for, each byte that they download from the list. " , seems a decade or so dated.
On Mon, Aug 9, 2021 at 6:33 PM Edward Diener via Boost < boost@lists.boost.org> wrote:
https://github.com/boostorg/website.git
Thank you, I made a small pull request. https://github.com/boostorg/website/pull/636
participants (3)
-
Edward Diener -
Ivan Matek -
Michael Caisse