[crc] Missing reflector<>::reflect( ) on trunk

Hi Daryle, hi all, I am using the Hamigaki Archivers library ( http://hamigaki.sourceforge.jp/). This library depends on Boost.Crc. Somewhere in the code there is something like ... boost::detail::reflector<32>::reflect(0x12345678); This compiles fine using Boost 1.52.0, but fails using Boost Trunk. The following code part does not exist anymore in boost/crc.hpp ( on the Trunk ) ... // Function that reflects its argument template < std::size_t Bits > typename reflector<Bits>::value_type reflector<Bits>::reflect ( typename reflector<Bits>::value_type x ) { value_type reflection = 0; value_type const one = 1; for ( std::size_t i = 0 ; i < Bits ; ++i, x >>= 1 ) { if ( x & one ) { reflection |= ( one << (Bits - 1u - i) ); } } return reflection; } Is there any replacement? Thanks and regards, Fernando P.

On Wed, Jan 23, 2013 at 1:35 PM, Fernando Pelliccioni < fpelliccioni@gmail.com> wrote:
Hi Daryle, hi all,
I am using the Hamigaki Archivers library ( http://hamigaki.sourceforge.jp/ ). This library depends on Boost.Crc.
Somewhere in the code there is something like ...
boost::detail::reflector<32>::reflect(0x12345678);
This compiles fine using Boost 1.52.0, but fails using Boost Trunk. The following code part does not exist anymore in boost/crc.hpp ( on the Trunk ) ...
// Function that reflects its argument template < std::size_t Bits > typename reflector<Bits>::value_type reflector<Bits>::reflect ( typename reflector<Bits>::value_type x ) { value_type reflection = 0; value_type const one = 1;
for ( std::size_t i = 0 ; i < Bits ; ++i, x >>= 1 ) { if ( x & one ) { reflection |= ( one << (Bits - 1u - i) ); } }
return reflection; }
Is there any replacement?
Thanks and regards, Fernando P.
Has "reflect" been renamed to "reflect_q"?

On Jan 23, 2013, at 8:35 AM, Fernando Pelliccioni <fpelliccioni@gmail.com> wrote:
Hi Daryle, hi all,
I am using the Hamigaki Archivers library ( http://hamigaki.sourceforge.jp/). This library depends on Boost.Crc.
Somewhere in the code there is something like ...
boost::detail::reflector<32>::reflect(0x12345678);
This compiles fine using Boost 1.52.0, but fails using Boost Trunk. The following code part does not exist anymore in boost/crc.hpp ( on the Trunk ) …
[snipped]
Is there any replacement?
While poking at this, I noticed that boost/crc.hpp on the release branch has not been changed since 2009 (r53910), but the one on trunk has been updated several times since then. -- Marshall Marshall Clow Idio Software <mailto:mclow.lists@gmail.com> A.D. 1517: Martin Luther nails his 95 Theses to the church door and is promptly moderated down to (-1, Flamebait). -- Yu Suzuki

On Wed, Jan 23, 2013 at 2:45 PM, Marshall Clow <mclow.lists@gmail.com>wrote:
On Jan 23, 2013, at 8:35 AM, Fernando Pelliccioni <fpelliccioni@gmail.com> wrote:
Hi Daryle, hi all,
I am using the Hamigaki Archivers library ( http://hamigaki.sourceforge.jp/). This library depends on Boost.Crc.
Somewhere in the code there is something like ...
boost::detail::reflector<32>::reflect(0x12345678);
This compiles fine using Boost 1.52.0, but fails using Boost Trunk. The following code part does not exist anymore in boost/crc.hpp ( on the Trunk ) …
[snipped]
Is there any replacement?
While poking at this, I noticed that boost/crc.hpp on the release branch has not been changed since 2009 (r53910), but the one on trunk has been updated several times since then.
-- Marshall
There seems to be several changes since last December. I think these changes will be included in Boost 1.53, right? ( I don't have 1.53 Beta to check ) While the class in question is within the detail namespace , could affect other components. Regards, Fernando.

On Jan 23, 2013, at 9:55 AM, Fernando Pelliccioni <fpelliccioni@gmail.com> wrote:
On Wed, Jan 23, 2013 at 2:45 PM, Marshall Clow <mclow.lists@gmail.com>wrote:
On Jan 23, 2013, at 8:35 AM, Fernando Pelliccioni <fpelliccioni@gmail.com> wrote:
Hi Daryle, hi all,
I am using the Hamigaki Archivers library ( http://hamigaki.sourceforge.jp/). This library depends on Boost.Crc.
Somewhere in the code there is something like ...
boost::detail::reflector<32>::reflect(0x12345678);
This compiles fine using Boost 1.52.0, but fails using Boost Trunk. The following code part does not exist anymore in boost/crc.hpp ( on the Trunk ) …
[snipped]
Is there any replacement?
While poking at this, I noticed that boost/crc.hpp on the release branch has not been changed since 2009 (r53910), but the one on trunk has been updated several times since then.
-- Marshall
There seems to be several changes since last December. I think these changes will be included in Boost 1.53, right? ( I don't have 1.53 Beta to check )
The changes are not in the 1.53 beta.
While the class in question is within the detail namespace , could affect other components.
Classes in the 'detail' namespace are (by convention) "private" and "subject to change w/o notice" -- Marshall Marshall Clow Idio Software <mailto:mclow.lists@gmail.com> A.D. 1517: Martin Luther nails his 95 Theses to the church door and is promptly moderated down to (-1, Flamebait). -- Yu Suzuki

On Wed, Jan 23, 2013 at 3:09 PM, Marshall Clow <mclow.lists@gmail.com>wrote:
On Jan 23, 2013, at 9:55 AM, Fernando Pelliccioni <fpelliccioni@gmail.com> wrote:
On Wed, Jan 23, 2013 at 2:45 PM, Marshall Clow <mclow.lists@gmail.com wrote:
On Jan 23, 2013, at 8:35 AM, Fernando Pelliccioni < fpelliccioni@gmail.com> wrote:
Hi Daryle, hi all,
I am using the Hamigaki Archivers library ( http://hamigaki.sourceforge.jp/). This library depends on Boost.Crc.
Somewhere in the code there is something like ...
boost::detail::reflector<32>::reflect(0x12345678);
This compiles fine using Boost 1.52.0, but fails using Boost Trunk. The following code part does not exist anymore in boost/crc.hpp ( on the Trunk ) …
[snipped]
Is there any replacement?
While poking at this, I noticed that boost/crc.hpp on the release branch has not been changed since 2009 (r53910), but the one on trunk has been updated several times since then.
-- Marshall
There seems to be several changes since last December. I think these changes will be included in Boost 1.53, right? ( I don't have 1.53 Beta to check )
The changes are not in the 1.53 beta.
Thanks!
While the class in question is within the detail namespace , could affect other components.
Classes in the 'detail' namespace are (by convention) "private" and "subject to change w/o notice"
Yes, I know. Thanks again.
participants (2)
-
Fernando Pelliccioni
-
Marshall Clow