[concept_check] Merge changes to master
Hi, I merged some old changes to master, all warning fixes, all old enough to be fully tested on trunk: https://github.com/boostorg/concept_check/commit/229e3055a03210da4dd10d43bc5... https://github.com/boostorg/concept_check/commit/ccd9f52467953f4b569f52cb6a6... https://github.com/boostorg/concept_check/commit/9521991561bf574772ce48d38c2... https://github.com/boostorg/concept_check/commit/168e60aa3d5238cd25b341661a6... I cherry picked the first two because they're a bit old. It's a bit late now, but do you think I should have done this as a pull request? Daniel
I merged some old changes to master, all warning fixes, all old enough to be fully tested on trunk:
https://github.com/boostorg/concept_check/commit/229e3055a03210da4dd10d43bc5... https://github.com/boostorg/concept_check/commit/ccd9f52467953f4b569f52cb6a6... https://github.com/boostorg/concept_check/commit/9521991561bf574772ce48d38c2... https://github.com/boostorg/concept_check/commit/168e60aa3d5238cd25b341661a6...
I cherry picked the first two because they're a bit old. It's a bit late now, but do you think I should have done this as a pull request?
Do we have anyone to maintain that library anyway? If not you'd likely end up having to handle the pull request anyway :-( John.
On 8 December 2013 12:52, John Maddock
Do we have anyone to maintain that library anyway?
If not you'd likely end up having to handle the pull request anyway :-(
Just to give people a chance to comment really. I think anyone who's watching the repo will be notified, which is only one person in this case, but hopefully people will watch repos they care about.
On Sun, Dec 8, 2013 at 7:11 AM, Daniel James
Hi,
I merged some old changes to master, all warning fixes, all old enough to be fully tested on trunk:
https://github.com/boostorg/concept_check/commit/229e3055a03210da4dd10d43bc5...
https://github.com/boostorg/concept_check/commit/ccd9f52467953f4b569f52cb6a6...
https://github.com/boostorg/concept_check/commit/9521991561bf574772ce48d38c2...
https://github.com/boostorg/concept_check/commit/168e60aa3d5238cd25b341661a6...
I cherry picked the first two because they're a bit old. It's a bit late now, but do you think I should have done this as a pull request?
No, since AFAICT we do not have an active maintainer. This was one of the libraries I had in mind when I wrote the Community Maintained Libraries RFC. Also, we don't want to totally stop regular library maintenance activities while we collectively learn to do things the git way. By the way, was one of these the fix for the warning that has been driving STL crazy? If not we should look at that one too. Sorry, I don't have his recent email about it handy.... --Beman
participants (3)
-
Beman Dawes -
Daniel James -
John Maddock