Incorrect usage of test macros in octionion, quaternion, special_functions, regex, fusion.

Hello, several test macros are used with the wrong number of arguments by several tests: octonion_test: BOOST_REQUIRE_PREDICATE, BOOST_CHECK_PREDICATE quaternion_test: BOOST_REQUIRE_PREDICATE, BOOST_CHECK_PREDICATE sinc_test: BOOST_CHECK_PREDICATE unicode_iterator_test: BOOST_CHECK_EQUAL_COLLECTIONS Fusion still uses BOOST_TEST (which doesn't exist anymore). Regards, m

Martin Wille wrote:
Fusion still uses BOOST_TEST (which doesn't exist anymore).
I didn't replace them as I did with the others because there's nothing in the regression tests about fusion. In program_options/winmain.cpp, there is another problem with BOOST_CHECK_EQUAL_COLLECTIONS: http://tinyurl.com/58q8u There are a few other problems that are responsible for the major part of failing test cases: 1) a missing function IsDebuggerPresent() --> http://tinyurl.com/4va7p 2) error: namespace "boost" has no member "exit_success" --> http://tinyurl.com/44dj5 What is the migration strategy for these? Stefan

1) a missing function IsDebuggerPresent() --> http://tinyurl.com/4va7p
This logic suposed only to work for VC compiler and compatibale. Looks like some ifdef is in order. I will look into it
2) error: namespace "boost" has no member "exit_success" --> http://tinyurl.com/44dj5
Here is developer need to include proper header, since Boost.Test headers doesn't include one anymore. Gennadiy

Gennadiy Rozental wrote: [...]
2) error: namespace "boost" has no member "exit_success" --> http://tinyurl.com/44dj5
Here is developer need to include proper header, since Boost.Test headers doesn't include one anymore.
which header? Stefan

Somewhere in the E.U., le 11/02/2005 Bonjour In article <420A2D12.7000107@yahoo.com.au>, Martin Wille <mw8329@yahoo.com.au> wrote:
Hello,
several test macros are used with the wrong number of arguments by several tests:
octonion_test: BOOST_REQUIRE_PREDICATE, BOOST_CHECK_PREDICATE quaternion_test: BOOST_REQUIRE_PREDICATE, BOOST_CHECK_PREDICATE sinc_test: BOOST_CHECK_PREDICATE
[SNIP]
Regards, m
I know Boost.Test has changed, so I had planed to check what had to be done. You give me cause to check rather sooner than later ;-) . I should have a shot at that early next week. Merci Hubert Holin

Martin Wille wrote more than a week ago:
Hello,
several test macros are used with the wrong number of arguments by several tests:
octonion_test: BOOST_REQUIRE_PREDICATE, BOOST_CHECK_PREDICATE quaternion_test: BOOST_REQUIRE_PREDICATE, BOOST_CHECK_PREDICATE sinc_test: BOOST_CHECK_PREDICATE unicode_iterator_test: BOOST_CHECK_EQUAL_COLLECTIONS
Fusion still uses BOOST_TEST (which doesn't exist anymore).
I'm under the impression nothing has been fixed since I wrote that message, with the exception of the unicode_iterator_test (which fails for other reasons now). Regards, m

Martin Wille wrote:
Martin Wille wrote more than a week ago:
Hello,
several test macros are used with the wrong number of arguments by several tests:
octonion_test: BOOST_REQUIRE_PREDICATE, BOOST_CHECK_PREDICATE quaternion_test: BOOST_REQUIRE_PREDICATE, BOOST_CHECK_PREDICATE sinc_test: BOOST_CHECK_PREDICATE unicode_iterator_test: BOOST_CHECK_EQUAL_COLLECTIONS
Fusion still uses BOOST_TEST (which doesn't exist anymore).
I'm under the impression nothing has been fixed since I wrote that message, with the exception of the unicode_iterator_test (which fails for other reasons now).
AFAIK Fusion uses the BOOST_TEST macro from the <boost/detail/lightweight_test.hpp> header, so this is fine. Regards Hartmut

Hartmut Kaiser wrote:
AFAIK Fusion uses the BOOST_TEST macro from the <boost/detail/lightweight_test.hpp> header, so this is fine.
Strangely, I see errors saying that macro is undefined for gcc 3.4.3, gcc-4 and icc, not for other compilers. Maybe, other errors prevent the BOOST_TEST errors to show up or the macro gets defined only for some of the compilers. Regards, m

Somewhere in the E.U., le 24/02/2005 Bonjour In article <42145CFF.90800@yahoo.com.au>, Martin Wille <mw8329@yahoo.com.au> wrote:
Martin Wille wrote more than a week ago:
Hello,
several test macros are used with the wrong number of arguments by several tests:
octonion_test: BOOST_REQUIRE_PREDICATE, BOOST_CHECK_PREDICATE quaternion_test: BOOST_REQUIRE_PREDICATE, BOOST_CHECK_PREDICATE sinc_test: BOOST_CHECK_PREDICATE unicode_iterator_test: BOOST_CHECK_EQUAL_COLLECTIONS
Fusion still uses BOOST_TEST (which doesn't exist anymore).
I'm under the impression nothing has been fixed since I wrote that message, with the exception of the unicode_iterator_test (which fails for other reasons now).
Regards, m
_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
Well, actually, I am held up at the moment by what seems to be internal Boost.Test problems. I checked in a few days ago some modifications to the special functions tests, which take into account the modifications to the BOOST_CHECK_PREDICATE macro, but compilations still fails (Xcode 1.5): ************************************************************************* In file included from /Users/hubertholin/Documents/Scratch/for Boost/boost/libs/math/special_functions/special_functions_test.cpp:18: /Users/hubertholin/Documents/Scratch/for Boost/boost/boost/test/unit_test_suite_ex.hpp:45: error: no matching function for call to `boost::unit_test::test_case::test_case(boost::unit_test::const_string&, bool, int)' /Users/hubertholin/Documents/Scratch/for Boost/boost/boost/test/unit_test_suite.hpp:96: error: candidates are: boost::unit_test::test_case::test_case(const boost::unit_test::test_case&) /Users/hubertholin/Documents/Scratch/for Boost/boost/boost/test/unit_test_suite.hpp:101: error: boost::unit_test::test_case::test_case(boost::unit_test::basic_cstring<co nst char>, const boost::unit_test::callback0<boost::unit_test::ut_detail::unused>&) /Users/hubertholin/Documents/Scratch/for Boost/boost/boost/test/unit_test_suite.hpp:108: error: `boost::unit_test::test_case::~test_case()' is private /Users/hubertholin/Documents/Scratch/for Boost/boost/boost/test/unit_test_suite_ex.hpp:45: error: within this context ************************************************************************* Until this is sorted out, I will not update quaternions and octonions. Merci Hubert Holin
participants (5)
-
Gennadiy Rozental
-
Hartmut Kaiser
-
Hubert Holin
-
Martin Wille
-
Stefan Slapeta