[1.44.0][Math] Requesting permission to merge to release.
If possible, I'd like to fix this issue: https://svn.boost.org/trac/boost/ticket/4504 for the final 1.44 release. The fix is trivial: https://svn.boost.org/trac/boost/changeset?reponame=&new=64597%40trunk%2Fboost%2Fmath%2Fspecial_functions%2Fdetail%2Ft_distribution_inv.hpp&old=59129%40trunk%2Fboost%2Fmath%2Fspecial_functions%2Fdetail%2Ft_distribution_inv.hpp but the actual bug manifests as a rather nasty numerical error. There's also a related patch to update the tests, which is slightly more risky in that it adds many new test cases: https://svn.boost.org/trac/boost/changeset?reponame=&new=64597%40trunk%2Flibs%2Fmath%2Ftest%2Ftest_students_t.cpp&old=51576%40trunk%2Flibs%2Fmath%2Ftest%2Ftest_students_t.cpp. Is it acceptable to merge these to release at this late stage? Thanks, John.
On 8/4/2010 1:21 PM, John Maddock wrote:
If possible, I'd like to fix this issue: https://svn.boost.org/trac/boost/ticket/4504 for the final 1.44 release.
The fix is trivial: https://svn.boost.org/trac/boost/changeset?reponame=&new=64597%40trunk%2Fboost%2Fmath%2Fspecial_functions%2Fdetail%2Ft_distribution_inv.hpp&old=59129%40trunk%2Fboost%2Fmath%2Fspecial_functions%2Fdetail%2Ft_distribution_inv.hpp but the actual bug manifests as a rather nasty numerical error. There's also a related patch to update the tests, which is slightly more risky in that it adds many new test cases: https://svn.boost.org/trac/boost/changeset?reponame=&new=64597%40trunk%2Flibs%2Fmath%2Ftest%2Ftest_students_t.cpp&old=51576%40trunk%2Flibs%2Fmath%2Ftest%2Ftest_students_t.cpp.
Is it acceptable to merge these to release at this late stage?
Looks to me like this is a fix we want to have. Have the the trunk tests cycled? Beman, objections? -- Eric Niebler BoostPro Computing http://www.boostpro.com
Is it acceptable to merge these to release at this late stage?
Looks to me like this is a fix we want to have. Have the the trunk tests cycled? Beman, objections?
They have, there was one failure (Sun) where the tolerance level on the new tests appears to have been set too low, I've just upped the tolerance a touch and we'll see what happens... other than that it's looking OK. John.
On 8/6/2010 4:28 AM, John Maddock wrote:
Is it acceptable to merge these to release at this late stage?
Looks to me like this is a fix we want to have. Have the the trunk tests cycled? Beman, objections?
They have, there was one failure (Sun) where the tolerance level on the new tests appears to have been set too low, I've just upped the tolerance a touch and we'll see what happens... other than that it's looking OK.
I haven't heard any objections from Beman, so I'll make an executive decision: please merge. Thanks. -- Eric Niebler BoostPro Computing http://www.boostpro.com
They have, there was one failure (Sun) where the tolerance level on the new tests appears to have been set too low, I've just upped the tolerance a touch and we'll see what happens... other than that it's looking OK.
I haven't heard any objections from Beman, so I'll make an executive decision: please merge. Thanks.
Done. Cheers, John.
participants (2)
-
Eric Niebler -
John Maddock