Re: [boost] [filesystem, regex, asio] These three libraries successfully ported to Windows Phone 8.1
On 26 Jan 2015 15:51, Niall Douglas wrote:
When the code has passed the regression suite I will issue a pull
request against the GitHub repository.
Some tips for creating a successful pull request:
1. Avoid #ifdef spam. Write thunk emulations of missing APIs where possible. Here's an example for GetTickCount64():
https://github.com/boostorg/thread/blob/master/include/boost/thread/wi
n32/thread_primitives.hpp#L290. Remember Boost still supports Windows XP and exclusively targets an XP level Win32 API. Use GetProcAddress for newer APIs.
2. Avoid using macros to implement functionality.
3. Don't forget to modify the documentation where needed to support the changes.
4. It might sound obvious, but make sure the unit test suite still passes on Windows XP in default build settings on all of MSVC-8,
mingw32 and mingw-w64. You'd be surprised how often pull requests don't because they use some Vista or later API, or an API not supported by mingw32. If a pull request doesn't instantly go all green on all supported platforms it tends to not be merged and get put > off till much later (sometimes forever).
Right now cygwin support is broken at least in thread, but other libraries are probably a lot better, so test that too.
5. Consider additional unit tests where appropriate. In this situation I'd doubt you'd need them.
These are excellent points, obviously the product of your own "battles" with modifying the Boost source base. Many thanks for sharing them, and now is the perfect time to learn them.
And thank you very much for the improved WinRT support.
My pleasure. It was an education for me (in the positive sense of the word!) participating in porting Boost. I will only rest on my laurels once the port authorized by the crew and back in the repository <g>. Moshe
-----Original Message----- From: Boost [mailto:boost-bounces@lists.boost.org] On Behalf Of Moshe Rubin Sent: 27 January 2015 09:47 To: boost@lists.boost.org Subject: Re: [boost] [filesystem, regex, asio] These three libraries successfully ported to Windows Phone 8.1
And thank you very much for the improved WinRT support.
My pleasure. It was an education for me (in the positive sense of the word!) participating in porting Boost. I will only rest on my laurels once the port authorized by the crew and back in the repository <g>.
I'm pleased to see that Windows Phone developers will now be able to use these Boost libraries. I'm also curious to know if you have tried to port the Boost.Math library? Although it contains a lot of esoteric mathy stuff that are unlikely to be mainstream on a phone app, there are also some very simple-to-use statistics stuff that will/should be widely applicable. Have you tried this yet? Are there any obstacles that you can foresee? Paul --- Paul A. Bristow Prizet Farmhouse Kendal UK LA8 8AB +44 (0) 1539 561830
On 27 Jan 2015 at 9:46, Moshe Rubin wrote:
These are excellent points, obviously the product of your own "battles" with modifying the Boost source base. Many thanks for sharing them, and now is the perfect time to learn them.
It's more that I would impose those requirements on those sending pull requests if they want them accepted. I help maintain Boost.Thread, plus quite a few other open source libraries.
And thank you very much for the improved WinRT support.
My pleasure. It was an education for me (in the positive sense of the word!) participating in porting Boost. I will only rest on my laurels once the port authorized by the crew and back in the repository <g>.
And once again, my apologies for earlier. It is no excuse, but that particular day I had the misfortune of combining codeine and a lot of cough medicine due to a heavy flu. This affected my mind. I was quite appalled with myself when I read what I had written to you the next day, very embarrassing, I was clearly off in a grim imagination land and had completely underestimated its effects on my wits. As a token of making good on my earlier behaviours, do feel free to email me off list to review your pull requests for any problems, either before or after you submit them. And thank you once again for making the effort, it is hugely appreciated here. Niall -- ned Productions Limited Consulting http://www.nedproductions.biz/ http://ie.linkedin.com/in/nialldouglas/
participants (3)
-
Moshe Rubin -
Niall Douglas -
Paul A. Bristow