[1.51][ICL] Last minute commit
Hi, unaware of the fact that commits to the release branch need permission this week I did a commit today (Revision 79767). Sorry for that. So I'd like to ask for permission now. In other words, is it possible to not reverse this commit? Thanks, Joachim -- Interval Container Library [Boost.Icl] http://www.joachim-faulhaber.de
On 7/27/2012 1:09 AM, Joachim Faulhaber wrote:
Which commit? Are the tests passing on the release branch? If so, I'm inclined to leave it in. Review managers: weren't we locking the release branch to prevent these inadvertent check-ins? Who was handling that? -- Eric Niebler BoostPro Computing http://www.boostpro.com
2012/7/27 Eric Niebler <eric@boostpro.com>:
My svn log says: Revision: 79767 Author: jofaber Date: Freitag, 27. Juli 2012 09:05:11 (CET) Message: Merged revision(s) 79696 from trunk/boost/icl: Added missing const for icl::map copy ctor. ........ ---- Modified : /branches/release/boost/icl Modified : /branches/release/boost/icl/map.hpp (diff-file as attachment)
Are the tests passing on the release branch?
The tests on the trunk are all ok for the last week. On the release branch only a few tests are completed after the commit. These are all ok.
If so, I'm inclined to leave it in.
Sorry for the inconvenience, Joachim -- Interval Container Library [Boost.Icl] http://www.joachim-faulhaber.de
2012/7/28 Joachim Faulhaber <afojgo@googlemail.com>:
http://www.boost.org/development/tests/release/developer/icl.html looks good (green). 24 of 35 configurations are meanwhile completed and everything stays green.
If so, I'm inclined to leave it in.
so I hope to fulfill your requirement ;) Cheers, Joachim -- Interval Container Library [Boost.Icl] http://www.joachim-faulhaber.de
On 27 July 2012 17:14, Eric Niebler <eric@boostpro.com> wrote:
Review managers: weren't we locking the release branch to prevent these inadvertent check-ins? Who was handling that?
Rene did that a while ago, but I don't think it was ever done again. He's busy with other things at the moment.
participants (3)
-
Daniel James -
Eric Niebler -
Joachim Faulhaber