Hi, Attached is a patch for functional/hash. The first chunk essentially gets rid of some UB (the same technique was already applied for the remainder so this looks like an oversight). I don't remember why exactly i added the second chunk, it helps on some compilers though (I think gcc on Android). Save to apply that patch? Regards, Thomas
On 27 December 2012 12:23, Thomas Heller <thom.heller@gmail.com> wrote:
Hi,
Attached is a patch for functional/hash. The first chunk essentially gets rid of some UB (the same technique was already applied for the remainder so this looks like an oversight).
Go ahead with that one.
I don't remember why exactly i added the second chunk, it helps on some compilers though (I think gcc on Android). Save to apply that patch?
I would need a way to reproduce that, it has worked without problems for years on many versions of gcc.
On Thursday, December 27, 2012 10:43:22 Daniel James wrote:
On 27 December 2012 12:23, Thomas Heller <thom.heller@gmail.com> wrote:
Hi,
Attached is a patch for functional/hash. The first chunk essentially gets rid of some UB (the same technique was already applied for the remainder so this looks like an oversight).
Go ahead with that one.
Done.
I don't remember why exactly i added the second chunk, it helps on some compilers though (I think gcc on Android). Save to apply that patch?
I would need a way to reproduce that, it has worked without problems for years on many versions of gcc.
Ok, I reverted it for now ... i'll report again whenever i see it popping up again.
participants (2)
-
Daniel James -
Thomas Heller