[inspect] Apple macro check
Hi, The apple macro errors in the inspect report are only really a problem when certain apple headers are included. This never happens when we can control which headers are included so I think it's only a problem under the boost directory. So is it okay if I change inspect so that it only checks for apple macros under 'boost'? Daniel
On 6/17/2010 11:19 AM, Daniel James wrote:
Hi,
The apple macro errors in the inspect report are only really a problem when certain apple headers are included. This never happens when we can control which headers are included so I think it's only a problem under the boost directory. So is it okay if I change inspect so that it only checks for apple macros under 'boost'?
Sounds ok to me, as long as apple headers don't get dragged in by some system header included by, say, asio or filesystem. -- Eric Niebler BoostPro Computing http://www.boostpro.com
On Thu, Jun 17, 2010 at 8:19 AM, Daniel James <dnljms@gmail.com> wrote:
Hi,
The apple macro errors in the inspect report are only really a problem when certain apple headers are included. This never happens when we can control which headers are included so I think it's only a problem under the boost directory. So is it okay if I change inspect so that it only checks for apple macros under 'boost'?
What Apple macros are you referring to? - Doug
On Thu, Jun 17, 2010 at 11:46 AM, Doug Gregor <doug.gregor@gmail.com> wrote:
On Thu, Jun 17, 2010 at 8:19 AM, Daniel James <dnljms@gmail.com> wrote:
Hi,
The apple macro errors in the inspect report are only really a problem when certain apple headers are included. This never happens when we can control which headers are included so I think it's only a problem under the boost directory. So is it okay if I change inspect so that it only checks for apple macros under 'boost'?
What Apple macros are you referring to?
Apple has a header called <AssertMacros.h> that #defines both “check” and “check_error”, and other similar names, See https://svn.boost.org/trac/boost/ticket/2115 --Beman
On Thu, Jun 17, 2010 at 9:27 AM, Beman Dawes <bdawes@acm.org> wrote:
On Thu, Jun 17, 2010 at 11:46 AM, Doug Gregor <doug.gregor@gmail.com> wrote:
On Thu, Jun 17, 2010 at 8:19 AM, Daniel James <dnljms@gmail.com> wrote:
Hi,
The apple macro errors in the inspect report are only really a problem when certain apple headers are included. This never happens when we can control which headers are included so I think it's only a problem under the boost directory. So is it okay if I change inspect so that it only checks for apple macros under 'boost'?
What Apple macros are you referring to?
Apple has a header called <AssertMacros.h> that #defines both “check” and “check_error”, and other similar names,
Oh, that's horrible. Thanks for the clarification! - Doug
On Jun 17, 2010, at 9:40 AM, Doug Gregor wrote:
On Thu, Jun 17, 2010 at 9:27 AM, Beman Dawes <bdawes@acm.org> wrote:
On Thu, Jun 17, 2010 at 11:46 AM, Doug Gregor <doug.gregor@gmail.com> wrote:
On Thu, Jun 17, 2010 at 8:19 AM, Daniel James <dnljms@gmail.com> wrote:
Hi,
The apple macro errors in the inspect report are only really a problem when certain apple headers are included. This never happens when we can control which headers are included so I think it's only a problem under the boost directory. So is it okay if I change inspect so that it only checks for apple macros under 'boost'?
What Apple macros are you referring to?
Apple has a header called <AssertMacros.h> that #defines both “check” and “check_error”, and other similar names,
Oh, that's horrible. Thanks for the clarification!
Here's the source for those macros: http://www.mactech.com/articles/develop/issue_11/Parent_final.html Develop was an in-house Apple magazine about programming; quite good, actually. Check out who was the author ;-) Of course, it was 1992. We've all learned since then... It amazes me that they're still in use, though - and that Apple still ships them as part of the developer tools. -- Marshall
participants (5)
-
Beman Dawes -
Daniel James -
Doug Gregor -
Eric Niebler -
Marshall Clow