Re: [boost] [Boost-commit] svn:boost r67792 - in branches/release: boost/iterator
Hi Marshall, It seems there are missing merges in changeset [67792]. <marshall@idio.com> wrote:
Author: marshall Date: 2011-01-08 13:38:08 EST (Sat, 08 Jan 2011) New Revision: 67792 URL: http://svn.boost.org/trac/boost/changeset/67792
Log: Merging fixes to release; fixes #2294 fixes #4918 fixes #3645 refs #2823 refs #1427 refs #2893 Properties modified: branches/release/boost/concept_check.hpp (contents, props changed) branches/release/boost/fusion/container/list/detail/build_cons.hpp (contents, props changed) branches/release/boost/iterator/iterator_facade.hpp (contents, props changed) branches/release/status/explicit-failures-markup.xml (contents, props changed) Text files modified: branches/release/boost/concept_check.hpp | 166 ++++++++++++++++++++------------ branches/release/boost/fusion/container/list/detail/build_cons.hpp | 3 branches/release/boost/iterator/iterator_facade.hpp | 28 ++-- branches/release/status/explicit-failures-markup.xml | 199 ++++++++++++++++++++++++++++----------- 4 files changed, 261 insertions(+), 135 deletions(-)
The log message says that the fixes for tickets #1427 and #2893 (#1427: transform_iterator should use boost::result_of to determine functor result type) (#2893: Function Input Iterator) are merged to release. But this changeset does nothing with iterator/transform_iterator.hpp and iterator/function_input_iterator.hpp. Regards, Michel
On Jan 11, 2011, at 6:46 PM, Michel MORIN wrote:
Hi Marshall,
It seems there are missing merges in changeset [67792].
<marshall@idio.com> wrote:
Author: marshall Date: 2011-01-08 13:38:08 EST (Sat, 08 Jan 2011) New Revision: 67792 URL: http://svn.boost.org/trac/boost/changeset/67792
Log: Merging fixes to release; fixes #2294 fixes #4918 fixes #3645 refs #2823 refs #1427 refs #2893 Properties modified: branches/release/boost/concept_check.hpp (contents, props changed) branches/release/boost/fusion/container/list/detail/build_cons.hpp (contents, props changed) branches/release/boost/iterator/iterator_facade.hpp (contents, props changed) branches/release/status/explicit-failures-markup.xml (contents, props changed) Text files modified: branches/release/boost/concept_check.hpp | 166 ++++++++++++++++++++------------ branches/release/boost/fusion/container/list/detail/build_cons.hpp | 3 branches/release/boost/iterator/iterator_facade.hpp | 28 ++-- branches/release/status/explicit-failures-markup.xml | 199 ++++++++++++++++++++++++++++----------- 4 files changed, 261 insertions(+), 135 deletions(-)
The log message says that the fixes for tickets #1427 and #2893 (#1427: transform_iterator should use boost::result_of to determine functor result type) (#2893: Function Input Iterator) are merged to release. But this changeset does nothing with iterator/transform_iterator.hpp and iterator/function_input_iterator.hpp.
Yes, this was my mistake. I merged several changes, and tried to figure out which tickets were affected by looking at svn log entries - and I got those two wrong :-( Sorry about that. -- Marshall Marshall Clow Idio Software <mailto:mclow.lists@gmail.com> A.D. 1517: Martin Luther nails his 95 Theses to the church door and is promptly moderated down to (-1, Flamebait). -- Yu Suzuki
Marshall Clow wrote:
On Jan 11, 2011, at 6:46 PM, Michel MORIN wrote:
The log message says that the fixes for tickets #1427 and #2893 (#1427: transform_iterator should use boost::result_of to determine functor result type) (#2893: Function Input Iterator) are merged to release. But this changeset does nothing with iterator/transform_iterator.hpp and iterator/function_input_iterator.hpp.
I merged several changes, and tried to figure out which tickets were affected by looking at svn log entries - and I got those two wrong :-(
Ah, I see ;-) Marshall, great thanks for your effort! * Ticket #2893 I reopened #2893 because function_input_iterator is not added to release yet. * Ticket #1427 I also reopened #1427 because I found a bug in the updated code. transform_iterator should use 'result_of<UnaryFunc(Iterator::reference)>' but the code uses 'result_of<UnaryFunc(Iterator::reference)>'. A patch is attached in #1427 which is extremely simple. Is there a chance that this will be fixed in Boost 1.46? Regards, Michel
On Jan 17, 2011, at 5:16 AM, Michel MORIN wrote:
Marshall Clow wrote:
On Jan 11, 2011, at 6:46 PM, Michel MORIN wrote:
The log message says that the fixes for tickets #1427 and #2893 (#1427: transform_iterator should use boost::result_of to determine functor result type) (#2893: Function Input Iterator) are merged to release. But this changeset does nothing with iterator/transform_iterator.hpp and iterator/function_input_iterator.hpp.
I merged several changes, and tried to figure out which tickets were affected by looking at svn log entries - and I got those two wrong :-(
Ah, I see ;-) Marshall, great thanks for your effort!
* Ticket #2893 I reopened #2893 because function_input_iterator is not added to release yet.
* Ticket #1427 I also reopened #1427 because I found a bug in the updated code. transform_iterator should use 'result_of<UnaryFunc(Iterator::reference)>' but the code uses 'result_of<UnaryFunc(Iterator::reference)>'.
A patch is attached in #1427 which is extremely simple. Is there a chance that this will be fixed in Boost 1.46?
Michel - I've committed your patches to the trunk - thanks! I don't think that they will be in 1.46, since I need to wait for the tests to cycle (which takes a couple days), and the deadline for merging stuff to release is _today_. -- Marshall Marshall Clow Idio Software <mailto:mclow.lists@gmail.com> A.D. 1517: Martin Luther nails his 95 Theses to the church door and is promptly moderated down to (-1, Flamebait). -- Yu Suzuki
Marshall Clow wrote:
On Jan 17, 2011, at 5:16 AM, Michel MORIN wrote:
* Ticket #1427 I also reopened #1427 because I found a bug in the updated code. transform_iterator should use 'result_of<UnaryFunc(Iterator::reference)>' but the code uses 'result_of<UnaryFunc(Iterator::reference)>'.
A patch is attached in #1427 which is extremely simple. Is there a chance that this will be fixed in Boost 1.46?
Michel -
I've committed your patches to the trunk - thanks!
I don't think that they will be in 1.46, since I need to wait for the tests to cycle (which takes a couple days), and the deadline for merging stuff to release is _today_.
Yeah, that was too last minute... In my experiments, this bug is a "showstopper" for using this feature (i.e. using result_of to determine the return type of functors in transform_iterator). This feature has been requested by a not so small number of people, and so it might be risky to ship this in an incomplete implementation, IMHO. But, anyway, it is too late. Assuming we cannot change the code (either merging the new commitment or reverting the result_of support), what we can do is to mention this deficiency in the release note. (Currently, the release note says: http://svn.boost.org/svn/boost/website/public_html/beta/feed/history/boost_1... * `transform_iterator` now uses `boost::result_of` to determine functor result type ([@https://svn.boost.org/trac/boost/ticket/1427 #1427]) Another choice is to delete this release note?) Regards, Michel
participants (2)
-
Marshall Clow -
Michel MORIN