Reminder: 1.65 closes for major changes tomorrow
Upcoming release dates: 28-Jun: Boost 1.65.0 closed for major changes 5-Jul: Boost 1.65.0 closed for all changes, except by permission of a release manager. 8-Jul: Boost 1.65.0 closed for all changes 12-Jul: Boost 1.65.0 beta; master branch re-opened 2-Aug: Release closed for all changes, except by permission of a release manager. 5-Aug: Boost 1.65.0 closed for all changes 9-Aug: Boost 1.65.0 release -- Marshall
28-Jun: Boost 1.65.0 closed for major changes
I take this opportunity to report an issue I have: I submitted a patch for a bug many times and got no answer. I do not know how to proceed to have it applied. Could you tell me what to do? https://svn.boost.org/trac10/ticket/9517 Thanks, Frédéric
Frédéric Bron wrote:
28-Jun: Boost 1.65.0 closed for major changes
I take this opportunity to report an issue I have: I submitted a patch for a bug many times and got no answer. I do not know how to proceed to have it applied. Could you tell me what to do?
Have you tried to contact Christian Henning?
I take this opportunity to report an issue I have: I submitted a patch for a bug many times and got no answer. I do not know how to proceed to have it applied. Could you tell me what to do?
Have you tried to contact Christian Henning?
No, is he the maintainer to GIL? I will contact him. Thanks, Frédéric
On 6/27/17 08:11, Frédéric Bron via Boost wrote:
I take this opportunity to report an issue I have: I submitted a patch for a bug many times and got no answer. I do not know how to proceed to have it applied. Could you tell me what to do?
Have you tried to contact Christian Henning?
No, is he the maintainer to GIL? I will contact him. Thanks,
Hi Frédéric - Christian is the maintainer. I looked at your patch and I guess I would have used .max(). Regardless, can you please make a PR. Sigh ... so I just looked and sadly master hasn't been updated for 7-years. I'll independently contact Christian and figure out what we need to do with this library. Take care - michael -- Michael Caisse Ciere Consulting ciere.com
Frédéric Bron wrote:
Christian is the maintainer. I looked at your patch and I guess I would have used .max().
yes, both should give the same. I agree with max().
constexpr max() is C++11 - the context here is a template parameter if I understand correctly. static_cast<>(-1) works on C++03.
-----Original Message----- From: Boost [mailto:boost-bounces@lists.boost.org] On Behalf Of Peter Dimov via Boost Sent: 27 June 2017 17:01 To: boost@lists.boost.org Cc: Peter Dimov Subject: Re: [boost] Reminder: 1.65 closes for major changes tomorrow
Frédéric Bron wrote:
Christian is the maintainer. I looked at your patch and I guess I would have used .max().
yes, both should give the same. I agree with max().
constexpr max() is C++11 - the context here is a template parameter if I understand correctly. static_cast<>(-1) works on C++03.
Do any of the macros BOOST_CONSTEXPR, BOOST_CONSTEXPR_OR_CONST, BOOST_STATIC_CONSTEXPR ... http://www.boost.org/doc/libs/1_64_0/libs/config/doc/html/boost_config/boost... help you here? Paul --- Paul A. Bristow Prizet Farmhouse Kendal UK LA8 8AB +44 (0) 1539 561830
constexpr max() is C++11 - the context here is a template parameter if I understand correctly. static_cast<>(-1) works on C++03.
Do any of the macros BOOST_CONSTEXPR, BOOST_CONSTEXPR_OR_CONST, BOOST_STATIC_CONSTEXPR ...
I do not think these macros are useful here: we do not define a function here. We need numeric_limits<UInteger>::max() value at compile time as a template parameter and in C++03, ::max() is not constexpr so that we have to use static_cast<UInteger>(-1) to have it work on all c++ versions. Frédéric
-----Original Message----- From: Boost [mailto:boost-bounces@lists.boost.org] On Behalf Of Peter Dimov via Boost Sent: 27 June 2017 17:01 To: boost@lists.boost.org Cc: Peter Dimov Subject: Re: [boost] Reminder: 1.65 closes for major changes tomorrow
Frédéric Bron wrote:
Christian is the maintainer. I looked at your patch and I guess I would have used .max().
yes, both should give the same. I agree with max().
constexpr max() is C++11 - the context here is a template parameter if I understand correctly. static_cast<>(-1) works on C++03.
_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
Regardless, can you please make a PR. OK, I have to understand what a pull request means.
I tried to follow this page but wasn't successful: https://svn.boost.org/trac10/wiki/StartModPatchAndPullReq In particular, for "Forking a Single Repo", I do not understand "Go to the GitHub page for the library's repo, and fork it.". Apparently when I forked, I forked the entire boost, not only gil. Where can I find the library's repo? Frédéric
On 27.06.2017 15:48, Frédéric Bron via Boost wrote:
Regardless, can you please make a PR. OK, I have to understand what a pull request means.
I tried to follow this page but wasn't successful: https://svn.boost.org/trac10/wiki/StartModPatchAndPullReq
In particular, for "Forking a Single Repo", I do not understand "Go to the GitHub page for the library's repo, and fork it.". Apparently when I forked, I forked the entire boost, not only gil. Where can I find the library's repo?
https://github.com/boostorg/gil (have a look at its .travis file - notably the 'install' section - to see how to do a quick build and test locally, before you submit the PR) Stefan -- ...ich hab' noch einen Koffer in Berlin...
participants (6)
-
Frédéric Bron -
Marshall Clow -
Michael Caisse -
Paul A. Bristow -
Peter Dimov -
Stefan Seefeld