Hi, I just noticed that in file http://svn.boost.org/svn/boost/trunk/boost/graph/sloan_ordering.hpp there is this line: #define MAXINT 2147483647 I'm afraid that it can conflict with MAXINT defined elsewhere. Or at least cause some confusion between MAXINT and INT_MAX from <limits.h> Wouldn't it be better to just #include <limits.h> and use INT_MAX defined there? -- Janek Kozicki |
Hello :-) Not to be coy, but I would suggest using: #include <limits> ... (std::numeric_limits<int>::max)(); Cheers, Brandon -------------------------------------------------- From: "Janek Kozicki" <janek_listy@wp.pl> Sent: Wednesday, September 24, 2008 3:57 AM To: <boost@lists.boost.org> Subject: [boost] [graph] MAXINT problem
Hi,
I just noticed that in file
http://svn.boost.org/svn/boost/trunk/boost/graph/sloan_ordering.hpp
there is this line:
#define MAXINT 2147483647
I'm afraid that it can conflict with MAXINT defined elsewhere. Or at least cause some confusion between MAXINT and INT_MAX from <limits.h>
Wouldn't it be better to just #include <limits.h> and use INT_MAX defined there?
-- Janek Kozicki | _______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
Not to be coy, but I would suggest using:
#include <limits> ... (std::numeric_limits<int>::max)();
Cheers,
or that.
Should I file a bug report?
Yes. Filing a ticket would probably be a good idea just to make sure that the problem is documented (even though the solution is trivial). Andrew Sutton asutton@cs.kent.edu
participants (3)
-
Andrew Sutton -
Brandon Kohn -
Janek Kozicki