[type_traits] Should namespace boost::align be namespace boost::detail::align?
I was working on a tiny library, Boost.Align, which would provide (among other things) a boost::align (that would be std::align if BOOST_NO_CXX11_STD_ALIGN is not defined, or a reasonably non-portable implementation otherwise) and found that type_with_alignment.hpp uses the identifier 'align' for a namespace within namespace 'boost'. Was this namespace intended to not be within boost::detail? If it can be, I'll send a pull request; if not, I'll choose a different identifier over 'align'. Glen
I was working on a tiny library, Boost.Align, which would provide (among other things) a boost::align (that would be std::align if BOOST_NO_CXX11_STD_ALIGN is not defined, or a reasonably non-portable implementation otherwise) and found that type_with_alignment.hpp uses the identifier 'align' for a namespace within namespace 'boost'.
Was this namespace intended to not be within boost::detail? If it can be, I'll send a pull request; if not, I'll choose a different identifier over 'align'.
It's a mistake. I'm testing a rename now, will hopefully commit soon. John.
On 18/02/2014 08:58, Glen Fernandes wrote:
I was working on a tiny library, Boost.Align, which would provide (among other things) a boost::align (that would be std::align if BOOST_NO_CXX11_STD_ALIGN is not defined, or a reasonably non-portable implementation otherwise) and found that type_with_alignment.hpp uses the identifier 'align' for a namespace within namespace 'boost'.
Was this namespace intended to not be within boost::detail? If it can be, I'll send a pull request; if not, I'll choose a different identifier over 'align'.
Fixed in develop. John.
participants (2)
-
Glen Fernandes -
John Maddock