[range] iterator_range.hpp using undefined BOOST_MSVC and BOOST_WORKAROUND

range/iterator_range.hpp is using BOOST_MSVC and BOOST_WORKAROUND before including boost/config.hpp and boost/detail/workaround.hpp. The patch fixes it. OK to apply? -- Eric Niebler Boost Consulting www.boost-consulting.com Index: iterator_range.hpp =================================================================== --- iterator_range.hpp (revision 43198) +++ iterator_range.hpp (working copy) @@ -11,13 +11,15 @@ #ifndef BOOST_RANGE_ITERATOR_RANGE_HPP #define BOOST_RANGE_ITERATOR_RANGE_HPP +#include <boost/config.hpp> // Define __STL_CONFIG_H, if appropriate. +#include <boost/detail/workaround.hpp> + #if BOOST_WORKAROUND(BOOST_MSVC, BOOST_TESTED_AT(1500)) #pragma warning( push ) #pragma warning( disable : 4996 ) #endif // From boost/dynamic_bitset.hpp; thanks to Matthias Troyer for Cray X1 patch. -#include <boost/config.hpp> // Define __STL_CONFIG_H, if appropriate. #ifndef BOOST_OLD_IOSTREAMS # if defined(__STL_CONFIG_H) && \ !defined (__STL_USE_NEW_IOSTREAMS) && !defined(__crayx1) \ @@ -26,7 +28,6 @@ # endif #endif // #ifndef BOOST_OLD_IOSTREAMS -#include <boost/detail/workaround.hpp> #include <boost/range/functions.hpp> #include <boost/range/iterator.hpp> #include <boost/range/difference_type.hpp>

on Sat Feb 09 2008, Eric Niebler <eric-AT-boost-consulting.com> wrote:
range/iterator_range.hpp is using BOOST_MSVC and BOOST_WORKAROUND before including boost/config.hpp and boost/detail/workaround.hpp. The patch fixes it. OK to apply?
Eric, for fixes like this I think you don't need to ask. -- Dave Abrahams Boost Consulting http://boost-consulting.com

David Abrahams wrote:
on Sat Feb 09 2008, Eric Niebler <eric-AT-boost-consulting.com> wrote:
range/iterator_range.hpp is using BOOST_MSVC and BOOST_WORKAROUND before including boost/config.hpp and boost/detail/workaround.hpp. The patch fixes it. OK to apply?
Eric, for fixes like this I think you don't need to ask.
OK, applied to trunk in revision 43220. -- Eric Niebler Boost Consulting www.boost-consulting.com

Eric Niebler skrev:
David Abrahams wrote:
on Sat Feb 09 2008, Eric Niebler <eric-AT-boost-consulting.com> wrote:
range/iterator_range.hpp is using BOOST_MSVC and BOOST_WORKAROUND before including boost/config.hpp and boost/detail/workaround.hpp. The patch fixes it. OK to apply? Eric, for fixes like this I think you don't need to ask.
Thanks. Thorsten
participants (3)
-
David Abrahams
-
Eric Niebler
-
Thorsten Ottosen