[release] Master branch now completely closed for the 1.70.0 release
The master branch is now closed for all changes except by permission for the release. Also, remember to add your libraries' changes to the release notes at: < https://github.com/boostorg/website/blob/master/feed/history/boost_1_70_0.qb...
Thanks, -- The Boost Release Team
On 04/04/2019 15:24, Marshall Clow via Boost wrote:
The master branch is now closed for all changes except by permission for the release.
I'm not entirely sure about this one, but one Boost.Math header has a comment with some invalid characters in it (cut and paste error from a PDF I suspect). The fix is trivial: https://github.com/boostorg/math/commit/166e5fb5130ac76d38c4056236e7f408b009... Should we cherry pick? Note that it's not shown up as an issue in the CI tests, I suspect it only causes problems on Windows machines that are not using a US or Western European code page. But when it does cause an issue it's a hard compiler error. Thanks, John. --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus
On Thu, Apr 4, 2019 at 9:35 AM John Maddock via Boost
On 04/04/2019 15:24, Marshall Clow via Boost wrote:
The master branch is now closed for all changes except by permission for the release.
I'm not entirely sure about this one, but one Boost.Math header has a comment with some invalid characters in it (cut and paste error from a PDF I suspect). The fix is trivial:
https://github.com/boostorg/math/commit/166e5fb5130ac76d38c4056236e7f408b009...
Should we cherry pick?
Note that it's not shown up as an issue in the CI tests, I suspect it only causes problems on Windows machines that are not using a US or Western European code page. But when it does cause an issue it's a hard compiler error.
If we do an RC2, let's fix that - but I don't know that it's worth rolling an RC2 for this one fix. -- Marshall
On Thu, Apr 4, 2019 at 6:35 PM John Maddock via Boost
On 04/04/2019 15:24, Marshall Clow via Boost wrote:
The master branch is now closed for all changes except by permission for the release.
I'm not entirely sure about this one, but one Boost.Math header has a comment with some invalid characters in it (cut and paste error from a PDF I suspect). The fix is trivial:
https://github.com/boostorg/math/commit/166e5fb5130ac76d38c4056236e7f408b009...
Should we cherry pick?
Note that it's not shown up as an issue in the CI tests, I suspect it only causes problems on Windows machines that are not using a US or Western European code page. But when it does cause an issue it's a hard compiler error.
John - Please cherry pick that to master. -- Marshall
John -
Please cherry pick that to master.
Done. If we're doing an RC2, then this one https://github.com/boostorg/config/commit/6fe7117b2e43089fdca4a9ec8dfae9b390... which enables Boost.Config auto-linking support for vc14.2 would cut down on the support requests no end ;) Thanks, John. --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus
On Sun, Apr 7, 2019 at 6:34 PM John Maddock via Boost
John -
Please cherry pick that to master.
Done.
If we're doing an RC2, then this one
https://github.com/boostorg/config/commit/6fe7117b2e43089fdca4a9ec8dfae9b390... which enables Boost.Config auto-linking support for vc14.2 would cut down on the support requests no end ;)
Thanks, John.
this is https://github.com/boostorg/config/pull/275, right? I thought I asked you to merge that already. -- Marshall
Marshall Clow Via Boost wrote:
The master branch is now closed for all changes except by permission for the release.
Also, remember to add your libraries' changes to the release notes at: < https://github.com/boostorg/website/blob/master/feed/history/boost_1_70_0.qb... I have very recent documentation fix for Geometry: https://github.com/boostorg/geometry/pull/583 Nothing critical. I'm writing just in case you decided to release RC2 for some reason. This PR could be cherry-picked: https://github.com/boostorg/geometry/commit/8baddd3634cbd627be58b0bfd264d851... or I could merge it into master if you wanted me to do it.
Adam
On Thu, Apr 4, 2019 at 7:25 AM Marshall Clow via Boost
The master branch is now closed for all changes except by permission for the release.
A user reported a devastating bug which threatens undefined behavior in any scenario where the io_context has more than one thread, and the client code is not using a P1322R0-style strand (which will be all unmodified userbases, since the feature is new in 1.70). If at all possible, this fix needs to go in to rc2: https://github.com/boostorg/beast/commit/ce986118f81443ea8947f4bfa32ea740027... Apologies for the late update. Regards
participants (4)
-
Adam Wulkiewicz -
John Maddock -
Marshall Clow -
Vinnie Falco