Re: [boost] [review][fixed_string] FixedString review starts Nov 25
Also, a synopsis section in the documentation might have been nice, to allow one to see all the declarations in one place. (Admittedly, the main header does serve that purpose somewhat.)
I join the others in noting the pervasive lack of constexpr and noexcept. Even the default constructor isn't either. Can't think of a reason why it would throw. (The lack of constexpr is much easier to explain.) Also, Traits template parameters were wrong in C++98, and they remain wrong today, even though the committee has propagated that mistake into string_view.
On Thu, Nov 28, 2019 at 10:50 AM Peter Dimov via Boost < boost@lists.boost.org> wrote:
Also, a synopsis section in the documentation might have been nice, to allow one to see all the declarations in one place. (Admittedly, the main header does serve that purpose somewhat.)
I join the others in noting the pervasive lack of constexpr and noexcept. Even the default constructor isn't either. Can't think of a reason why it would throw. (The lack of constexpr is much easier to explain.)
Also, Traits template parameters were wrong in C++98, and they remain wrong today, even though the committee has propagated that mistake into string_view.
+all the number. Zach
participants (2)
-
Peter Dimov -
Zach Laine