Hi Michael, I see that internals.hpp declares the following: namespace boost { namespace detail { template <class Input, class BitSet> class bloom_filter_internals {...}; } } boost::detail should not be used for internals of a specific library. The custom is to do it like this: namespace boost{ namespace bloom_filters{ namespace detail{ // you might want to rename to just "internals" // as the qualified name is sufficiently informative template <class Input, class BitSet> class bloom_filter_internals {...}; } } } Note the "s" in "bloom_filters", following the naming guidelines at: http://www.boost.org/development/requirements.html#Naming_consistency Joaquín M López Muñoz Telefónica, Investigación y Desarrollo
Hi Joaquin, On Thu, Jun 11, 2009 at 1:16 AM, JOAQUIN M. LOPEZ MUÑOZ<joaquin@tid.es> wrote:
Hi Michael,
I see that internals.hpp declares the following:
[snip]
boost::detail should not be used for internals of a
specific library.
Right, I was thinking about this and I was thinking of moving it into its own namespace.
The custom is to do it like this:
namespace boost{
namespace bloom_filters{
namespace detail{
// you might want to rename to just "internals"
// as the qualified name is sufficiently informative
template <class Input, class BitSet> class bloom_filter_internals {...}; }
}
}
This makes sense. I'll get to this now.
Note the "s" in "bloom_filters", following the naming guidelines at:
http://www.boost.org/development/requirements.html#Naming_consistency
Right, let me get to this now. :-) Thanks for the nitpick! :-D -- Dean Michael Berris | Software Engineer, Friendster, Inc. blog.cplusplus-soup.com | twitter.com/mikhailberis | linkedin.com/in/mikhailberis | profiles.friendster.com/mikhailberis | deanberris.com
On Mon, Jun 15, 2009 at 4:22 PM, Dean Michael Berris<mikhailberis@gmail.com> wrote:
On Thu, Jun 11, 2009 at 1:16 AM, JOAQUIN M. LOPEZ MUÑOZ<joaquin@tid.es> wrote:
Note the "s" in "bloom_filters", following the naming guidelines at:
http://www.boost.org/development/requirements.html#Naming_consistency
Right, let me get to this now. :-)
And it's done as of Rev. 53928 of the Sandbox. I've also moved the implementations into its own namespace (bloom_filters) and just pulled in the names to the `boost` namespace via using directives. Thanks again, and I hope this helps! -- Dean Michael Berris | Software Engineer, Friendster, Inc. blog.cplusplus-soup.com | twitter.com/mikhailberis | linkedin.com/in/mikhailberis | profiles.friendster.com/mikhailberis | deanberris.com
participants (2)
-
Dean Michael Berris -
JOAQUIN M. LOPEZ MUÑOZ