[ptr_container] pull request: test values were swapped
On Thursday, April 24, 2014 12:29 AM, Ben Pope wrote:
Ping.
On 23-04-2014 18:29, Ben Pope wrote:
Hi, I haven't set up Git yet. Can somebody else merge it? kind regards -Thorsten
On 30 April 2014 15:37, Thorsten Ottosen <thorsten.ottosen@dezide.com> wrote:
On 23-04-2014 18:29, Ben Pope wrote:
Hi,
I haven't set up Git yet. Can somebody else merge it?
kind regards
-Thorsten
Done. I think you need to ask whoever sets up github teams to create a team for ptr_container. Or perhaps it could be added to the community management team.
On 30-04-2014 16:44, Daniel James wrote:
On 30 April 2014 15:37, Thorsten Ottosen <thorsten.ottosen@dezide.com> wrote:
On 23-04-2014 18:29, Ben Pope wrote:
Done. I think you need to ask whoever sets up github teams to create a team for ptr_container. Or perhaps it could be added to the community management team.
Good idea. -Thorsten
On 30 April 2014 16:34, Thorsten Ottosen <thorsten.ottosen@dezide.com> wrote:
On 30-04-2014 16:44, Daniel James wrote:
On 30 April 2014 15:37, Thorsten Ottosen <thorsten.ottosen@dezide.com> wrote:
On 23-04-2014 18:29, Ben Pope wrote:
Done. I think you need to ask whoever sets up github teams to create a team for ptr_container. Or perhaps it could be added to the community management team.
Good idea.
Which one?
On Wednesday, April 30, 2014 10:44 PM, Daniel James wrote:
On 23-04-2014 18:29, Ben Pope wrote:
Done. I think you need to ask whoever sets up github teams to create a team for ptr_container. Or perhaps it could be added to the community management team.
Thanks, I think this is good to be merged to master. Ben
On 22 May 2014 07:05, Ben Pope <benpope81@gmail.com> wrote:
On Wednesday, April 30, 2014 10:44 PM, Daniel James wrote:
On 23-04-2014 18:29, Ben Pope wrote:
Done. I think you need to ask whoever sets up github teams to create a team for ptr_container. Or perhaps it could be added to the community management team.
Thanks, I think this is good to be merged to master.
Thanks, master and develop are a bit out of sync so I cherry-picked it. I'll try to clean up some of the old changes. There are some old changes on develop which don't seem to be release-worthy (stateful clone_allocators and support for const elements) so I'll probably revert them on develop, and create a feature branch in case anyone wants to deal with them. I'll probably cherry-pick the other fixes from develop to master to get things up to date.
On 22-05-2014 10:20, Daniel James wrote:
On 22 May 2014 07:05, Ben Pope <benpope81@gmail.com> wrote:
On Wednesday, April 30, 2014 10:44 PM, Daniel James wrote:
On 23-04-2014 18:29, Ben Pope wrote:
Done. I think you need to ask whoever sets up github teams to create a team for ptr_container. Or perhaps it could be added to the community management team.
Thanks, I think this is good to be merged to master.
Thanks, master and develop are a bit out of sync so I cherry-picked it.
I'll try to clean up some of the old changes. There are some old changes on develop which don't seem to be release-worthy (stateful clone_allocators and support for const elements) so I'll probably revert them on develop, and create a feature branch in case anyone wants to deal with them. I'll probably cherry-pick the other fixes from develop to master to get things up to date.
I got request for both stateful allocators and suport for const elements. But I never got to ask for feedback on it. Support for const elements seems like a worthy extension IMO. -Thorsten
On 22 May 2014 11:59, Thorsten Ottosen <thorsten.ottosen@dezide.com> wrote:
On 22-05-2014 10:20, Daniel James wrote:
I'll try to clean up some of the old changes. There are some old changes on develop which don't seem to be release-worthy (stateful clone_allocators and support for const elements) so I'll probably revert them on develop, and create a feature branch in case anyone wants to deal with them. I'll probably cherry-pick the other fixes from develop to master to get things up to date.
I got request for both stateful allocators and suport for const elements. But I never got to ask for feedback on it. Support for const elements seems like a worthy extension IMO.
Is it something you can get ready for release? It makes life difficult having release and develop out of sync. If it's something that might be done in the future, then putting it on a feature branch would mean it could be merged in later. Git doesn't track cherry-picks so it's generally better to set up a merge based flow of changes. Btw. when I said 'release-worthy' I meant 'in a suitable condition for release', not whether it's worth doing. Sorry if that was ambiguous.
I created a pull requests for the old changes which I think should be cherry-picked: https://github.com/boostorg/ptr_container/pull/2
On Thursday, May 22, 2014 04:20 PM, Daniel James wrote:
On 22 May 2014 07:05, Ben Pope <benpope81@gmail.com> wrote:
On Wednesday, April 30, 2014 10:44 PM, Daniel James wrote:
On 23-04-2014 18:29, Ben Pope wrote:
Done. I think you need to ask whoever sets up github teams to create a team for ptr_container. Or perhaps it could be added to the community management team.
Thanks, I think this is good to be merged to master.
Thanks, master and develop are a bit out of sync so I cherry-picked it.
I'll try to clean up some of the old changes. There are some old changes on develop which don't seem to be release-worthy (stateful clone_allocators and support for const elements) so I'll probably revert them on develop, and create a feature branch in case anyone wants to deal with them. I'll probably cherry-pick the other fixes from develop to master to get things up to date.
That sounds like a good plan. Thanks for this. Ben
On Wednesday, April 30, 2014 10:37 PM, Thorsten Ottosen wrote:
On 23-04-2014 18:29, Ben Pope wrote:
Hi,
I haven't set up Git yet. Can somebody else merge it?
kind regards
-Thorsten
Thanks, Ben
participants (3)
-
Ben Pope -
Daniel James -
Thorsten Ottosen