[gil] Committing some code changes
Hi there, I'm in the process to add some non-invasive code changes for boost::gil. Since this is my first time to commit changes to boost I would like to make sure I'm doing it right. The changes would be added to the trunk. Is that the right place? I have done the obvious steps on my local machine. And besides adding comments when checking in my changes what other steps do I have to do? Thanks, Christian
AMDG Christian Henning wrote:
Hi there, I'm in the process to add some non-invasive code changes for boost::gil. Since this is my first time to commit changes to boost I would like to make sure I'm doing it right. The changes would be added to the trunk. Is that the right place?
Yes.
I have done the obvious steps on my local machine. And besides adding comments when checking in my changes what other steps do I have to do?
After you commit you should watch the regression tests at http://www.boost.org/development/tests/trunk/developer/summary.html once the tests have cycled you can merge to /branches/release as long as we aren't in the middle of a release. In Christ, Steven Watanabe
Thanks Steven, for your answer. I have committed the change and will wait for the regression test to finished. FWIW, there are no tests in gil that touches these changes since it's very low level. I know there is a release going on but how would I merge with the release branch? Thanks, Christian
AMDG Christian Henning wrote:
Thanks Steven, for your answer. I have committed the change and will wait for the regression test to finished. FWIW, there are no tests in gil that touches these changes since it's very low level.
It's okay as long as the tests use your changes indirectly.
I know there is a release going on but how would I merge with the release branch?
- check out a working copy of the release branch - svn merge the changes into the working copy - run the tests - commit In Christ, Steven Watanabe
participants (2)
-
Christian Henning -
Steven Watanabe