[1.53] program_options warning fix

May I merge the below fix to release branch? It was checked in July (so yeah, tests have cycles since then), but it seems I have failed to merge it until now. Index: boost/program_options/errors.hpp =================================================================== --- boost/program_options/errors.hpp (revision 79476) +++ boost/program_options/errors.hpp (revision 79477) @@ -250,7 +250,7 @@ } /** Does NOT set option name, because no option name makes sense */ - virtual void set_option_name(const std::string&option_name) {} + virtual void set_option_name(const std::string&) {} ~error_with_no_option_name() throw() {} }; -- Vladimir Prus CodeSourcery / Mentor Graphics http://www.mentor.com/embedded-software/

On Jan 19, 2013, at 3:41 AM, Vladimir Prus <vladimir@codesourcery.com> wrote:
May I merge the below fix to release branch? It was checked in July (so yeah, tests have cycles since then), but it seems I have failed to merge it until now.
Index: boost/program_options/errors.hpp =================================================================== --- boost/program_options/errors.hpp (revision 79476) +++ boost/program_options/errors.hpp (revision 79477) @@ -250,7 +250,7 @@ }
/** Does NOT set option name, because no option name makes sense */ - virtual void set_option_name(const std::string&option_name) {} + virtual void set_option_name(const std::string&) {}
~error_with_no_option_name() throw() {} };
Go ahead. -- Marshall Marshall Clow Idio Software <mailto:mclow.lists@gmail.com> A.D. 1517: Martin Luther nails his 95 Theses to the church door and is promptly moderated down to (-1, Flamebait). -- Yu Suzuki

On 19.01.2013 19:47, Marshall Clow wrote:
On Jan 19, 2013, at 3:41 AM, Vladimir Prus <vladimir@codesourcery.com> wrote:
May I merge the below fix to release branch? It was checked in July (so yeah, tests have cycles since then), but it seems I have failed to merge it until now.
Index: boost/program_options/errors.hpp =================================================================== --- boost/program_options/errors.hpp (revision 79476) +++ boost/program_options/errors.hpp (revision 79477) @@ -250,7 +250,7 @@ }
/** Does NOT set option name, because no option name makes sense */ - virtual void set_option_name(const std::string&option_name) {} + virtual void set_option_name(const std::string&) {}
~error_with_no_option_name() throw() {} };
Go ahead.
Thanks, done.
participants (3)
-
Marshall Clow
-
Vladimir Prus
-
Vladimir Prus