[locale] Formal review of Boost.Local library -- need reviews!
The final day of the Boost.Locale formal review is scheduled to be Saturday, and though there has been a lot of discussion, so far only one complete review has been submitted. If you're planning to review it, please don't delay. Writing a review ================ If you feel this is an interesting library, then please submit your review to the developer list (preferably), or to the review manager (me). Here are some questions you might want to answer in your review: - What is your evaluation of the design? - What is your evaluation of the implementation? - What is your evaluation of the documentation? - What is your evaluation of the potential usefulness of the library? - Did you try to use the library? With what compiler? Did you have any problems? - How much effort did you put into your evaluation? A glance? A quick reading? In-depth study? - Are you knowledgeable about the problem domain? And finally, every review should answer this question: - Do you think the library should be accepted as a Boost library? Be sure to say this explicitly so that your other comments don't obscure your overall opinion. -- Chad Nelson Oak Circle Software, Inc. * * *
hopefully I will find the time ... Anyway, how does it play with Qt and wxwindows e.g.? I can't find about this on the docs. Thanks, Olaf
I'm writing a review too but I will certainly not be able to experience real use of the library until Saturday. Joël Lamotte.
Anyway, how does it play with Qt and wxwindows e.g.? I can't find about
this on the docs.
I'm not too familiar with wxWdgets, but in all related to Qt I must admit that Qt does not plays well (if at all) with standard C++ library and STL. It has its own string (QString) its own character (QChar - two bytes) its own locale object (QLocale) and its own tools for localization. Of course nothing prevents from you using Boost.Locale with Qt however it would be bounded and limited by the integration of Qt with STL. For example you would likely want to use things like QString s=QString::fromStdString((format(translate("The time is {1,time}")) % time).str()); However I can say that in case of Gtkmm it would be likely better as it is much more STL friendly in comparison to Qt. Boost.Locale works with standard library concepts so its integration with other frameworks strictly depends on their integration with STL. Artyom
Am 14.04.2011 16:42, schrieb Artyom:
Anyway, how does it play with Qt and wxwindows e.g.? I can't find about
this on the docs.
I'm not too familiar with wxWdgets, but in all related to Qt I must admit that Qt does not plays well (if at all) with standard C++ library and STL.
It has its own string (QString) its own character (QChar - two bytes) its own locale object (QLocale) and its own tools for localization.
Of course nothing prevents from you using Boost.Locale with Qt however it would be bounded and limited by the integration of Qt with STL.
For example you would likely want to use things like
QString s=QString::fromStdString((format(translate("The time is {1,time}")) % time).str());
However I can say that in case of Gtkmm it would be likely better as it is much more STL friendly in comparison to Qt.
Qt has it's own macro/function QObject::tr(), see http://doc.qt.nokia.com/latest/i18n-source-translation.html, which is normally used for. How do you see to get it to play with boost.locale? boost.locale is very good for localizing console/logging programs imo, but as I can see it doesn't play well with Qt, the above convert isn't applicable for 'layered' designs (independent core libs on bottom, Qt on UI). Regards, Olaf
On 4/14/2011 7:42 AM, Artyom wrote:
Anyway, how does it play with Qt and wxwindows e.g.? I can't find about
this on the docs.
I'm not too familiar with wxWdgets, but in all related to Qt I must admit that Qt does not plays well (if at all) with standard C++ library and STL.
It has its own string (QString) its own character (QChar - two bytes) its own locale object (QLocale) and its own tools for localization.
Of course nothing prevents from you using Boost.Locale with Qt however it would be bounded and limited by the integration of Qt with STL.
For example you would likely want to use things like
QString s=QString::fromStdString((format(translate("The time is {1,time}")) % time).str());
I've gotten around this issue, and similar issues with other libraries, by having a "string_cast<>()" function. I now what I need the string to be to pass off to whatever API but I don't have to care what kind of string it is to begin with. I've found it quite convenient.
On 14.04.2011, at 07:51, Chad Nelson wrote:
The final day of the Boost.Locale formal review is scheduled to be Saturday, and though there has been a lot of discussion, so far only one complete review has been submitted. If you're planning to review it, please don't delay.
Writing a review ================
If you feel this is an interesting library, then please submit your review to the developer list (preferably), or to the review manager (me).
Here are some questions you might want to answer in your review:
- What is your evaluation of the design?
I think basing the design on std::locale but replacing the broken facets is a very good design. There seem to be quite a few things that are tightly bound to iostreams, which I find less ideal, but I might be mistaken about this.
- What is your evaluation of the implementation?
Did not look. But basing it on ICU seems the right decision.
- What is your evaluation of the documentation?
Next/prev links are a must, and the docs could benefit from a native speaker reading over them, but all in all I found them to be good in that they quickly introduce what the library can do and how to do it. There are some complaints, but all of them have been mentioned by previous reviewers.
- What is your evaluation of the potential usefulness of the library?
Very big. Localization in standard C++ is broken beyond usability.
- Did you try to use the library? With what compiler? Did you have any problems?
Did not try.
- How much effort did you put into your evaluation? A glance? A quick reading? In-depth study?
I read the documentation.
- Are you knowledgeable about the problem domain?
As a German native speaker, I have some experience with the basic problems of localization, like case conversion of ß. I also know some Japanese and know a bit about the bigger problems that occur with such a truly non-English language.
And finally, every review should answer this question:
- Do you think the library should be accepted as a Boost library?
Yes. Sebastian
On 14/04/2011 07:51, Chad Nelson wrote:
The final day of the Boost.Locale formal review is scheduled to be Saturday, and though there has been a lot of discussion, so far only one complete review has been submitted. If you're planning to review it, please don't delay.
I would like to submit a review, but I am very busy this week and unfortunately may not have the time to before the deadline.
On Fri, Apr 15, 2011 at 11:15, Mathias Gaunard <mathias.gaunard@ens-lyon.org
wrote:
I would like to submit a review, but I am very busy this week and unfortunately may not have the time to before the deadline.
Like Mathias, I will not have enough time to finish my review properly on Saturday. Could the deadline be moved to the next week? Joël Lamotte
2011/4/15 Klaim - Joël Lamotte <mjklaim@gmail.com>:
On Fri, Apr 15, 2011 at 11:15, Mathias Gaunard <mathias.gaunard@ens-lyon.org
wrote:
I would like to submit a review, but I am very busy this week and unfortunately may not have the time to before the deadline.
Like Mathias, I will not have enough time to finish my review properly on Saturday. Could the deadline be moved to the next week?
+1. I was quite busy this week and I would like to try the library with MSVC under windows, before I write a review, which I'll not be able to do before next Tuesday. So I would like to ask the review manager to kindly extend the deadline. Matus
On Fri, 15 Apr 2011 19:55:54 +0200 Klaim - Joël Lamotte <mjklaim@gmail.com> wrote:
I would like to submit a review, but I am very busy this week and unfortunately may not have the time to before the deadline.
Like Mathias, I will not have enough time to finish my review properly on Saturday. Could the deadline be moved to the next week?
Yes. Official extension announcement coming up. -- Chad Nelson Oak Circle Software, Inc. * * *
participants (8)
-
Artyom -
Chad Nelson -
Klaim - Joël Lamotte -
Mathias Gaunard -
Matus Chochlik -
Noah Roberts -
Olaf Peter -
Sebastian Redl