[boost] inspect tool updated, violations of min/max guidelines found
I just updated the Inspect tool to find violations of Boost's min/max guidelines (which you can find at http://boost.org/more/lib_guide.htm#Guidelines). I just ran the tool with the new -minmax switch to find all the violations in CVS-current. I've attached the report. Some of these are false positives -- violations in comments -- but most look legit. Below is the summary: Library Problems -----------------+---------- algorithm 2 archive 2 config 2 conversion 2 date_time 4 detail 1 graph 20 iostreams 16 multi_index 2 numeric 24 program_options 4 regex 14 serialization 1 spirit 6 -- Eric Niebler Boost Consulting www.boost-consulting.com /G53G29: Permission denied
Whoops, guess that HTML file didn't make it. Trying again as a text file. Eric Niebler wrote:
I just updated the Inspect tool to find violations of Boost's min/max guidelines (which you can find at http://boost.org/more/lib_guide.htm#Guidelines). I just ran the tool with the new -minmax switch to find all the violations in CVS-current. I've attached the report. Some of these are false positives -- violations in comments -- but most look legit. Below is the summary:
Library Problems -----------------+---------- algorithm 2 archive 2 config 2 conversion 2 date_time 4 detail 1 graph 20 iostreams 16 multi_index 2 numeric 24 program_options 4 regex 14 serialization 1 spirit 6
------------------------------------------------------------------------
/G53G29: Permission denied
------------------------------------------------------------------------
<html> <head> <title>Boost Inspection Report</title> </head> <body bgcolor="#ffffff" text="#000000"> <table border="0"> <tr> <td><img border="0" src="../boost.png" width="277" height="86"></td> <td align="center"> <h1>Boost Inspection Report</h1> <b>Run Date:</b> 18:49:23 UTC, Tuesday 08 February 2005 </td> </table> <p>An <a href="http://www.boost.org/tools/inspect/index.html">inspection program</a> checks each file in the current Boost CVS for various problems, generating this web page as output. Problems detected include tabs in files, missing copyrights, broken URL's, and similar misdemeanors.</p> <h2>Totals</h2> <pre>9761 files scanned 773 directories scanned 100 problems reported problem counts: 100 violations of the Boost min/max guidelines </pre> <h2>Summary</h2> <table border="1" cellpadding="5" cellspacing="0"> <tr> <td><b>Library</b></td> <td><b>Problems</b></td> </tr> <tr><td><a href="#algorithm">algorithm</a></td><td align="center">2</td></tr> <tr><td><a href="#archive">archive</a></td><td align="center">2</td></tr> <tr><td><a href="#config">config</a></td><td align="center">2</td></tr> <tr><td><a href="#conversion">conversion</a></td><td align="center">2</td></tr> <tr><td><a href="#date_time">date_time</a></td><td align="center">4</td></tr> <tr><td><a href="#detail">detail</a></td><td align="center">1</td></tr> <tr><td><a href="#graph">graph</a></td><td align="center">20</td></tr> <tr><td><a href="#iostreams">iostreams</a></td><td align="center">16</td></tr> <tr><td><a href="#multi_index">multi_index</a></td><td align="center">2</td></tr> <tr><td><a href="#numeric">numeric</a></td><td align="center">24</td></tr> <tr><td><a href="#program_options">program_options</a></td><td align="center">4</td></tr> <tr><td><a href="#regex">regex</a></td><td align="center">14</td></tr> <tr><td><a href="#serialization">serialization</a></td><td align="center">1</td></tr> <tr><td><a href="#spirit">spirit</a></td><td align="center">6</td></tr> </table> <h2>Details</h2> <h3><a name="algorithm">algorithm</a></h3> <pre> libs/algorithm/string/example/rle_example.cpp: violation of Boost min/max guidelines on line 27, violation of Boost min/max guidelines on line 62</pre> <h3><a name="archive">archive</a></h3> <pre> boost/archive/impl/basic_text_iprimitive.ipp: violation of Boost min/max guidelines on line 52 boost/archive/iterators/transform_width.hpp: violation of Boost min/max guidelines on line 145</pre> <h3><a name="config">config</a></h3> <pre> libs/config/test/boost_no_std_min_max.ipp: violation of Boost min/max guidelines on line 11</pre> <h3><a name="conversion">conversion</a></h3> <pre> boost/cast.hpp: violation of Boost min/max guidelines on line 204, violation of Boost min/max guidelines on line 237</pre> <h3><a name="date_time">date_time</a></h3> <pre> boost/date_time/date_parsing.hpp: violation of Boost min/max guidelines on line 80, violation of Boost min/max guidelines on line 81 boost/date_time/period.hpp: violation of Boost min/max guidelines on line 339, violation of Boost min/max guidelines on line 340</pre> <h3><a name="detail">detail</a></h3> <pre> libs/detail/utf8_codecvt_facet.cpp: violation of Boost min/max guidelines on line 126</pre> <h3><a name="graph">graph</a></h3> <pre> boost/graph/astar_search.hpp: violation of Boost min/max guidelines on line 325 boost/graph/bellman_ford_shortest_paths.hpp: violation of Boost min/max guidelines on line 171 boost/graph/betweenness_centrality.hpp: violation of Boost min/max guidelines on line 586 boost/graph/connected_components.hpp: violation of Boost min/max guidelines on line 106, violation of Boost min/max guidelines on line 87 boost/graph/fruchterman_reingold.hpp: violation of Boost min/max guidelines on line 164, violation of Boost min/max guidelines on line 165, violation of Boost min/max guidelines on line 166, violation of Boost min/max guidelines on line 167, violation of Boost min/max guidelines on line 278, violation of Boost min/max guidelines on line 279, violation of Boost min/max guidelines on line 280, violation of Boost min/max guidelines on line 281 boost/graph/kamada_kawai_spring_layout.hpp: violation of Boost min/max guidelines on line 171, violation of Boost min/max guidelines on line 310, violation of Boost min/max guidelines on line 311, violation of Boost min/max guidelines on line 321, violation of Boost min/max guidelines on line 332</pre> <h3><a name="iostreams">iostreams</a></h3> <pre> boost/iostreams/code_converter.hpp: violation of Boost min/max guidelines on line 125 boost/iostreams/detail/adapter/direct_adapter.hpp: violation of Boost min/max guidelines on line 189, violation of Boost min/max guidelines on line 203 boost/iostreams/detail/adapter/random_access_container_adapter.hpp: violation of Boost min/max guidelines on line 100, violation of Boost min/max guidelines on line 116 boost/iostreams/detail/adapter/range_adapter.hpp: violation of Boost min/max guidelines on line 123, violation of Boost min/max guidelines on line 135 boost/iostreams/detail/codecvt_helper.hpp: violation of Boost min/max guidelines on line 183 boost/iostreams/detail/streambuf/indirect_streambuf.hpp: violation of Boost min/max guidelines on line 158, violation of Boost min/max guidelines on line 219, violation of Boost min/max guidelines on line 247, violation of Boost min/max guidelines on line 260, violation of Boost min/max guidelines on line 261 boost/iostreams/filter/gzip.hpp: violation of Boost min/max guidelines on line 250 boost/iostreams/filter/one_step_filter.hpp: violation of Boost min/max guidelines on line 59 libs/iostreams/test/detail/utf8_codecvt_facet.cpp: violation of Boost min/max guidelines on line 135</pre> <h3><a name="multi_index">multi_index</a></h3> <pre> boost/multi_index/composite_key.hpp: violation of Boost min/max guidelines on line 168, violation of Boost min/max guidelines on line 174</pre> <h3><a name="numeric">numeric</a></h3> <pre> boost/numeric/ublas/banded.hpp: violation of Boost min/max guidelines on line 79 boost/numeric/ublas/vector_expression.hpp: violation of Boost min/max guidelines on line 1758, violation of Boost min/max guidelines on line 1759, violation of Boost min/max guidelines on line 1768 libs/numeric/ublas/doc/samples/banded_adaptor.cpp: violation of Boost min/max guidelines on line 25 libs/numeric/ublas/doc/samples/banded_matrix.cpp: violation of Boost min/max guidelines on line 24 libs/numeric/ublas/doc/samples/matrix_binary.cpp: violation of Boost min/max guidelines on line 23, violation of Boost min/max guidelines on line 24 libs/numeric/ublas/doc/samples/matrix_matrix_binary.cpp: violation of Boost min/max guidelines on line 23, violation of Boost min/max guidelines on line 24 libs/numeric/ublas/doc/samples/matrix_matrix_solve.cpp: violation of Boost min/max guidelines on line 23 libs/numeric/ublas/doc/samples/matrix_vector_binary.cpp: violation of Boost min/max guidelines on line 24 libs/numeric/ublas/doc/samples/matrix_vector_solve.cpp: violation of Boost min/max guidelines on line 24 libs/numeric/ublas/doc/samples/vector_binary.cpp: violation of Boost min/max guidelines on line 23 libs/numeric/ublas/doc/samples/vector_binary_outer.cpp: violation of Boost min/max guidelines on line 23 libs/numeric/ublas/doc/samples/vector_binary_redux.cpp: violation of Boost min/max guidelines on line 22 libs/numeric/ublas/test4/test4.hpp: violation of Boost min/max guidelines on line 46, violation of Boost min/max guidelines on line 49</pre> <h3><a name="program_options">program_options</a></h3> <pre> boost/program_options/positional_options.hpp: violation of Boost min/max guidelines on line 43 libs/program_options/src/options_description.cpp: violation of Boost min/max guidelines on line 497 libs/program_options/src/positional_options.cpp: violation of Boost min/max guidelines on line 37 libs/program_options/test/positional_options_test.cpp: violation of Boost min/max guidelines on line 37</pre> <h3><a name="regex">regex</a></h3> <pre> boost/regex/v4/primary_transform.hpp: violation of Boost min/max guidelines on line 105 libs/regex/performance/regex_comparison.hpp: violation of Boost min/max guidelines on line 69 libs/regex/performance/time_boost.cpp: violation of Boost min/max guidelines on line 48, violation of Boost min/max guidelines on line 89 libs/regex/performance/time_greta.cpp: violation of Boost min/max guidelines on line 51, violation of Boost min/max guidelines on line 97 libs/regex/performance/time_localised_boost.cpp: violation of Boost min/max guidelines on line 48, violation of Boost min/max guidelines on line 89 libs/regex/performance/time_pcre.cpp: violation of Boost min/max guidelines on line 155, violation of Boost min/max guidelines on line 72 libs/regex/performance/time_posix.cpp: violation of Boost min/max guidelines on line 119, violation of Boost min/max guidelines on line 53 libs/regex/performance/time_safe_greta.cpp: violation of Boost min/max guidelines on line 52, violation of Boost min/max guidelines on line 99</pre> <h3><a name="serialization">serialization</a></h3> <pre> libs/serialization/src/utf8_codecvt_facet.cpp: violation of Boost min/max guidelines on line 121</pre> <h3><a name="spirit">spirit</a></h3> <pre> libs/spirit/test/escape_char_parser_tests.cpp: violation of Boost min/max guidelines on line 164, violation of Boost min/max guidelines on line 167, violation of Boost min/max guidelines on line 170, violation of Boost min/max guidelines on line 178, violation of Boost min/max guidelines on line 180, violation of Boost min/max guidelines on line 183</pre> </body> </html>
participants (1)
-
Eric Niebler