Hi, There is a problem with Boost.Thread on windows, when BOOST_THREAD_USES_CHRONO macro is defined. In win32/basic_timed_mutex.hpp there are references to Boost.Chrono not guarded with this macro, which results in compile errors. Could this be fixed before the 1.51 release? I can apply the change, if permission is granted.
On Wednesday 25 July 2012 17:24:11 you wrote:
Hi,
There is a problem with Boost.Thread on windows, when BOOST_THREAD_USES_CHRONO macro is defined. In win32/basic_timed_mutex.hpp there are references to Boost.Chrono not guarded with this macro, which results in compile errors. Could this be fixed before the 1.51 release? I can apply the change, if permission is granted.
Sorry, I meant BOOST_THREAD_DONT_USE_CHRONO macro, of course.
On Wednesday 25 July 2012 17:26:51 you wrote:
On Wednesday 25 July 2012 17:24:11 you wrote:
Hi,
There is a problem with Boost.Thread on windows, when BOOST_THREAD_USES_CHRONO macro is defined. In win32/basic_timed_mutex.hpp there are references to Boost.Chrono not guarded with this macro, which results in compile errors. Could this be fixed before the 1.51 release? I can apply the change, if permission is granted.
Sorry, I meant BOOST_THREAD_DONT_USE_CHRONO macro, of course.
I've applied the change to trunk: https://svn.boost.org/trac/boost/changeset/79753 I tested compilation locally. Also several test platforms (including one Windows) have cycled with this change with no errors. May I merge it to release?
On 7/26/2012 10:50 PM, Andrey Semashev wrote:
On Wednesday 25 July 2012 17:26:51 you wrote:
On Wednesday 25 July 2012 17:24:11 you wrote:
Hi,
There is a problem with Boost.Thread on windows, when BOOST_THREAD_USES_CHRONO macro is defined. In win32/basic_timed_mutex.hpp there are references to Boost.Chrono not guarded with this macro, which results in compile errors. Could this be fixed before the 1.51 release? I can apply the change, if permission is granted.
Sorry, I meant BOOST_THREAD_DONT_USE_CHRONO macro, of course.
I've applied the change to trunk:
https://svn.boost.org/trac/boost/changeset/79753
I tested compilation locally. Also several test platforms (including one Windows) have cycled with this change with no errors. May I merge it to release?
It's less than 24 hours since this change was made on trunk. We haven't even released a beta of 1.51 yet, so there's time. Let's wait for more testers to cycle. If everything looks good in a few days, then go ahead. -- Eric Niebler BoostPro Computing http://www.boostpro.com
On Thursday 26 July 2012 23:05:37 Eric Niebler wrote:
On 7/26/2012 10:50 PM, Andrey Semashev wrote:
I've applied the change to trunk: https://svn.boost.org/trac/boost/changeset/79753
I tested compilation locally. Also several test platforms (including one Windows) have cycled with this change with no errors. May I merge it to release?
It's less than 24 hours since this change was made on trunk. We haven't even released a beta of 1.51 yet, so there's time. Let's wait for more testers to cycle. If everything looks good in a few days, then go ahead.
Most testers have cycled now, no problems revealed. I've merged changes to release in rev. 79794. Thank you.
On 7/29/2012 1:54 AM, Andrey Semashev wrote:
On Thursday 26 July 2012 23:05:37 Eric Niebler wrote:
On 7/26/2012 10:50 PM, Andrey Semashev wrote:
I've applied the change to trunk: https://svn.boost.org/trac/boost/changeset/79753
I tested compilation locally. Also several test platforms (including one Windows) have cycled with this change with no errors. May I merge it to release?
It's less than 24 hours since this change was made on trunk. We haven't even released a beta of 1.51 yet, so there's time. Let's wait for more testers to cycle. If everything looks good in a few days, then go ahead.
Most testers have cycled now, no problems revealed. I've merged changes to release in rev. 79794. Thank you.
Thanks, Andrey. -- Eric Niebler BoostPro Computing http://www.boostpro.com
participants (2)
-
Andrey Semashev -
Eric Niebler