[signals2] missing Jamfile and compile errors with VC8
I was surprised to not find a Jamfile in the libs/signals2/example directory. Please find an example below. The reason I headed toward the examples is that I'm having trouble with this type of line and VC8: typedef boost::signals2::signal<void ()> signal_t; In fact doc_view_acm.cpp will not compile because of it. disconnect_and_block.cpp also has compilation errors. Results verified in 1.41 and 1.42 with VC8 and gcc 4.3.2 --------------------------------------------------------- # Boost.Signals2 Library project : requirements <source>/boost//headers ; exe hello_world_slot : hello_world_slot.cpp ; exe hello_world_multi_slot : hello_world_multi_slot.cpp ; exe ordering_slots : ordering_slots.cpp ; exe passing_slots : passing_slots.cpp ; exe extended_slot : extended_slot.cpp ; exe custom_combiners : custom_combiners.cpp ; exe disconnect_and_block : disconnect_and_block.cpp ; exe doc_view : doc_view.cpp ; exe doc_view_acm : doc_view_acm.cpp ; exe doc_view_acm_deconstruct : doc_view_acm_deconstruct.cpp ; exe postconstructor_ex1 : postconstructor_ex1.cpp ; exe postconstructor_ex2 : postconstructor_ex2.cpp ; exe predestructor_example : predestructor_example.cpp ; exe signal_return_value : signal_return_value.cpp ; exe slot_arguments : slot_arguments.cpp ; --------------------------------------------------------------- -- ---------------------------------- Michael Caisse Object Modeling Designs www.objectmodelingdesigns.com
The errors in the examples are actual errors. See diff against trunk below for fixes. Also, I think signals2/signal.hpp should also include shared_connection_block.hpp. regards - michael Index: example/doc_view_acm.cpp =================================================================== --- example/doc_view_acm.cpp (revision 60405) +++ example/doc_view_acm.cpp (working copy) @@ -23,7 +23,7 @@ typedef boost::signals2::signal<void ()> signal_t; public: - document() + Document() {} /* connect a slot to the signal which will be emitted whenever @@ -39,7 +39,7 @@ m_sig(); } - const std::string& gettext() const + const std::string& getText() const { return m_text; } Index: example/disconnect_and_block.cpp =================================================================== --- example/disconnect_and_block.cpp (revision 60405) +++ example/disconnect_and_block.cpp (working copy) @@ -10,6 +10,7 @@ #include <iostream> #include <boost/signals2/signal.hpp> +#include <boost/signals2/shared_connection_block.hpp> struct HelloWorld { -- ---------------------------------- Michael Caisse Object Modeling Designs www.objectmodelingdesigns.com
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Tuesday 09 March 2010, Michael Caisse wrote:
The errors in the examples are actual errors. See diff against trunk below for fixes.
Thanks, I've committed your patches and Jamfile to trunk. I used to compile the examples at some point, it must have been back before the lib was accepted and I was still using make.
Also, I think signals2/signal.hpp should also include shared_connection_block.hpp.
Why? Are you confusing boost/signals2.hpp with boost/signals2/signal.hpp? -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAkuXpgsACgkQ5vihyNWuA4UWpACguwoobOrqG35ejM2fjYwdGG3C Cw0An140ujxdtjp72O+ZuzPp+Q7iBzmm =+Qvy -----END PGP SIGNATURE-----
Frank Mori Hess wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On Tuesday 09 March 2010, Michael Caisse wrote:
Also, I think signals2/signal.hpp should also include shared_connection_block.hpp.
Why? Are you confusing boost/signals2.hpp with boost/signals2/signal.hpp?
Wow. Must have been a bad night for me. I did confuse the two. Sorry for the noise. michael -- ---------------------------------- Michael Caisse Object Modeling Designs www.objectmodelingdesigns.com
participants (2)
-
Frank Mori Hess -
Michael Caisse