[spirit.phoenix] Phoenix test coverage
From names in the spirit regression test matrix <http://www.boost.org/development/tests/release/developer/spirit.html>, I see these four with phoenix in the name: dedent_handling_phoenix, lex_dedent_handling_phoenix, lex_set_token_value_phoenix, set_token_value_phoenix.
When I search for phoenix in all libs/spirit/test code, I see references in 104 files, so tests span more than just above four. But how well do phoenix's tests span its content? Is this documented somewhere? Thanks in Advance, -Jim
From names in the spirit regression test matrix <http://www.boost.org/development/tests/release/developer/spirit.html>, I see these four with phoenix in the name: dedent_handling_phoenix, lex_dedent_handling_phoenix, lex_set_token_value_phoenix, set_token_value_phoenix.
When I search for phoenix in all libs/spirit/test code, I see references in 104 files, so tests span more than just above four.
But how well do phoenix's tests span its content? Is this documented somewhere?
Tests for Phoenix V2 are not run at all, IIUC. This will change only when/if Phoenix V3 has been moved to trunk after its mini-review. The tests you're referring to are Spirit specific tests using Phoenix features. Regards Hartmut --------------- http://boost-spirit.com
On 1:59 PM, Hartmut Kaiser wrote:
But how well do phoenix's tests span its content? Is this documented somewhere? Tests for Phoenix V2 are not run at all, IIUC. This will change only when/if Phoenix V3 has been moved to trunk after its mini-review. The tests you're referring to are Spirit specific tests using Phoenix features.
Thanks for the info. So tests exist for Phoenix v3 but they, like v3, aren't yet in the trunk? Will Phoenix remain a part of Spirit, or get its own place in boost's library list and regression matrix? Where do I find a sneak-peek at v3? (Particularly the docs.) I'm not finding it on boost-spirit.com or in <https://svn.boost.org/trac/boost/wiki/LibrariesUnderConstruction>. Thanks, -Jim
Jim Bell wrote:
Where do I find a sneak-peek at v3? (Particularly the docs.) I'm not finding it on boost-spirit.com or in <https://svn.boost.org/trac/boost/wiki/LibrariesUnderConstruction>.
When I started this page Boost.Phoenix was already conditionally accepted, so I didn't added it. I would add it to the Review Schedule wiki page this evening. You can find the needed links here http://www.boost.org/community/review_schedule.html Best, Vicente -- View this message in context: http://boost.2283326.n4.nabble.com/spirit-phoenix-Phoenix-test-coverage-tp32... Sent from the Boost - Dev mailing list archive at Nabble.com.
Jim Bell wrote:
On 1:59 PM, Hartmut Kaiser wrote:
But how well do phoenix's tests span its content? Is this documented somewhere? Tests for Phoenix V2 are not run at all, IIUC. This will change only when/if Phoenix V3 has been moved to trunk after its mini-review. The tests you're referring to are Spirit specific tests using Phoenix features.
Thanks for the info. So tests exist for Phoenix v3 but they, like v3, aren't yet in the trunk?
Will Phoenix remain a part of Spirit, or get its own place in boost's library list and regression matrix?
Where do I find a sneak-peek at v3? (Particularly the docs.)
For the code: https://svn.boost.org/svn/boost/sandbox/SOC/2010/phoenix3/ For the docs: https://svn.boost.org/svn/boost/sandbox/SOC/2010/phoenix3/libs/phoenix/doc/h... The docs are not completely done yet.
I'm not finding it on boost-spirit.com or in <https://svn.boost.org/trac/boost/wiki/LibrariesUnderConstruction>.
Thanks, -Jim _______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
On 1:59 PM, Hartmut Kaiser wrote:
From names in the spirit regression test matrix <http://www.boost.org/development/tests/release/developer/spirit.html>, I see these four with phoenix in the name: dedent_handling_phoenix, lex_dedent_handling_phoenix, lex_set_token_value_phoenix, set_token_value_phoenix.
When I search for phoenix in all libs/spirit/test code, I see references in 104 files, so tests span more than just above four.
But how well do phoenix's tests span its content? Is this documented somewhere? Tests for Phoenix V2 are not run at all, IIUC. This will change only when/if Phoenix V3 has been moved to trunk after its mini-review. The tests you're referring to are Spirit specific tests using Phoenix features.
Looking at what's already released, libs/spirit/phoenix/test, I see what looks like a full suite of tests, and when I run bjam on them I get 45 tests passed (on MinGW gcc-4.4/win-32) and one failure. So the full compliment of tests is there and likely known to work on a couple platforms, just not run by the regression mechanism. Thomas and Vincente -- thanks for the v3 input, too. For the record, here's the failure (MinGW gcc-4.4/win-32): ====== BEGIN OUTPUT ====== Direct Init -1, 3.14 Abracadabra 987, 9.87e+032 scope\dynamic_tests.cpp(68): test 'clos.real() == clos.num() * 1e30' failed in function 'int main()' Hello World 579, 10.2478 scope\dynamic_tests.cpp(74): test 'clos.real() == clos.num() / 56.5' failed in function 'int main()' Assertion failed: called_report_errors_function, file ..\..\..\../boost/detail/lightweight_test.hpp, line 42 This application has requested the Runtime to terminate it in an unusual way. Please contact the application's support team for more information. EXIT STATUS: 3 ====== END OUTPUT ======
Jim Bell wrote:
On 1:59 PM, Hartmut Kaiser wrote:
From names in the spirit regression test matrix <http://www.boost.org/development/tests/release/developer/spirit.html>, I see these four with phoenix in the name: dedent_handling_phoenix, lex_dedent_handling_phoenix, lex_set_token_value_phoenix, set_token_value_phoenix.
When I search for phoenix in all libs/spirit/test code, I see references in 104 files, so tests span more than just above four.
But how well do phoenix's tests span its content? Is this documented somewhere? Tests for Phoenix V2 are not run at all, IIUC. This will change only when/if Phoenix V3 has been moved to trunk after its mini-review. The tests you're referring to are Spirit specific tests using Phoenix features.
Looking at what's already released, libs/spirit/phoenix/test, I see what looks like a full suite of tests, and when I run bjam on them I get 45 tests passed (on MinGW gcc-4.4/win-32) and one failure.
So the full compliment of tests is there and likely known to work on a couple platforms, just not run by the regression mechanism.
Thomas and Vincente -- thanks for the v3 input, too.
For the record, here's the failure (MinGW gcc-4.4/win-32): ====== BEGIN OUTPUT ====== Direct Init -1, 3.14 Abracadabra 987, 9.87e+032 scope\dynamic_tests.cpp(68): test 'clos.real() == clos.num() * 1e30' failed in function 'int main()' Hello World 579, 10.2478 scope\dynamic_tests.cpp(74): test 'clos.real() == clos.num() / 56.5' failed in function 'int main()' Assertion failed: called_report_errors_function, file ..\..\..\../boost/detail/lightweight_test.hpp, line 42
This application has requested the Runtime to terminate it in an unusual way. Please contact the application's support team for more information.
EXIT STATUS: 3 ====== END OUTPUT ======
We know about this bug and it is quite embarrassing ... It is actually a bug in the testcase itself :) I will take care of it ASAP.
On 1:59 PM, Hartmut Kaiser wrote:
From names in the spirit regression test matrix <http://www.boost.org/development/tests/release/developer/spirit.htm l>, I see these four with phoenix in the name: dedent_handling_phoenix, lex_dedent_handling_phoenix, lex_set_token_value_phoenix, set_token_value_phoenix.
When I search for phoenix in all libs/spirit/test code, I see references in 104 files, so tests span more than just above four.
But how well do phoenix's tests span its content? Is this documented somewhere? Tests for Phoenix V2 are not run at all, IIUC. This will change only when/if Phoenix V3 has been moved to trunk after its mini-review. The tests you're referring to are Spirit specific tests using Phoenix features.
Looking at what's already released, libs/spirit/phoenix/test, I see what looks like a full suite of tests, and when I run bjam on them I get 45 tests passed (on MinGW gcc-4.4/win-32) and one failure.
So the full compliment of tests is there and likely known to work on a couple platforms, just not run by the regression mechanism.
Thomas and Vincente -- thanks for the v3 input, too.
For the record, here's the failure (MinGW gcc-4.4/win-32): ====== BEGIN OUTPUT ====== Direct Init -1, 3.14 Abracadabra 987, 9.87e+032 scope\dynamic_tests.cpp(68): test 'clos.real() == clos.num() * 1e30' failed in function 'int main()' Hello World 579, 10.2478 scope\dynamic_tests.cpp(74): test 'clos.real() == clos.num() / 56.5' failed in function 'int main()' Assertion failed: called_report_errors_function, file ..\..\..\../boost/detail/lightweight_test.hpp, line 42
This application has requested the Runtime to terminate it in an unusual way. Please contact the application's support team for more information.
EXIT STATUS: 3 ====== END OUTPUT ======
We know about this bug and it is quite embarrassing ... It is actually a bug in the testcase itself :) I will take care of it ASAP.
I just committed a patch sent by Thomas, which should fix the issue. Regards Hartmut --------------- http://boost-spirit.com
On 1:59 PM, Hartmut Kaiser wrote:
On 1:59 PM, Hartmut Kaiser wrote:
Tests for Phoenix V2 are not run at all, IIUC. This will change only when/if Phoenix V3 has been moved to trunk after its mini-review. The tests you're referring to are Spirit specific tests using Phoenix features. Looking at what's already released, libs/spirit/phoenix/test, I see what looks like a full suite of tests, and when I run bjam on them I get 45 tests passed (on MinGW gcc-4.4/win-32) and one failure.
So the full compliment of tests is there and likely known to work on a couple platforms, just not run by the regression mechanism.
[...] We know about this bug and it is quite embarrassing ... It is actually a bug in the testcase itself :) I will take care of it ASAP.
Your vindication far outweighs this little embarrassment: your tests are there, seem comprehensive, and pass. I'd love to see them be part of the regular regression run, but I've seen enough to have confidence in it.
I just committed a patch sent by Thomas, which should fix the issue.
Excellent. Thanks.
On 2/8/2011 11:50 AM, Jim Bell wrote:
On 1:59 PM, Hartmut Kaiser wrote:
On 1:59 PM, Hartmut Kaiser wrote:
Tests for Phoenix V2 are not run at all, IIUC. This will change only when/if Phoenix V3 has been moved to trunk after its mini-review. The tests you're referring to are Spirit specific tests using Phoenix features. Looking at what's already released, libs/spirit/phoenix/test, I see what looks like a full suite of tests, and when I run bjam on them I get 45 tests passed (on MinGW gcc-4.4/win-32) and one failure.
So the full compliment of tests is there and likely known to work on a couple platforms, just not run by the regression mechanism.
[...] We know about this bug and it is quite embarrassing ... It is actually a bug in the testcase itself :) I will take care of it ASAP.
Your vindication far outweighs this little embarrassment: your tests are there, seem comprehensive, and pass. I'd love to see them be part of the regular regression run, but I've seen enough to have confidence in it.
It's my fault actually. Thanks Thomas and Hartmut! Regards, -- Joel de Guzman http://www.boostpro.com http://boost-spirit.com
On 1:59 PM, Joel de Guzman wrote:
On 2/8/2011 11:50 AM, Jim Bell wrote:
On 1:59 PM, Hartmut Kaiser wrote:
On 1:59 PM, Hartmut Kaiser wrote:
Tests for Phoenix V2 are not run at all, IIUC. This will change only when/if Phoenix V3 has been moved to trunk after its mini-review. The tests you're referring to are Spirit specific tests using Phoenix features. Looking at what's already released, libs/spirit/phoenix/test, I see what looks like a full suite of tests, and when I run bjam on them I get 45 tests passed (on MinGW gcc-4.4/win-32) and one failure.
So the full compliment of tests is there and likely known to work on a couple platforms, just not run by the regression mechanism.
[...] We know about this bug and it is quite embarrassing ... It is actually a bug in the testcase itself :) I will take care of it ASAP.
Your vindication far outweighs this little embarrassment: your tests are there, seem comprehensive, and pass. I'd love to see them be part of the regular regression run, but I've seen enough to have confidence in it.
It's my fault actually. Thanks Thomas and Hartmut!
With that commit, all 46 tests pass on MinGW gcc-4.4/Win-32. (Curiously, bjam ends with "...failed updating 1 target..." but I see no failures.) Cheers! -Jim
On 2/9/2011 11:02 AM, Jim Bell wrote:
With that commit, all 46 tests pass on MinGW gcc-4.4/Win-32. (Curiously, bjam ends with "...failed updating 1 target..." but I see no failures.)
Must be one of the expected-to-fail tests. That should be ok. Regards, -- Joel de Guzman http://www.boostpro.com http://boost-spirit.com
Jim Bell wrote:
From names in the spirit regression test matrix <http://www.boost.org/development/tests/release/developer/spirit.html>, I see these four with phoenix in the name: dedent_handling_phoenix, lex_dedent_handling_phoenix, lex_set_token_value_phoenix, set_token_value_phoenix.
When I search for phoenix in all libs/spirit/test code, I see references in 104 files, so tests span more than just above four.
But how well do phoenix's tests span its content? Is this documented somewhere?
No, this is not documented. I'd say that phoenix's tests already cover quite some bit. The algorithms to evaluated phoenix expressions isn't that hard. The hard part is the TMP stuff, which materlializes itself pretty fast during the tests. More testcases are welcome anytime!
Thanks in Advance, -Jim
participants (5)
-
Hartmut Kaiser -
Jim Bell -
Joel de Guzman -
Thomas Heller -
Vicente Botet