Request permission to apply patch to trunk.
I'd like to apply the attached patch to trunk. It is not supposed to break anything on an svn checkout, but we held off applying it until 1.55 beta shipped because of concern it would be disruptive if it somehow messed up the build system right in the middle of getting the beta out. Thanks to Bjørn Roald for developing the patch. Without this patch, the only way to test modular-boost headers mechanism is to manually apply the patch yourself, and that pretty much limits testing. OK to apply? --Beman
Fine by me.. Except do not apply the Predef patch. They are already in trunk and release. And I prefer to apply Predef patches directly to the source git repo. On Sun, Oct 20, 2013 at 2:13 PM, Beman Dawes <bdawes@acm.org> wrote:
I'd like to apply the attached patch to trunk. It is not supposed to break anything on an svn checkout, but we held off applying it until 1.55 beta shipped because of concern it would be disruptive if it somehow messed up the build system right in the middle of getting the beta out.
Thanks to Bjørn Roald for developing the patch.
Without this patch, the only way to test modular-boost headers mechanism is to manually apply the patch yourself, and that pretty much limits testing.
OK to apply?
--Beman
_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
-- -- -- Grafik - Don't Assume Anything -- Redshift Software, Inc. - http://redshift-software.com -- rrivera/acm.org - grafik/redshift-software.com -- 102708583/icq - grafikrobot/aim - grafikrobot/yahoo
On Sun, Oct 20, 2013 at 3:19 PM, Rene Rivera <grafikrobot@gmail.com> wrote:
Fine by me.. Except do not apply the Predef patch. They are already in trunk and release. And I prefer to apply Predef patches directly to the source git repo.
OK, understood. I won't actually do anything until I've gotten more feedback. --Beman
On 10/20/2013 09:13 PM, Beman Dawes wrote:
I'd like to apply the attached patch to trunk. It is not supposed to break anything on an svn checkout, but we held off applying it until 1.55 beta shipped because of concern it would be disruptive if it somehow messed up the build system right in the middle of getting the beta out.
Thanks to Bjørn Roald for developing the patch.
I am glad this will be applied to trunk so https://svn.boost.org/trac/boost/wiki/TryModBoost will finally work as advertised for testers. Thanks to Steven Watanabe, Jürgen Hunold, and Vladimir Prus which have their parts in developing Boost.Build support for modular layout using links to headers. In particular Steven did most of the heavy work which has been committed in trunk for some time. -- Bjørn
On 20.10.2013 23:13, Beman Dawes wrote:
I'd like to apply the attached patch to trunk. It is not supposed to break anything on an svn checkout, but we held off applying it until 1.55 beta shipped because of concern it would be disruptive if it somehow messed up the build system right in the middle of getting the beta out.
Thanks to Bjørn Roald for developing the patch.
Without this patch, the only way to test modular-boost headers mechanism is to manually apply the patch yourself, and that pretty much limits testing.
OK to apply?
Beman, as you probably know, the only reason this branch is not yet merged to trunk is because there's no proper dependency between install and headers set up yet. That is, you need "b2 headers" before "b2 install" will work. Whether you prefer to merge/commit now is rather up to you. FAOD, adding proper dependencies does not involve any theoretical difficulty, just a bit of time. - Volodya
Hi, On Monday, 21. October 2013 10:54:00 Vladimir Prus wrote:
On 20.10.2013 23:13, Beman Dawes wrote:
I'd like to apply the attached patch to trunk. It is not supposed to break anything on an svn checkout, but we held off applying it until 1.55 beta shipped because of concern it would be disruptive if it somehow messed up the build system right in the middle of getting the beta out.
Thanks to Bjørn Roald for developing the patch.
Without this patch, the only way to test modular-boost headers mechanism is to manually apply the patch yourself, and that pretty much limits testing.
OK to apply?
Yes, the patch looks fine.
as you probably know, the only reason this branch is not yet merged to trunk is because there's no proper dependency between install and headers set up yet. That is, you need "b2 headers" before "b2 install" will work. Whether you prefer to merge/commit now is rather up to you.
Please commit this one. It make thing easier.
FAOD, adding proper dependencies does not involve any theoretical difficulty, just a bit of time.
Right. And we can save some time by getting the things which already work into the repository. So we can concentrate on adapting the rest of the libraries. Yours, Jürgen -- * Dipl.-Math. Jürgen Hunold ! * voice: ++49 4257 300 ! Fährstraße 1 * fax : ++49 4257 300 ! 31609 Balge/Sebbenhausen * jhunold@gmx.eu ! Germany
On Mon, Oct 21, 2013 at 3:04 AM, Jürgen Hunold <jhunold@gmx.eu> wrote:
Hi,
On Monday, 21. October 2013 10:54:00 Vladimir Prus wrote:
On 20.10.2013 23:13, Beman Dawes wrote:
I'd like to apply the attached patch to trunk. It is not supposed to break anything on an svn checkout, but we held off applying it until 1.55 beta shipped because of concern it would be disruptive if it somehow messed up the build system right in the middle of getting the beta out.
Thanks to Bjørn Roald for developing the patch.
Without this patch, the only way to test modular-boost headers mechanism is to manually apply the patch yourself, and that pretty much limits testing.
OK to apply?
Yes, the patch looks fine.
as you probably know, the only reason this branch is not yet merged to trunk is because there's no proper dependency between install and headers set up yet. That is, you need "b2 headers" before "b2 install" will work. Whether you prefer to merge/commit now is rather up to you.
Please commit this one. It make thing easier.
FAOD, adding proper dependencies does not involve any theoretical difficulty, just a bit of time.
Right. And we can save some time by getting the things which already work into the repository. So we can concentrate on adapting the rest of the libraries.
That's a very important point. As the remaining conversion issues shrink, the lack of this patch is limiting testing unnecessarily. On Windows 7 and Ubunto Linux I've done a fresh SVN checkout of trunk and verified bootstrap.bat, bootstrap.sh, and a b2 build work both before and after the patch is applied. On Windows, I verified that after the patch is applied a b2 build using an unpatched prior compilation of b2 still works. These tests increase confidence that committing the patch to trunk now isn't likely to cause breakage, so I'm going ahead with the svn commit. Thanks, --Beman
On 20.10.2013 23:13, Beman Dawes wrote:> I'd like to apply the attached patch to trunk. It is not supposed to break
anything on an svn checkout, but we held off applying it until 1.55 beta shipped because of concern it would be disruptive if it somehow messed up the build system right in the middle of getting the beta out.
Thanks to Bjørn Roald for developing the patch.
Without this patch, the only way to test modular-boost headers mechanism is to manually apply the patch yourself, and that pretty much limits testing.
OK to apply?
Beman, as you probably know, the only reason this branch is not yet merged to trunk is because there's no proper dependency between install and headers set up yet. That is, you need "b2 headers" before "b2 install" will work. Whether you prefer to merge/commit now is rather up to you. FAOD, adding proper dependencies does not involve any theoretical difficulty, just a bit of time. - Volodya
participants (5)
-
Beman Dawes -
Bjørn Roald -
Jürgen Hunold -
Rene Rivera -
Vladimir Prus