[release] Boost 1.85.0 Release Candidate 3 is available
The third release candidates for the 1.85.0 release are now available at: <https://boostorg.jfrog.io/artifactory/main/release/1.85.0/source/> The SHA256 checksums are as follows: e712fe7eb1b9ec37ac25102525412fb4d74e638996443944025791f48f29408a boost_1_85_0_rc3.zip 7009fe1faa1697476bdc7027703a2badb84e849b7b0baad5086b087b971f8617 boost_1_85_0_rc3.tar.bz2 16d16b9658753117c1434e5450c5eac194957f4b6d0b390b9d07900d37c115a4 boost_1_85_0_rc3.7z be0d91732d5b0cc6fbb275c7939974457e79b54d6f07ce2e3dfdd68bef883b0b boost_1_85_0_rc3.tar.gz The changes from RC1 are: * Boost.ASIO docs generate very long file names that are not usable on Windows. * Boost.Program options does not build in C++23 mode on clang truck (to be clang 19 before boost 1.86.0 is released) Note: It is possible that this is a bug in clang, and it’s in a clang that is not released yet. * Boost.Log has some broken links in its documentation. * A meaningless change to Boost.Array (add a space to a test file) Apparently the RC2 tarballs were mis-buiilt; some of them were missing the required changes. I believe that RC3 resolves that problem. As always, the release managers would appreciate it if you download the candidate of your choice and give building it a try. Please report both success and failure, and anything else that is noteworthy. -- The Release managers
On 4/12/24 00:31, Marshall Clow via Boost wrote:
The third release candidates for the 1.85.0 release are now available at: <https://boostorg.jfrog.io/artifactory/main/release/1.85.0/source/>
The SHA256 checksums are as follows:
e712fe7eb1b9ec37ac25102525412fb4d74e638996443944025791f48f29408a boost_1_85_0_rc3.zip 7009fe1faa1697476bdc7027703a2badb84e849b7b0baad5086b087b971f8617 boost_1_85_0_rc3.tar.bz2 16d16b9658753117c1434e5450c5eac194957f4b6d0b390b9d07900d37c115a4 boost_1_85_0_rc3.7z be0d91732d5b0cc6fbb275c7939974457e79b54d6f07ce2e3dfdd68bef883b0b boost_1_85_0_rc3.tar.gz
The changes from RC1 are:
* Boost.ASIO docs generate very long file names that are not usable on Windows. * Boost.Program options does not build in C++23 mode on clang truck (to be clang 19 before boost 1.86.0 is released) Note: It is possible that this is a bug in clang, and it’s in a clang that is not released yet. * Boost.Log has some broken links in its documentation. * A meaningless change to Boost.Array (add a space to a test file)
Apparently the RC2 tarballs were mis-buiilt; some of them were missing the required changes. I believe that RC3 resolves that problem.
As always, the release managers would appreciate it if you download the candidate of your choice and give building it a try. Please report both success and failure, and anything else that is noteworthy.
I can confirm that the .tar.bz2 file contains the Boost.Log fix and all .json files reference the same commit ab7968a0bbcf574a7859240d1d8443f58ed6f6cf.
On Thu, Apr 11, 2024 at 4:31 PM Marshall Clow via Boost < boost@lists.boost.org> wrote:
The third release candidates for the 1.85.0 release are now available at: <https://boostorg.jfrog.io/artifactory/main/release/1.85.0/source/>
The SHA256 checksums are as follows:
e712fe7eb1b9ec37ac25102525412fb4d74e638996443944025791f48f29408a boost_1_85_0_rc3.zip 7009fe1faa1697476bdc7027703a2badb84e849b7b0baad5086b087b971f8617 boost_1_85_0_rc3.tar.bz2 16d16b9658753117c1434e5450c5eac194957f4b6d0b390b9d07900d37c115a4 boost_1_85_0_rc3.7z be0d91732d5b0cc6fbb275c7939974457e79b54d6f07ce2e3dfdd68bef883b0b boost_1_85_0_rc3.tar.gz
The changes from RC1 are:
* Boost.ASIO docs generate very long file names that are not usable on Windows. * Boost.Program options does not build in C++23 mode on clang truck (to be clang 19 before boost 1.86.0 is released) Note: It is possible that this is a bug in clang, and it’s in a clang that is not released yet. * Boost.Log has some broken links in its documentation. * A meaningless change to Boost.Array (add a space to a test file)
Apparently the RC2 tarballs were mis-buiilt; some of them were missing the required changes. I believe that RC3 resolves that problem.
As always, the release managers would appreciate it if you download the candidate of your choice and give building it a try. Please report both success and failure, and anything else that is noteworthy.
-- The Release managers
Third time's the charm! Looks good on windows/visual studio. toolset arch compile Link Execute msvc-14.0 32 X X X msvc-14.0 64 X X X msvc-14.1 32 X X X msvc-14.1 64 X X X msvc-14.2 32 X X X msvc-14.2 64 X X X msvc-14.3 32 X X X msvc-14.3 64 X X X Compile means that the b2 command completed without errors Link means that visual studio was able to link a sample executable to a library (libboost_thread-vcXXX-mt[-gd]-1_XX.lib) generated Execute means that the linked program executed without errors. Full build logs here: https://gist.github.com/teeks99/2cd4744cdff04ae73a4d611ad9972d30 Tom
As always, the release managers would appreciate it if you download the candidate of your choice and give building it a try. Please report both success and failure, and anything else that is noteworthy.
I have successfully built the libraries on an M1 Mac running Sonoma 14.4.1 with homebrew clang 17.0.6 and homebrew GCC 13.2.0 using cxxstd=11,14,17,20,23. I was hoping to test on clang 18 before release, but looks like homebrew has been having issues: https://github.com/Homebrew/homebrew-core/pull/165206 Matt
Am 2024-04-11 23:31, schrieb Marshall Clow via Boost:
The third release candidates for the 1.85.0 release are now available at: <https://boostorg.jfrog.io/artifactory/main/release/1.85.0/source/>
The SHA256 checksums are as follows:
e712fe7eb1b9ec37ac25102525412fb4d74e638996443944025791f48f29408a boost_1_85_0_rc3.zip 7009fe1faa1697476bdc7027703a2badb84e849b7b0baad5086b087b971f8617 boost_1_85_0_rc3.tar.bz2 16d16b9658753117c1434e5450c5eac194957f4b6d0b390b9d07900d37c115a4 boost_1_85_0_rc3.7z be0d91732d5b0cc6fbb275c7939974457e79b54d6f07ce2e3dfdd68bef883b0b boost_1_85_0_rc3.tar.gz
The changes from RC1 are:
* Boost.ASIO docs generate very long file names that are not usable on Windows. * Boost.Program options does not build in C++23 mode on clang truck (to be clang 19 before boost 1.86.0 is released) Note: It is possible that this is a bug in clang, and it’s in a clang that is not released yet. * Boost.Log has some broken links in its documentation. * A meaningless change to Boost.Array (add a space to a test file)
Apparently the RC2 tarballs were mis-buiilt; some of them were missing the required changes. I believe that RC3 resolves that problem.
As always, the release managers would appreciate it if you download the candidate of your choice and give building it a try. Please report both success and failure, and anything else that is noteworthy.
-- The Release managers
_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
I built on a Windows Server 2019 with msvc 143 and command line .\b2.exe --toolset=msvc-14.3 variant=debug,release runtime-link=shared,static --stagedir=./stage context-impl=winfib -j 96 Build succeeded with: The Boost C++ Libraries were successfully built! but in between there was an error: [errno 22] failed to scan file '': Invalid argument...found 44592 targets... Never had that before. Tobias
Am 2024-04-11 23:31, schrieb Marshall Clow via Boost:
The third release candidates for the 1.85.0 release are now available at: <https://boostorg.jfrog.io/artifactory/main/release/1.85.0/source/>
The SHA256 checksums are as follows:
e712fe7eb1b9ec37ac25102525412fb4d74e638996443944025791f48f29408a boost_1_85_0_rc3.zip 7009fe1faa1697476bdc7027703a2badb84e849b7b0baad5086b087b971f8617 boost_1_85_0_rc3.tar.bz2 16d16b9658753117c1434e5450c5eac194957f4b6d0b390b9d07900d37c115a4 boost_1_85_0_rc3.7z be0d91732d5b0cc6fbb275c7939974457e79b54d6f07ce2e3dfdd68bef883b0b boost_1_85_0_rc3.tar.gz
The changes from RC1 are:
* Boost.ASIO docs generate very long file names that are not usable on Windows. * Boost.Program options does not build in C++23 mode on clang truck (to be clang 19 before boost 1.86.0 is released) Note: It is possible that this is a bug in clang, and it’s in a clang that is not released yet. * Boost.Log has some broken links in its documentation. * A meaningless change to Boost.Array (add a space to a test file)
Apparently the RC2 tarballs were mis-buiilt; some of them were missing the required changes. I believe that RC3 resolves that problem.
As always, the release managers would appreciate it if you download the candidate of your choice and give building it a try. Please report both success and failure, and anything else that is noteworthy.
-- The Release managers
_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
After deleting everything, re-unpacking and re-building everything, the error [errno 22] failed to scan file '': Invalid argument did not occur again. Seems to have been some sporadic error on my machine. Tobias
On Fri, Apr 12, 2024 at 8:29 AM Tobias Loew via Boost <boost@lists.boost.org> wrote:
After deleting everything, re-unpacking and re-building everything, the error
[errno 22] failed to scan file '': Invalid argument
did not occur again. Seems to have been some sporadic error on my machine.
It was a known issue that was fixed. You must have been using an old b2 on your first try. -- -- René Ferdinand Rivera Morell -- Don't Assume Anything -- No Supone Nada -- Robot Dreams - http://robot-dreams.net
On Apr 12, 2024, at 6:28 AM, Tobias Loew via Boost <boost@lists.boost.org> wrote:
Am 2024-04-11 23:31, schrieb Marshall Clow via Boost:
The third release candidates for the 1.85.0 release are now available at: <https://boostorg.jfrog.io/artifactory/main/release/1.85.0/source/> The SHA256 checksums are as follows: e712fe7eb1b9ec37ac25102525412fb4d74e638996443944025791f48f29408a boost_1_85_0_rc3.zip 7009fe1faa1697476bdc7027703a2badb84e849b7b0baad5086b087b971f8617 boost_1_85_0_rc3.tar.bz2 16d16b9658753117c1434e5450c5eac194957f4b6d0b390b9d07900d37c115a4 boost_1_85_0_rc3.7z be0d91732d5b0cc6fbb275c7939974457e79b54d6f07ce2e3dfdd68bef883b0b boost_1_85_0_rc3.tar.gz The changes from RC1 are: * Boost.ASIO docs generate very long file names that are not usable on Windows. * Boost.Program options does not build in C++23 mode on clang truck (to be clang 19 before boost 1.86.0 is released) Note: It is possible that this is a bug in clang, and it’s in a clang that is not released yet. * Boost.Log has some broken links in its documentation. * A meaningless change to Boost.Array (add a space to a test file) Apparently the RC2 tarballs were mis-buiilt; some of them were missing the required changes. I believe that RC3 resolves that problem. As always, the release managers would appreciate it if you download the candidate of your choice and give building it a try. Please report both success and failure, and anything else that is noteworthy. -- The Release managers _______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
After deleting everything, re-unpacking and re-building everything, the error
[errno 22] failed to scan file '': Invalid argument
did not occur again. Seems to have been some sporadic error on my machine.
It happened in the beta. When you rebuilt `b2`, it went away. — Marshall
The third release candidates for the 1.85.0 release are now available at: <https://boostorg.jfrog.io/artifactory/main/release/1.85.0/source/>
I have successfully built RC3 with clang-19, variant=release, cxxstd=23 under Ubuntu 22.04. The program_options issue looks solved. Regards, Ruben.
Hi, Just checking, but the Cray/llvm based compiler is not part of the toolset right ? Thanks ----- On Apr 11, 2024, at 11:31 PM, Marshall Clow via Boost boost@lists.boost.org wrote:
The third release candidates for the 1.85.0 release are now available at: <https://boostorg.jfrog.io/artifactory/main/release/1.85.0/source/>
The SHA256 checksums are as follows:
e712fe7eb1b9ec37ac25102525412fb4d74e638996443944025791f48f29408a boost_1_85_0_rc3.zip 7009fe1faa1697476bdc7027703a2badb84e849b7b0baad5086b087b971f8617 boost_1_85_0_rc3.tar.bz2 16d16b9658753117c1434e5450c5eac194957f4b6d0b390b9d07900d37c115a4 boost_1_85_0_rc3.7z be0d91732d5b0cc6fbb275c7939974457e79b54d6f07ce2e3dfdd68bef883b0b boost_1_85_0_rc3.tar.gz
The changes from RC1 are:
* Boost.ASIO docs generate very long file names that are not usable on Windows. * Boost.Program options does not build in C++23 mode on clang truck (to be clang 19 before boost 1.86.0 is released) Note: It is possible that this is a bug in clang, and it’s in a clang that is not released yet. * Boost.Log has some broken links in its documentation. * A meaningless change to Boost.Array (add a space to a test file)
Apparently the RC2 tarballs were mis-buiilt; some of them were missing the required changes. I believe that RC3 resolves that problem.
As always, the release managers would appreciate it if you download the candidate of your choice and give building it a try. Please report both success and failure, and anything else that is noteworthy.
-- The Release managers
_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
Hi, I have to build with cmake on my platform (HPE/Cray compiler does not seems to be recognized by b2). What is th etag associated to RC3? I have a compiler crash with boost-1.85.0.beta1 and I would like to make sue I'm on the right version. Thanks. Alain ----- On Apr 12, 2024, at 5:00 PM, Alain O' Miniussi via Boost boost@lists.boost.org wrote:
Hi,
Just checking, but the Cray/llvm based compiler is not part of the toolset right ?
Thanks
----- On Apr 11, 2024, at 11:31 PM, Marshall Clow via Boost boost@lists.boost.org wrote:
The third release candidates for the 1.85.0 release are now available at: <https://boostorg.jfrog.io/artifactory/main/release/1.85.0/source/>
The SHA256 checksums are as follows:
e712fe7eb1b9ec37ac25102525412fb4d74e638996443944025791f48f29408a boost_1_85_0_rc3.zip 7009fe1faa1697476bdc7027703a2badb84e849b7b0baad5086b087b971f8617 boost_1_85_0_rc3.tar.bz2 16d16b9658753117c1434e5450c5eac194957f4b6d0b390b9d07900d37c115a4 boost_1_85_0_rc3.7z be0d91732d5b0cc6fbb275c7939974457e79b54d6f07ce2e3dfdd68bef883b0b boost_1_85_0_rc3.tar.gz
The changes from RC1 are:
* Boost.ASIO docs generate very long file names that are not usable on Windows. * Boost.Program options does not build in C++23 mode on clang truck (to be clang 19 before boost 1.86.0 is released) Note: It is possible that this is a bug in clang, and it’s in a clang that is not released yet. * Boost.Log has some broken links in its documentation. * A meaningless change to Boost.Array (add a space to a test file)
Apparently the RC2 tarballs were mis-buiilt; some of them were missing the required changes. I believe that RC3 resolves that problem.
As always, the release managers would appreciate it if you download the candidate of your choice and give building it a try. Please report both success and failure, and anything else that is noteworthy.
-- The Release managers
_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
On 4/13/24 14:02, Alain O' Miniussi via Boost wrote:
Hi,
I have to build with cmake on my platform (HPE/Cray compiler does not seems to be recognized by b2). What is th etag associated to RC3?
There are no tags associated with RCs. But you can see the Boost superproject commit that was used to create each of the archives in the associated .json file near the archive. For 1.85.0 RC3 that commit is ab7968a0bbcf574a7859240d1d8443f58ed6f6cf.
Thanks, FWIW, rc3 triggers a compiler crash with crayCC 17.0.0 13:40:37 [alainm@login2 rel]#crayCC --version Cray clang version 17.0.0 (b59b7a8e9169719529cf5ab440f3c301e515d047) Target: x86_64-unknown-linux-gnu Thread model: posix InstalledDir: /opt/cray/pe/cce/17.0.0/cce-clang/x86_64/share/../bin 13:40:45 [alainm@login2 rel]# when compiling libs/url/src/segments_view.cpp ----- On Apr 13, 2024, at 1:20 PM, Andrey Semashev via Boost boost@lists.boost.org wrote:
On 4/13/24 14:02, Alain O' Miniussi via Boost wrote:
Hi,
I have to build with cmake on my platform (HPE/Cray compiler does not seems to be recognized by b2). What is th etag associated to RC3?
There are no tags associated with RCs. But you can see the Boost superproject commit that was used to create each of the archives in the associated .json file near the archive. For 1.85.0 RC3 that commit is ab7968a0bbcf574a7859240d1d8443f58ed6f6cf.
_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
On Mon, Apr 15, 2024 at 4:53 AM Alain O' Miniussi via Boost < boost@lists.boost.org> wrote:
FWIW, rc3 triggers a compiler crash with crayCC 17.0.0
I don't have access to this compiler, and there is not enough information provided to make any guess on what the problem is. If you know someone with access to the compiler, consider bisecting the file segments_view.cpp to determine which line is causing the crash. Bisecting works like this, you split the cpp file into two pieces, copying the #includes and whatever else is needed to make them compile. Then you note which file causes the crash. Repeat the splitting process on the crashing file until you have determined the smallest cpp file which causes the crash. Then post that to the list. Thanks
---- On Apr 15, 2024, at 6:18 PM, Vinnie Falco <vinnie.falco@gmail.com> wrote: On Mon, Apr 15, 2024 at 4:53 AM Alain O' Miniussi via Boost < [ mailto:boost@lists.boost.org | boost@lists.boost.org ] > wrote: BQ_BEGIN FWIW, rc3 triggers a compiler crash with crayCC 17.0.0 I don't have access to this compiler, BQ_END Few people do, it's an issue. It's basically a clang++ with more bugs. BQ_BEGIN and there is not enough information provided to make any guess on what the problem is. If you know someone with access to the compiler, consider bisecting the file segments_view.cpp BQ_END I'll do that BQ_BEGIN to determine which line is causing the crash. Bisecting works like this, you split the cpp file into two pieces, copying the #includes and whatever else is needed to make them compile. Then you note which file causes the crash. Repeat the splitting process on the crashing file until you have determined the smallest cpp file which causes the crash. Then post that to the list. Thanks BQ_END
Sorry, I did not pay attention to the fact that I had more info from the crash itself (probably not enough though: 1. /lus/work/CT4/cin7233/SHARED/boost_build/boost/libs/url/src/segments_view.cpp:34:1: current parser token '{' 2. /lus/work/CT4/cin7233/SHARED/boost_build/boost/libs/url/src/segments_view.cpp:18:1: parsing namespace 'boost' 3. /lus/work/CT4/cin7233/SHARED/boost_build/boost/libs/url/src/segments_view.cpp:19:1: parsing namespace 'boost::urls' #0 0x0000000003b7e487 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x3b7e487) #1 0x0000000003b7b82b SignalHandler(int) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x3b7b82b) #0 0x0000000003b7e487 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x3b7e487) #1 0x0000000003b7b82b SignalHandler(int) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x3b7b82b) #2 0x00007f475636acef (/lib64/libpthread.so.0+0x12cef) #3 0x00007f475508eace raise (/lib64/libc.so.6+0x4eace) #4 0x00007f4755061ea4 abort (/lib64/libc.so.6+0x21ea4) #5 0x00007f4755061d78 __assert_fail_base.cold.0 (/lib64/libc.so.6+0x21d78) #6 0x00007f4755087425 __assert_fail (/lib64/libc.so.6+0x47425) #7 0x00000000062e0306 clang::Sema::BuildDelegatingInitializer(clang::TypeSourceInfo*, clang::Expr*, clang::CXXRecordDecl*) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x62e0306) #8 0x00000000062e581e clang::Sema::BuildBaseInitializer(clang::QualType, clang::TypeSourceInfo*, clang::Expr*, clang::CXXRecordDecl*, clang::SourceLocation) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x62e581e) #9 0x00000000062e6248 clang::Sema::BuildMemInitializer(clang::Decl*, clang::Scope*, clang::CXXScopeSpec&, clang::IdentifierInfo*, clang::OpaquePtr<clang::QualType>, clang::DeclSpec const&, clang::SourceLocation, clang::Expr*, clang::SourceLocation) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x62e6248) #10 0x0000000005f2b343 clang::Parser::ParseMemInitializer(clang::Decl*) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x5f2b343) #11 0x0000000005f2e7c0 clang::Parser::ParseConstructorInitializer(clang::Decl*) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x5f2e7c0) #12 0x0000000005ee8d87 clang::Parser::ParseFunctionDefinition(clang::ParsingDeclarator&, clang::Parser::ParsedTemplateInfo const&, clang::Parser::LateParsedAttrList*) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x5ee8d87) #13 0x0000000005f19cf2 clang::Parser::ParseDeclGroup(clang::ParsingDeclSpec&, clang::DeclaratorContext, clang::ParsedAttributes&, clang::SourceLocation*, clang::Parser::ForRangeInit*) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x5f19cf2) #14 0x0000000005ee35b8 clang::Parser::ParseDeclarationOrFunctionDefinition(clang::ParsedAttributes&, clang::ParsedAttributes&, clang::ParsingDeclSpec*, clang::AccessSpecifier) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x5ee35b8) #15 0x0000000005eec557 clang::Parser::ParseExternalDeclaration(clang::ParsedAttributes&, clang::ParsedAttributes&, clang::ParsingDeclSpec*) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x5eec557) #16 0x0000000005f31a5d clang::Parser::ParseInnerNamespace(llvm::SmallVector<clang::Parser::InnerNamespaceInfo, 4u> const&, unsigned int, clang::SourceLocation&, clang::ParsedAttributes&, clang::BalancedDelimiterTracker&) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x5f31a5d) #17 0x0000000005f35f1d clang::Parser::ParseNamespace(clang::DeclaratorContext, clang::SourceLocation&, clang::SourceLocation) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x5f35f1d) #18 0x0000000005f1cde7 clang::Parser::ParseDeclaration(clang::DeclaratorContext, clang::SourceLocation&, clang::ParsedAttributes&, clang::ParsedAttributes&, clang::SourceLocation*) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x5f1cde7) #19 0x0000000005eec585 clang::Parser::ParseExternalDeclaration(clang::ParsedAttributes&, clang::ParsedAttributes&, clang::ParsingDeclSpec*) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x5eec585) #20 0x0000000005f31a5d clang::Parser::ParseInnerNamespace(llvm::SmallVector<clang::Parser::InnerNamespaceInfo, 4u> const&, unsigned int, clang::SourceLocation&, clang::ParsedAttributes&, clang::BalancedDelimiterTracker&) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x5f31a5d) #21 0x0000000005f35f1d clang::Parser::ParseNamespace(clang::DeclaratorContext, clang::SourceLocation&, clang::SourceLocation) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x5f35f1d) #22 0x0000000005f1cde7 clang::Parser::ParseDeclaration(clang::DeclaratorContext, clang::SourceLocation&, clang::ParsedAttributes&, clang::ParsedAttributes&, clang::SourceLocation*) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x5f1cde7) #23 0x0000000005eec585 clang::Parser::ParseExternalDeclaration(clang::ParsedAttributes&, clang::ParsedAttributes&, clang::ParsingDeclSpec*) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x5eec585) #24 0x0000000005eed46c clang::Parser::ParseTopLevelDecl(clang::OpaquePtr<clang::DeclGroupRef>&, clang::Sema::ModuleImportState&) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x5eed46c) #25 0x0000000005edbe11 clang::ParseAST(clang::Sema&, bool, bool) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x5edbe11) #26 0x00000000046fd308 clang::FrontendAction::Execute() (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x46fd308) #27 0x0000000004673f25 clang::CompilerInstance::ExecuteAction(clang::FrontendAction&) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x4673f25) #28 0x00000000047d2011 clang::ExecuteCompilerInvocation(clang::CompilerInstance*) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x47d2011) #29 0x0000000000f0768a cc1_main(llvm::ArrayRef<char const*>, char const*, void*) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0xf0768a) #30 0x0000000000eff053 ExecuteCC1Tool(llvm::SmallVectorImpl<char const*>&, llvm::ToolContext const&) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0xeff053) #31 0x0000000000f04a74 clang_main(int, char**, llvm::ToolContext const&) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0xf04a74) #32 0x0000000000e1d010 main (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0xe1d010) ---- Alain Miniussi DSI, Pôles Calcul et Genie Log. Observatoire de la Côte d'Azur Tél. : +33609650665 ----- On Apr 15, 2024, at 6:18 PM, Vinnie Falco <vinnie.falco@gmail.com> wrote:
On Mon, Apr 15, 2024 at 4:53 AM Alain O' Miniussi via Boost < [ mailto:boost@lists.boost.org | boost@lists.boost.org ] > wrote:
FWIW, rc3 triggers a compiler crash with crayCC 17.0.0
I don't have access to this compiler, and there is not enough information provided to make any guess on what the problem is. If you know someone with access to the compiler, consider bisecting the file segments_view.cpp to determine which line is causing the crash.
Bisecting works like this, you split the cpp file into two pieces, copying the #includes and whatever else is needed to make them compile. Then you note which file causes the crash. Repeat the splitting process on the crashing file until you have determined the smallest cpp file which causes the crash. Then post that to the list.
Thanks
So,it crashes while looking at segments_view:: segments_view( core::string_view s) : segments_view( parse_path(s).value( BOOST_URL_POS) { // <= this token } ----- On Apr 16, 2024, at 9:50 AM, Alain O' Miniussi via Boost boost@lists.boost.org wrote:
Sorry, I did not pay attention to the fact that I had more info from the crash itself (probably not enough though:
1. /lus/work/CT4/cin7233/SHARED/boost_build/boost/libs/url/src/segments_view.cpp:34:1: current parser token '{' 2. /lus/work/CT4/cin7233/SHARED/boost_build/boost/libs/url/src/segments_view.cpp:18:1: parsing namespace 'boost' 3. /lus/work/CT4/cin7233/SHARED/boost_build/boost/libs/url/src/segments_view.cpp:19:1: parsing namespace 'boost::urls' #0 0x0000000003b7e487 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x3b7e487) #1 0x0000000003b7b82b SignalHandler(int) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x3b7b82b) #0 0x0000000003b7e487 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x3b7e487) #1 0x0000000003b7b82b SignalHandler(int) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x3b7b82b) #2 0x00007f475636acef (/lib64/libpthread.so.0+0x12cef) #3 0x00007f475508eace raise (/lib64/libc.so.6+0x4eace) #4 0x00007f4755061ea4 abort (/lib64/libc.so.6+0x21ea4) #5 0x00007f4755061d78 __assert_fail_base.cold.0 (/lib64/libc.so.6+0x21d78) #6 0x00007f4755087425 __assert_fail (/lib64/libc.so.6+0x47425) #7 0x00000000062e0306 clang::Sema::BuildDelegatingInitializer(clang::TypeSourceInfo*, clang::Expr*, clang::CXXRecordDecl*) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x62e0306) #8 0x00000000062e581e clang::Sema::BuildBaseInitializer(clang::QualType, clang::TypeSourceInfo*, clang::Expr*, clang::CXXRecordDecl*, clang::SourceLocation) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x62e581e) #9 0x00000000062e6248 clang::Sema::BuildMemInitializer(clang::Decl*, clang::Scope*, clang::CXXScopeSpec&, clang::IdentifierInfo*, clang::OpaquePtr<clang::QualType>, clang::DeclSpec const&, clang::SourceLocation, clang::Expr*, clang::SourceLocation) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x62e6248) #10 0x0000000005f2b343 clang::Parser::ParseMemInitializer(clang::Decl*) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x5f2b343) #11 0x0000000005f2e7c0 clang::Parser::ParseConstructorInitializer(clang::Decl*) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x5f2e7c0) #12 0x0000000005ee8d87 clang::Parser::ParseFunctionDefinition(clang::ParsingDeclarator&, clang::Parser::ParsedTemplateInfo const&, clang::Parser::LateParsedAttrList*) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x5ee8d87) #13 0x0000000005f19cf2 clang::Parser::ParseDeclGroup(clang::ParsingDeclSpec&, clang::DeclaratorContext, clang::ParsedAttributes&, clang::SourceLocation*, clang::Parser::ForRangeInit*) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x5f19cf2) #14 0x0000000005ee35b8 clang::Parser::ParseDeclarationOrFunctionDefinition(clang::ParsedAttributes&, clang::ParsedAttributes&, clang::ParsingDeclSpec*, clang::AccessSpecifier) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x5ee35b8) #15 0x0000000005eec557 clang::Parser::ParseExternalDeclaration(clang::ParsedAttributes&, clang::ParsedAttributes&, clang::ParsingDeclSpec*) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x5eec557) #16 0x0000000005f31a5d clang::Parser::ParseInnerNamespace(llvm::SmallVector<clang::Parser::InnerNamespaceInfo, 4u> const&, unsigned int, clang::SourceLocation&, clang::ParsedAttributes&, clang::BalancedDelimiterTracker&) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x5f31a5d) #17 0x0000000005f35f1d clang::Parser::ParseNamespace(clang::DeclaratorContext, clang::SourceLocation&, clang::SourceLocation) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x5f35f1d) #18 0x0000000005f1cde7 clang::Parser::ParseDeclaration(clang::DeclaratorContext, clang::SourceLocation&, clang::ParsedAttributes&, clang::ParsedAttributes&, clang::SourceLocation*) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x5f1cde7) #19 0x0000000005eec585 clang::Parser::ParseExternalDeclaration(clang::ParsedAttributes&, clang::ParsedAttributes&, clang::ParsingDeclSpec*) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x5eec585) #20 0x0000000005f31a5d clang::Parser::ParseInnerNamespace(llvm::SmallVector<clang::Parser::InnerNamespaceInfo, 4u> const&, unsigned int, clang::SourceLocation&, clang::ParsedAttributes&, clang::BalancedDelimiterTracker&) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x5f31a5d) #21 0x0000000005f35f1d clang::Parser::ParseNamespace(clang::DeclaratorContext, clang::SourceLocation&, clang::SourceLocation) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x5f35f1d) #22 0x0000000005f1cde7 clang::Parser::ParseDeclaration(clang::DeclaratorContext, clang::SourceLocation&, clang::ParsedAttributes&, clang::ParsedAttributes&, clang::SourceLocation*) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x5f1cde7) #23 0x0000000005eec585 clang::Parser::ParseExternalDeclaration(clang::ParsedAttributes&, clang::ParsedAttributes&, clang::ParsingDeclSpec*) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x5eec585) #24 0x0000000005eed46c clang::Parser::ParseTopLevelDecl(clang::OpaquePtr<clang::DeclGroupRef>&, clang::Sema::ModuleImportState&) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x5eed46c) #25 0x0000000005edbe11 clang::ParseAST(clang::Sema&, bool, bool) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x5edbe11) #26 0x00000000046fd308 clang::FrontendAction::Execute() (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x46fd308) #27 0x0000000004673f25 clang::CompilerInstance::ExecuteAction(clang::FrontendAction&) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x4673f25) #28 0x00000000047d2011 clang::ExecuteCompilerInvocation(clang::CompilerInstance*) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0x47d2011) #29 0x0000000000f0768a cc1_main(llvm::ArrayRef<char const*>, char const*, void*) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0xf0768a) #30 0x0000000000eff053 ExecuteCC1Tool(llvm::SmallVectorImpl<char const*>&, llvm::ToolContext const&) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0xeff053) #31 0x0000000000f04a74 clang_main(int, char**, llvm::ToolContext const&) (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0xf04a74) #32 0x0000000000e1d010 main (/opt/cray/pe/cce/17.0.0/cce-clang/x86_64/bin/clang-17+0xe1d010)
---- Alain Miniussi DSI, Pôles Calcul et Genie Log. Observatoire de la Côte d'Azur Tél. : +33609650665
----- On Apr 15, 2024, at 6:18 PM, Vinnie Falco <vinnie.falco@gmail.com> wrote:
On Mon, Apr 15, 2024 at 4:53 AM Alain O' Miniussi via Boost < [ mailto:boost@lists.boost.org | boost@lists.boost.org ] > wrote:
FWIW, rc3 triggers a compiler crash with crayCC 17.0.0
I don't have access to this compiler, and there is not enough information provided to make any guess on what the problem is. If you know someone with access to the compiler, consider bisecting the file segments_view.cpp to determine which line is causing the crash.
Bisecting works like this, you split the cpp file into two pieces, copying the #includes and whatever else is needed to make them compile. Then you note which file causes the crash. Repeat the splitting process on the crashing file until you have determined the smallest cpp file which causes the crash. Then post that to the list.
Thanks
_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
On Tue, Apr 16, 2024 at 7:13 AM Alain O' Miniussi <alain.miniussi@oca.eu> wrote:
So,it crashes while looking at
Try changing the function to this (note, I did not test it, so it might have compiler errors but you get the idea): segments_view:: segments_view( core::string_view s) : segments_base( parse_path(s).value( BOOST_URL_POS)) { } The change is to call the base class constructor instead of a delegating constructor. Thanks
----- On Apr 16, 2024, at 4:41 PM, Vinnie Falco via Boost boost@lists.boost.org wrote:
Try changing the function to this (note, I did not test it, so it might have compiler errors but you get the idea):
segments_view:: segments_view( core::string_view s) : segments_base( parse_path(s).value( BOOST_URL_POS)) { }
The change is to call the base class constructor instead of a delegating constructor.
Thanks, that version does not trigger the compiler bug.
It seems that this bug is fixed in the version 18.x of the cray compiler. ----- On Apr 16, 2024, at 4:41 PM, Vinnie Falco via Boost boost@lists.boost.org wrote:
On Tue, Apr 16, 2024 at 7:13 AM Alain O' Miniussi <alain.miniussi@oca.eu> wrote:
So,it crashes while looking at
Try changing the function to this (note, I did not test it, so it might have compiler errors but you get the idea):
segments_view:: segments_view( core::string_view s) : segments_base( parse_path(s).value( BOOST_URL_POS)) { }
The change is to call the base class constructor instead of a delegating constructor.
Thanks
_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
Thanks,
FWIW, rc3 triggers a compiler crash with crayCC 17.0.0 13:40:37 [alainm@login2 rel]#crayCC --version Cray clang version 17.0.0 (b59b7a8e9169719529cf5ab440f3c301e515d047) Target: x86_64-unknown-linux-gnu Thread model: posix InstalledDir: /opt/cray/pe/cce/17.0.0/cce-clang/x86_64/share/../bin 13:40:45 [alainm@login2 rel]#
Is there a way to get access to the compiler for CI purposes? A Docker image or virtual machine would be ideal. Out of curiosity, what environments is this used for? Is it HPC? Regards, Ruben.
----- On Apr 16, 2024, at 5:40 PM, Ruben Perez via Boost boost@lists.boost.org wrote:
Thanks,
FWIW, rc3 triggers a compiler crash with crayCC 17.0.0 13:40:37 [alainm@login2 rel]#crayCC --version Cray clang version 17.0.0 (b59b7a8e9169719529cf5ab440f3c301e515d047) Target: x86_64-unknown-linux-gnu Thread model: posix InstalledDir: /opt/cray/pe/cce/17.0.0/cce-clang/x86_64/share/../bin 13:40:45 [alainm@login2 rel]#
Is there a way to get access to the compiler for CI purposes? A Docker image or virtual machine would be ideal.
Unfortunately no. That's a big issue as it means that it does not play well with most tools and libraries.
Out of curiosity, what environments is this used for? Is it HPC?
Yes, mostly big clusters like Frontier. Another bad new, since they have few users and no incentive in fixing bugs. Regards
Regards, Ruben.
_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
On Apr 13, 2024, at 4:02 AM, Alain O' Miniussi via Boost <boost@lists.boost.org> wrote:
Hi,
I have to build with cmake on my platform (HPE/Cray compiler does not seems to be recognized by b2). What is the tag associated to RC3?
I have a compiler crash with boost-1.85.0.beta1 and I would like to make sue I'm on the right version.
We don’t tag the PCs, just the releases. You can download the RC3 archives from https://boostorg.jfrog.io/artifactory/main/release/1.85.0/source/ — Marshall
Thanks.
Alain
----- On Apr 12, 2024, at 5:00 PM, Alain O' Miniussi via Boost boost@lists.boost.org wrote:
Hi,
Just checking, but the Cray/llvm based compiler is not part of the toolset right ?
Thanks
----- On Apr 11, 2024, at 11:31 PM, Marshall Clow via Boost boost@lists.boost.org wrote:
The third release candidates for the 1.85.0 release are now available at: <https://boostorg.jfrog.io/artifactory/main/release/1.85.0/source/>
The SHA256 checksums are as follows:
e712fe7eb1b9ec37ac25102525412fb4d74e638996443944025791f48f29408a boost_1_85_0_rc3.zip 7009fe1faa1697476bdc7027703a2badb84e849b7b0baad5086b087b971f8617 boost_1_85_0_rc3.tar.bz2 16d16b9658753117c1434e5450c5eac194957f4b6d0b390b9d07900d37c115a4 boost_1_85_0_rc3.7z be0d91732d5b0cc6fbb275c7939974457e79b54d6f07ce2e3dfdd68bef883b0b boost_1_85_0_rc3.tar.gz
The changes from RC1 are:
* Boost.ASIO docs generate very long file names that are not usable on Windows. * Boost.Program options does not build in C++23 mode on clang truck (to be clang 19 before boost 1.86.0 is released) Note: It is possible that this is a bug in clang, and it’s in a clang that is not released yet. * Boost.Log has some broken links in its documentation. * A meaningless change to Boost.Array (add a space to a test file)
Apparently the RC2 tarballs were mis-buiilt; some of them were missing the required changes. I believe that RC3 resolves that problem.
As always, the release managers would appreciate it if you download the candidate of your choice and give building it a try. Please report both success and failure, and anything else that is noteworthy.
-- The Release managers
_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
I got errors building msvc 14.3 with VS 2022 17.10 (preview). The error is (in tools/build/src/tools/msvc.jam, line 1140) due to not recognizing the runtime library version of msvc which starts with 14.40 (no longer 14.3x, but it's still toolset v143). I made a PR to Boost.Build develop branch which fixes it. https://github.com/boostorg/build/pull/771 Btw: this is also a problem for older Boost releases, which won't build with VS 2022 17.10 or newer. Tobias Am 2024-04-11 23:31, schrieb Marshall Clow via Boost:
The third release candidates for the 1.85.0 release are now available at: <https://boostorg.jfrog.io/artifactory/main/release/1.85.0/source/>
The SHA256 checksums are as follows:
e712fe7eb1b9ec37ac25102525412fb4d74e638996443944025791f48f29408a boost_1_85_0_rc3.zip 7009fe1faa1697476bdc7027703a2badb84e849b7b0baad5086b087b971f8617 boost_1_85_0_rc3.tar.bz2 16d16b9658753117c1434e5450c5eac194957f4b6d0b390b9d07900d37c115a4 boost_1_85_0_rc3.7z be0d91732d5b0cc6fbb275c7939974457e79b54d6f07ce2e3dfdd68bef883b0b boost_1_85_0_rc3.tar.gz
The changes from RC1 are:
* Boost.ASIO docs generate very long file names that are not usable on Windows. * Boost.Program options does not build in C++23 mode on clang truck (to be clang 19 before boost 1.86.0 is released) Note: It is possible that this is a bug in clang, and it’s in a clang that is not released yet. * Boost.Log has some broken links in its documentation. * A meaningless change to Boost.Array (add a space to a test file)
Apparently the RC2 tarballs were mis-buiilt; some of them were missing the required changes. I believe that RC3 resolves that problem.
As always, the release managers would appreciate it if you download the candidate of your choice and give building it a try. Please report both success and failure, and anything else that is noteworthy.
-- The Release managers
_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
Am 2024-04-11 23:31, schrieb Marshall Clow via Boost:
The third release candidates for the 1.85.0 release are now available at: <https://boostorg.jfrog.io/artifactory/main/release/1.85.0/source/>
The SHA256 checksums are as follows:
e712fe7eb1b9ec37ac25102525412fb4d74e638996443944025791f48f29408a boost_1_85_0_rc3.zip 7009fe1faa1697476bdc7027703a2badb84e849b7b0baad5086b087b971f8617 boost_1_85_0_rc3.tar.bz2 16d16b9658753117c1434e5450c5eac194957f4b6d0b390b9d07900d37c115a4 boost_1_85_0_rc3.7z be0d91732d5b0cc6fbb275c7939974457e79b54d6f07ce2e3dfdd68bef883b0b boost_1_85_0_rc3.tar.gz
The changes from RC1 are:
* Boost.ASIO docs generate very long file names that are not usable on Windows. * Boost.Program options does not build in C++23 mode on clang truck (to be clang 19 before boost 1.86.0 is released) Note: It is possible that this is a bug in clang, and it’s in a clang that is not released yet. * Boost.Log has some broken links in its documentation. * A meaningless change to Boost.Array (add a space to a test file)
Apparently the RC2 tarballs were mis-buiilt; some of them were missing the required changes. I believe that RC3 resolves that problem.
As always, the release managers would appreciate it if you download the candidate of your choice and give building it a try. Please report both success and failure, and anything else that is noteworthy.
-- The Release managers
_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost Am 2024-04-13 18:12, schrieb Tobias Loew via Boost: I got errors building msvc 14.3 with VS 2022 17.10 (preview).
The error is (in tools/build/src/tools/msvc.jam, line 1140) due to not recognizing the runtime library version of msvc which starts with 14.40 (no longer 14.3x, but it's still toolset v143). I made a PR to Boost.Build develop branch which fixes it.
https://github.com/boostorg/build/pull/771
Btw: this is also a problem for older Boost releases, which won't build with VS 2022 17.10 or newer.
Tobias
Here are the same changes again to the correct reop: https://github.com/bfgroup/b2/pull/372
participants (10)
-
Alain O' Miniussi -
Andrey Semashev -
Marshall Clow -
Matt Borland -
Peter Dimov -
René Ferdinand Rivera Morell -
Ruben Perez -
tobi＠die-loews.de -
Tom Kent -
Vinnie Falco