tools/regression/run_tests.sh

Straight out of CVS, run_tests.sh has the following on line 88: export BOOST_BUILD_PATH="$boost_build_path" "$BOOST_BUILD_PATH" which, of course, generates an error. Does anyone know the intent of this line? I can think of two obvious possibilities... 1. Prepend $boost_build_path to BOOST_BUILD_PATH, in which case it should be something like: if [ "${BOOST_BUILD_PATH}" ]; then BOOST_BUILD_PATH="$boost_build_path:$BOOST_BUILD_PATH" else BOOST_BUILD_PATH="$boost_build_path" fi which is a bit verbose, but probably necessary for max /bin/sh portability. 2. Just set it to boost_build_path: BOOST_BUILD_PATH="$boost_build_path" However, there could be some other intent, so I am not sure how I want to fix this. Anyone know? Thanks! -- Jody Hagins

Jody Hagins wrote:
Straight out of CVS, run_tests.sh has the following on line 88:
export BOOST_BUILD_PATH="$boost_build_path" "$BOOST_BUILD_PATH"
which, of course, generates an error. Does anyone know the intent of this line? I can think of two obvious possibilities...
1. Prepend $boost_build_path to BOOST_BUILD_PATH, in which case it should be something like: if [ "${BOOST_BUILD_PATH}" ]; then BOOST_BUILD_PATH="$boost_build_path:$BOOST_BUILD_PATH" else BOOST_BUILD_PATH="$boost_build_path" fi which is a bit verbose, but probably necessary for max /bin/sh portability.
That's the intent. -- -- Grafik - Don't Assume Anything -- Redshift Software, Inc. - http://redshift-software.com -- rrivera/acm.org - grafik/redshift-software.com - 102708583/icq

On Wed, 14 Apr 2004 10:05:33 -0500 Rene Rivera <grafik.list@redshift-software.com> wrote:
1. Prepend $boost_build_path to BOOST_BUILD_PATH, in which case it should be something like: if [ "${BOOST_BUILD_PATH}" ]; then BOOST_BUILD_PATH="$boost_build_path:$BOOST_BUILD_PATH" else BOOST_BUILD_PATH="$boost_build_path" fi which is a bit verbose, but probably necessary for max /bin/sh portability.
That's the intent.
Thanks, Rene! I will make the change locally, so I can run the regression tests. Can you make the change to CVS? -- Jody Hagins

On Wed, 14 Apr 2004 11:19:50 -0400 Jody Hagins <jody-boost-011304@atdesk.com> wrote:
Thanks, Rene! I will make the change locally, so I can run the regression tests. Can you make the change to CVS?
... and do not forget to export it, as I did in the example: if [ "${BOOST_BUILD_PATH}" ]; then BOOST_BUILD_PATH="$boost_build_path:$BOOST_BUILD_PATH" else BOOST_BUILD_PATH="$boost_build_path" fi export BOOST_BUILD_PATH

Jody Hagins wrote:
On Wed, 14 Apr 2004 11:19:50 -0400 Jody Hagins <jody-boost-011304@atdesk.com> wrote:
Thanks, Rene! I will make the change locally, so I can run the regression tests. Can you make the change to CVS?
... and do not forget to export it, as I did in the example:
OK, fixed in CVS.. And also I used "test" instead of "[" as it's more portable. -- -- Grafik - Don't Assume Anything -- Redshift Software, Inc. - http://redshift-software.com -- rrivera/acm.org - grafik/redshift-software.com - 102708583/icq
participants (2)
-
Jody Hagins
-
Rene Rivera