On Wed, 20 May 2009, Eric Niebler wrote:

Jeremiah Willcock wrote:

...

Since tabs in source files and min/max guideline violations are so easy to correct, is it OK if I just fix them in all libraries (except for the inspection tool's examples)? I will not do any that appear to be intentional or that would change the meaning of the code. Do I have permission to do that and just commit the changes?

That's fine by me. And let me also say: thanks!

I've done most of these. I also filed a bug about the inspect tool reporting min/max problems in comments; strings might also need to be skipped although I put extra quotes in the one example that had that issue. There were two files that had tabs that might or might not have been intentional (they were in test data strings): libs/property_tree/test/test_json_parser.cpp: *Tab* libs/property_tree/test/xml_parser_test_data.hpp: *Tab*</pre> Should I change those tabs to spaces as well, or replace them with \t, or something else? -- Jeremiah Willcock

On Wed, 20 May 2009, Steven Watanabe wrote:

AMDG

Jeremiah Willcock wrote:

...

On Wed, 20 May 2009, Eric Niebler wrote:

...

Jeremiah Willcock wrote:

...

Since tabs in source files and min/max guideline violations are so easy to correct, is it OK if I just fix them in all libraries (except for the inspection tool's examples)? I will not do any that appear to be intentional or that would change the meaning of the code. Do I have permission to do that and just commit the changes?

That's fine by me. And let me also say: thanks!

I've done most of these. I also filed a bug about the inspect tool reporting min/max problems in comments; strings might also need to be skipped although I put extra quotes in the one example that had that issue.

I just changed the regex to filter out all comments and strings.

Thank you. That fixes all of the issues in the trunk, except boost/property_tree/detail/pugxml.hpp (which I assume is third-party code) and the two files I mentioned earlier that might have intentional tabs: libs/property_tree/test/test_json_parser.cpp: *Tab* libs/property_tree/test/xml_parser_test_data.hpp: *Tab* -- Jeremiah Willcock

Could you have another look? I'm suddenly struggling to build the release branch.

https://svn.boost.org/trac/boost/changeset/53142#file43

That's not a tabs-and-spaces diff...

Sorry about that. I must have had other changes in my checkout. I reverted all of the non-tabs-and-spaces ones, other than some BGL changes (that also were committed by mistake) that fix previously reported bugs. -- Jeremiah Willcock

AMDG Jeremiah Willcock wrote:

...

I just changed the regex to filter out all comments and strings.

Would that patch be worth putting into the release branch as well?

The release branch and the trunk should stay somewhat in sync. I added it to my list of changes to merge when the tests cycle. Oh wait... inspect isn't covered by the regression tests. I'll merge in a little while. In Christ, Steven Watanabe

AMDG troy d. straszheim wrote:

I've been wondering a bit about this in-syncness recently.

- Does anybody know offhand what the last release was that was branched directly from trunk?

- Is there a way to determine, with SVN, how many lines of diff there are between trunk and release? I've tried without success.... the diff gets to ~80k lines and then the network times out. I wonder if I'm doing something wrong. Of course I can get some numbers with git but I'm not quite sure I trust them yet.

% git diff --shortstat svn/release svn/master 3505 files changed, 209061 insertions(+), 58428 deletions(-)

This is probably correct as far as it goes. However, it's hard to tell how much it really means. About half the modified files seem to be generated html, judging by the output of svn diff https://svn.boost.org/svn/boost/branches/release https://svn.boost.org/svn/boost/trunk --summarize In Christ, Steven Watanabe