[range] Merge to fix defects
Boosters, I have had a commit on the trunk to resolve some defects that I noticed by carefully reviewing all of my new code. There is one serious defect in the istream_range which on the release branch is useless. Of course, this is merely a lack of a new feature rather than a regression but I would like to have it working for the proper release. There are also some changes to return types to address the concern brought up in the review about inconsistent return types of various functions. Both of these fixes have been tested on the trunk for many days. I recently reverted a host of other changes on the trunk that are unrelated to these issues that would increase risk. The recently reduced changeset on the trunk is also passing regression tests. Thanks in anticipation, Neil Groves
On 4/23/2010 12:21 AM, Neil Groves wrote:
Boosters,
I have had a commit on the trunk to resolve some defects that I noticed by carefully reviewing all of my new code.
There is one serious defect in the istream_range which on the release branch is useless. Of course, this is merely a lack of a new feature rather than a regression but I would like to have it working for the proper release.
There are also some changes to return types to address the concern brought up in the review about inconsistent return types of various functions.
Both of these fixes have been tested on the trunk for many days. I recently reverted a host of other changes on the trunk that are unrelated to these issues that would increase risk. The recently reduced changeset on the trunk is also passing regression tests.
Can you provide a list of changesets that you intend to merge? -- Eric Niebler BoostPro Computing http://www.boostpro.com
Can you provide a list of changesets that you intend to merge?
I feel that these changesets really must be merged: 61345 - corrected the very broken istream_range and added the missing test 61378 - add the missing include for the strided adaptor I actually would prefer to also include 61404 61435 61495 The above three changesets combine to fix the inconsistency of the return types in the new range algorithms. The changesets are much larger than the final delta since I made some combined changes to the trunk that I tested as a set and then removed many of those changes. I appreciate that this makes reviewing the changeset difficult and for this I apologize. I also prefer to merge the total combination of the changesets since it is this combination that has been tested the last few days by the regression tests. I am very confident in the result of all of the changesets and would like to emphasise that the changes are to files that are not used as a dependency in the rest of Boost code as of version 1.43. I also appreciate that code churn at this stage is not at all desirable and that had I been a bit quicker I would have been merged earlier. Whatever your decision, I will happily accomodate.
-- Eric Niebler BoostPro Computing http://www.boostpro.com
Thanks, Neil Groves
On 4/23/2010 12:29 PM, Neil Groves wrote:
Can you provide a list of changesets that you intend to merge?
I feel that these changesets really must be merged:
<snip> OK. Please merge to release *exactly* what has been tested on trunk. Before you commit, please locally run the tests of those libraries that depend on Boost.Range (accumulators, algorithm, assign, foreach, graph, ptr_container, range, spirit, xpressive) on at least 2 different compilers and verify that you introduce no new failures. Please do this as soon as possible. Beman, Daniel, Vladimir: speak now if you disagree with the resolution of this issue. -- Eric Niebler BoostPro Computing http://www.boostpro.com
participants (2)
-
Eric Niebler -
Neil Groves