[mpl] patch for non-typeof map::insert
AMDG mpl::map insert can fail after an erase, because it uses size instead of order to determine the next order. The patch https://svn.boost.org/trac/boost/attachment/ticket/2042/insert_impl.hpp.patc... fixes this. Okay to commit? In Christ, Steven Watanabe
Steven Watanabe wrote:
AMDG
mpl::map insert can fail after an erase, because it uses size instead of order to determine the next order. The patch https://svn.boost.org/trac/boost/attachment/ticket/2042/insert_impl.hpp.patc...
fixes this.
Okay to commit?
Commit to trunk first and wait for tests to cycle. If you've done that already and the tests look good, then yes. -- Eric Niebler BoostPro Computing http://www.boostpro.com
On Sat, 22 Aug 2009 14:44:03 -0500, Eric Niebler <eric@boostpro.com> wrote:
Steven Watanabe wrote:
AMDG mpl::map insert can fail after an erase, because it uses size instead of order to determine the next order. The patch https://svn.boost.org/trac/boost/attachment/ticket/2042/insert_impl.hpp.patc... fixes this. Okay to commit?
Commit to trunk first and wait for tests to cycle. If you've done that already and the tests look good, then yes.
I've just merged this to the release branch. -- Aleksey Gurtovoy MetaCommunications Engineering
Hi Steven,
mpl::map insert can fail after an erase, because it uses size instead of order to determine the next order. The patch https://svn.boost.org/trac/boost/attachment/ticket/2042/insert_impl.hpp.patc... fixes this.
Okay to commit?
Please go ahead. If you could also add your test case from the ticket to map tests, it'd be extra appreciated :). TIA, -- Aleksey Gurtovoy MetaCommunications Engineering
participants (3)
-
Aleksey Gurtovoy -
Eric Niebler -
Steven Watanabe