[Range] Are pull request in github being considered?

Gonzalo BG

20 Mar 2014 20 Mar '14

6:29 p.m.

There are 3 pull-request in github with zero comments, none closed, and the oldest is 3 months old (one is from me). Are they being considered or should one submit patches for Boost.Range over trac? The FAQ doesn't say anything about the preferred way to submit patches and the modular boost documentation mentions pull-request as valid options, but I would like to be sure that I sent my patch through the preferred channel. Bests, Gonzalo BG

Show replies by date

Neil Groves

20 Mar 20 Mar

6:36 p.m.

On 20 Mar 2014, at 18:29, Gonzalo BG wrote:

...

There are 3 pull-request in github with zero comments, none closed, and the oldest is 3 months old (one is from me).

I’ve not had notification of pull requests. This is possibly due to my omission to register with something.

...

Are they being considered or should one submit patches for Boost.Range over trac?

Practically, I’m monitoring trac and tackling the issues reported there.

...

The FAQ doesn't say anything about the preferred way to submit patches and the modular boost documentation mentions pull-request as valid options, but I would like to be sure that I sent my patch through the preferred channel.

I’m finding the transition difficult too. It’s not always obvious which procedure to follow. However if you get me the info I’ll attempt to make some progress.

...

Bests, Gonzalo BG

Thanks, Neil Groves

Gonzalo Brito Gadeschi

6:56 p.m.

...

I've not had notification of pull requests. This is possibly due to my omission to register with something.

If you are an owner of the repository you should get notified automatically. Otherwise you can (in GitHub) configure the information that you recieve (see "follow repository" for more details).

...

Practically, I'm monitoring trac and tackling the issues reported there.

I'll report the bug and submit the patch through trac then (but there will be still two pull requests open in github). IMO contributing patches should be as easy as possible and there should be easily reachable step-by-step documentation about the process. On Thursday, March 20, 2014, Neil Groves wrote:

...

On 20 Mar 2014, at 18:29, Gonzalo BG javascript:;> wrote:

...
There are 3 pull-request in github with zero comments, none closed, and the oldest is 3 months old (one is from me).

I've not had notification of pull requests. This is possibly due to my omission to register with something.

...
Are they being considered or should one submit patches for Boost.Range over trac?

Practically, I'm monitoring trac and tackling the issues reported there.

...
The FAQ doesn't say anything about the preferred way to submit patches and the modular boost documentation mentions pull-request as valid options, but I would like to be sure that I sent my patch through the preferred channel.

I'm finding the transition difficult too. It's not always obvious which procedure to follow. However if you get me the info I'll attempt to make some progress.

...
Bests, Gonzalo BG

Thanks, Neil Groves

_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost

-- Dipl.-Ing. Gonzalo Brito Gadeschi Institute of Aerodynamics and Chair of Fluid Mechanics RWTH Aachen University Wuellnerstraße 5a D-52062 Aachen Germany Phone: ++49-(0)241-80-94821 Fax: ++49-(0)241-80-92257 E-mail: g.brito@aia.rwth-aachen.de Internet: www.aia.rwth-aachen.de

Gonzalo BG

7:21 p.m.

...

I've not had notification of pull requests. This is possibly due to my omission to register with something. [...] However if you get me the info I'll attempt to make some progress.

See: https://help.github.com/articles/notifications In a nutshell, you need to "follow" the repository . There you can configure which information you get (you will get emails for pull-requests, comments, issues, ..., you can configure how many emails you get, etc...). I can submit a bug report and the patch to trac, but that won't do anything about the other two pull-requests. If your project is on github people expect to be able to send issues and pull requests (as the modular boost documentation acknowledges/recommends). Having two systems for tracking issues and submitting patches is confusing and more work for both contributors and library maintainers (you need to search for the bug in two places / you need two check two places for bug-reports and patches). Maybe one should start the discussion about the way to go in this respect. Anyhow if you prefer me to send the patch through trac or need more help with github I am willing to help.

3841

Age (days ago)

3841

Last active (days ago)

List overview

Download

3 comments

3 participants

participants (3)

Gonzalo BG
Gonzalo Brito Gadeschi
Neil Groves