[library_status] Small patch.
Hello, attached patch fixes the following problems encountered when compiling library_status.cpp on Tru64/CXX: 1) Fix the definition of subcolumns_t, the key type of std::map must be assignable, hence const string is not a valid key type. 2) Make empty_element static, as find_element() returns a reference to it. 3) Swap static and const in the declaration of empty_string to avoid a compiler warning. Could anybody please be so kind and apply the patch? Thanks, Markus Index: boost/tools/regression/library_status.cpp =================================================================== --- boost/tools/regression/library_status.cpp (revision 39207) +++ boost/tools/regression/library_status.cpp (working copy) @@ -89,7 +89,7 @@ struct col_node { int rows, cols; bool is_leaf_directory; - typedef std::map<const std::string, col_node> subcolumns_t; + typedef std::map<std::string, col_node> subcolumns_t; subcolumns_t m_subcolumns; bool operator<(const col_node &cn) const; col_node() : @@ -222,7 +222,7 @@ const xml::element & find_element( const xml::element & root, const string & name ) { - const xml::element empty_element; + static const xml::element empty_element; xml::element_list::const_iterator itr; for ( itr = root.elements.begin(); itr != root.elements.end() && (*itr)->name != name; @@ -245,7 +245,7 @@ if(atr->name == attribute_name) return atr->value; } - const static string empty_string; + static const string empty_string; return empty_string; }
I'll do this. Robert Ramey Markus Schöpflin wrote:
Hello,
attached patch fixes the following problems encountered when compiling library_status.cpp on Tru64/CXX:
1) Fix the definition of subcolumns_t, the key type of std::map must be assignable, hence const string is not a valid key type.
2) Make empty_element static, as find_element() returns a reference to it.
3) Swap static and const in the declaration of empty_string to avoid a compiler warning.
Could anybody please be so kind and apply the patch?
Thanks, Markus
Index: boost/tools/regression/library_status.cpp =================================================================== --- boost/tools/regression/library_status.cpp (revision 39207) +++ boost/tools/regression/library_status.cpp (working copy) @@ -89,7 +89,7 @@ struct col_node { int rows, cols; bool is_leaf_directory; - typedef std::map<const std::string, col_node> subcolumns_t; + typedef std::map<std::string, col_node> subcolumns_t; subcolumns_t m_subcolumns; bool operator<(const col_node &cn) const; col_node() : @@ -222,7 +222,7 @@ const xml::element & find_element( const xml::element & root, const string & name ) { - const xml::element empty_element; + static const xml::element empty_element; xml::element_list::const_iterator itr; for ( itr = root.elements.begin(); itr != root.elements.end() && (*itr)->name != name; @@ -245,7 +245,7 @@ if(atr->name == attribute_name) return atr->value; } - const static string empty_string; + static const string empty_string; return empty_string; }
_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
I've still been unable to check anything into the repository. I did ask about this but so far haven't recieved any response. Robert Ramey Markus Schöpflin wrote:
Robert Ramey wrote:
I'll do this.
Thank you.
Markus
_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
Robert Ramey wrote:
I've still been unable to check anything into the repository. I did ask about this but so far haven't recieved any response.
Currently I'm applying the patch locally before the regression test runs, just holler when you (or someone else) applied the patch, so I can remove the local patching. Thank you, Markus
on Thu Sep 13 2007, "Robert Ramey" <ramey-AT-rrsd.com> wrote:
I've still been unable to check anything into the repository. I did ask about this but so far haven't recieved any response.
Who did you ask and what did you ask them? -- Dave Abrahams Boost Consulting http://www.boost-consulting.com The Astoria Seminar ==> http://www.astoriaseminar.com
http://lists.boost.org/Archives/boost/2007/09/127234.php David Abrahams wrote:
on Thu Sep 13 2007, "Robert Ramey" <ramey-AT-rrsd.com> wrote:
I've still been unable to check anything into the repository. I did ask about this but so far haven't recieved any response.
Who did you ask and what did you ask them?
On Fri, 2007-09-21 at 11:57 -0700, Robert Ramey wrote:
It's one of two things: - You don't have MIME types and EOL styles set appropriately (see http://svn.boost.org/trac/boost/wiki/BoostSubversion), or - You tried to commit with an empty comment. This is a weird Subversion client issue... most versions of the Subversion client give you an appropriate error message, some versions do not. We don't currently know the fix. - Doug
participants (4)
-
David Abrahams -
Douglas Gregor -
Markus Schöpflin -
Robert Ramey