[fusion/range] rev 40506 broke xpressive
Hello, this checkin: ------------------------------------------------------------------------ r40506 | nesotto | 2007-10-27 15:57:20 +0000 (Sat, 27 Oct 2007) | 1 line Changed paths: D /trunk/boost/range/const_reverse_iterator.hpp M /trunk/boost/range/metafunctions.hpp D /trunk/boost/range/result_iterator.hpp D /trunk/boost/range/reverse_result_iterator.hpp cleaned up deprecated headers ------------------------------------------------------------------------ is the cause for this errors seen in xpressive: cxx: Severe: ../../../boost/xpressive/detail/utility/symbols.hpp, line 24: could not open source file "boost/range/result_iterator.hpp" (srcfilnoopen) #include <boost/range/result_iterator.hpp> ------------------------------------------^ Probably xpressive needs an update? Regards, Markus
Markus Schöpflin skrev:
Hello,
this checkin:
------------------------------------------------------------------------ r40506 | nesotto | 2007-10-27 15:57:20 +0000 (Sat, 27 Oct 2007) | 1 line Changed paths: D /trunk/boost/range/const_reverse_iterator.hpp M /trunk/boost/range/metafunctions.hpp D /trunk/boost/range/result_iterator.hpp D /trunk/boost/range/reverse_result_iterator.hpp
cleaned up deprecated headers ------------------------------------------------------------------------
is the cause for this errors seen in xpressive:
cxx: Severe: ../../../boost/xpressive/detail/utility/symbols.hpp, line 24: could not open source file "boost/range/result_iterator.hpp" (srcfilnoopen) #include <boost/range/result_iterator.hpp> ------------------------------------------^
It should include iterator.hpp. I can fix the header, if I may. -Thorsten
Thorsten Ottosen wrote:
Markus Schöpflin skrev:
Hello,
this checkin:
------------------------------------------------------------------------ r40506 | nesotto | 2007-10-27 15:57:20 +0000 (Sat, 27 Oct 2007) | 1 line Changed paths: D /trunk/boost/range/const_reverse_iterator.hpp M /trunk/boost/range/metafunctions.hpp D /trunk/boost/range/result_iterator.hpp D /trunk/boost/range/reverse_result_iterator.hpp
cleaned up deprecated headers ------------------------------------------------------------------------
is the cause for this errors seen in xpressive:
cxx: Severe: ../../../boost/xpressive/detail/utility/symbols.hpp, line 24: could not open source file "boost/range/result_iterator.hpp" (srcfilnoopen) #include <boost/range/result_iterator.hpp> ------------------------------------------^
It should include iterator.hpp. I can fix the header, if I may.
I don't think you should have removed the deprecated stuff so soon. Could you leave it in for 1 release to give people time to adjust? It really can't hurt in this case. FWIW, I used range_iterator on purpose because I want xpressive to work with Boost 1.34 also. -- Eric Niebler Boost Consulting www.boost-consulting.com
Eric Niebler skrev:
Thorsten Ottosen wrote:
Markus Schöpflin skrev:
Hello,
this checkin:
------------------------------------------------------------------------ r40506 | nesotto | 2007-10-27 15:57:20 +0000 (Sat, 27 Oct 2007) | 1 line Changed paths: D /trunk/boost/range/const_reverse_iterator.hpp M /trunk/boost/range/metafunctions.hpp D /trunk/boost/range/result_iterator.hpp D /trunk/boost/range/reverse_result_iterator.hpp
cleaned up deprecated headers ------------------------------------------------------------------------
is the cause for this errors seen in xpressive:
cxx: Severe: ../../../boost/xpressive/detail/utility/symbols.hpp, line 24: could not open source file "boost/range/result_iterator.hpp" (srcfilnoopen) #include <boost/range/result_iterator.hpp> ------------------------------------------^ It should include iterator.hpp. I can fix the header, if I may.
I don't think you should have removed the deprecated stuff so soon. Could you leave it in for 1 release to give people time to adjust? It really can't hurt in this case.
FWIW, I used range_iterator on purpose because I want xpressive to work with Boost 1.34 also.
I guess you're right, but is it not true that the code will often not compile since the function names have changed.? Anyway, if people agree, I don't mind keeping the three headers above. -Thorsten
Thorsten Ottosen wrote:
I guess you're right, but is it not true that the code will often not compile since the function names have changed.?
Anyway, if people agree, I don't mind keeping the three headers above.
Do peole agree with Eric?
What I'm doing with Boost.System and Boost.Filesystem is provide existing names as deprecated synonyms, wrapped in an #ifdef. For example: # ifndef BOOST_SYSTEM_NO_DEPRECATED // deprecated synonyms static const error_category & errno_ecat = get_posix_category(); static const error_category & native_ecat = get_system_category(); # endif That allows current code to keep working, but puts users on notice these synonyms will go away. I'm not familiar enough with the range case to know for sure, but if it doesn't hurt anything, why not protect the existing code and allow a transition period? --Beman
Beman Dawes skrev:
Thorsten Ottosen wrote:
I guess you're right, but is it not true that the code will often not compile since the function names have changed.?
Anyway, if people agree, I don't mind keeping the three headers above.
Do peole agree with Eric?
What I'm doing with Boost.System and Boost.Filesystem is provide existing names as deprecated synonyms, wrapped in an #ifdef. For example:
# ifndef BOOST_SYSTEM_NO_DEPRECATED // deprecated synonyms static const error_category & errno_ecat = get_posix_category(); static const error_category & native_ecat = get_system_category(); # endif
That allows current code to keep working, but puts users on notice these synonyms will go away.
I'm not familiar enough with the range case to know for sure, but if it doesn't hurt anything, why not protect the existing code and allow a transition period?
I've added the headers again. -Thorsten
participants (5)
-
Beman Dawes -
Eric Niebler -
Markus Schöpflin -
shunsuke -
Thorsten Ottosen