Le 06/02/13 18:03, Paul A. Bristow a écrit :

...

-----Original Message----- From: Boost [mailto:boost-bounces@lists.boost.org] On Behalf Of Marshall Clow Sent: Wednesday, February 06, 2013 2:54 PM To: boost@lists.boost.org List Subject: [boost] Tests failing?

A bunch of my (String.Algo and Boost.Algo) tests are failing locally, with errors like:

darwin.compile.c++ ../../../bin.v2/libs/test/build/darwin-4.2.1/debug/link-static/test_main.o In file included from ../../../libs/test/src/test_main.cpp:16: ../../../boost/test/impl/test_main.ipp: In member function 'void test_main_caller::operator()()': ../../../boost/test/impl/test_main.ipp:39: error: 'BOOST_CHECK' was not declared in this scope "g++" -ftemplate-depth-128 -O0 -fno-inline -Wall -pedantic -g -gdwarf-2 -fexceptions - DBOOST_ALL_NO_LIB=1 -I"../../.." -c -o "../../../bin.v2/libs/test/build/darwin-4.2.1/debug/link- static/test_main.o" "../../../libs/test/src/test_main.cpp"

...failed darwin.compile.c++ ../../../bin.v2/libs/test/build/darwin-4.2.1/debug/link- static/test_main.o...

Before I dive into this - is anyone else seeing this?

Looking at the test results on the web site, it appears that Boost.Test is broken for several libraries. For example: http://www.boost.org/development/tests/trunk/developer/algorithm.html http://www.boost.org/development/tests/trunk/developer/crc.html http://www.boost.org/development/tests/trunk/developer/geometry.html

Boost.Math tests using test are failing on many testers (I think all *nix systems?)

The same for Boost.Test, and the problem appears also on windows testers http://www.boost.org/development/tests/trunk/developer/thread.html Vicente

-----Original Message----- From: Boost [mailto:boost-bounces@lists.boost.org] On Behalf Of Marshall Clow Sent: Wednesday, February 06, 2013 8:25 PM To: boost@lists.boost.org Subject: Re: [boost] Tests failing?

On Feb 6, 2013, at 12:18 PM, Gennadiy Rozental <rogeeff@gmail.com> wrote:

<snip>

...

I'll fix this, but test_execution_monitor is deprecated 5+ years ago. It's not being tested anymore. If you like I can switch all your unit tests to UTF (couple lines of code change).

I appreciate the offer, but if you can point me at the docs describing how I should switch, I'll clean up my code.

Well perhaps we need to do this for Boost.Math - where there are perhaps a *thousand* tests in nearly a *hundred* files. Please can we have some detailed help on how to tackle what appears to be a massive job. Paul --- Paul A. Bristow, Prizet Farmhouse, Kendal LA8 8AB UK +44 1539 561830 07714330204 pbristow@hetp.u-net.com

John Maddock <boost.regex <at> virgin.net> writes:

Not only that but there are many unmaintained libraries with the same issue (a quick grep would confirm this), not only would each have to be switched over, but you would also have to verify nothing has been broken in each case, and manage the merging of all those libraries to release as well. Preferably without upsetting anyone

I think I still prefer these to be cleaned up.

Frankly it's way easier to provide a backwards compatible-layer for the test-exec-monitor.

There is one, but it is not being actively tested, so some issues may creep up. Gennadiy

On 13-02-07 11:44 PM, Gennadiy Rozental wrote:

Paul A. Bristow <pbristow <at> hetp.u-net.com> writes:

...

Please can we have some detailed help on how to tackle what appears to be a massive job.

I looked into this tonight and this is done.

Hi Gennadiy, There are a lot of tests broken on trunk because of this change. Grepping through Jamfiles under libs/, I find 75 references to boost_test_exec_monitor. Can you clean this up, or restore the broken functionality please? Eric

On 13-02-19 01:53 AM, Gennadiy Rozental wrote:

Eric Niebler <eric <at> boostpro.com> writes:

...

There are a lot of tests broken on trunk because of this change. Grepping through Jamfiles under libs/, I find 75 references to boost_test_exec_monitor. Can you clean this up, or restore the broken functionality please?

This should be fixed now, but guys lets spend 5 minutes and change to use unit test framework. It's really just few line of code that needs to be changed.

Sadly, many boost libraries aren't actively maintained. If you really want to evolve your library in a non-backward-compatible way (and I don't dispute your right to do that, or begrudge you for it), then you should to have a plan for what to do with those libraries. You may have to make the necessary changes yourself. -- Eric Niebler Boost.org

Marshall Clow <mclow.lists <at> gmail.com> writes:

I appreciate the offer, but if you can point me at the docs describing how I should switch, I'll clean up my code.

I believe I've described it once somewhere. What you need is: 1. Replace #include <boost/test/test_exec_monitor.hpp> with #define BOOST_TEST_MAIN #include <boost/test/test_exec_monitor.hpp> 2. Replace int test_main( int, char*[] ) with BOOST_AUTO_TEST_CASE( test_main ) 3. Delete return 0; statement at the end of test_main 4. Fix Jamfile by replacing boost_test_exec_monitor with boost_unit_test_framework Most of these can be dome by massive "Search/Replace" command. Gennadiy

Marshall Clow <mclow.lists <at> gmail.com> writes:

...

1. Replace

#include <boost/test/test_exec_monitor.hpp>

with

#define BOOST_TEST_MAIN #include <boost/test/test_exec_monitor.hpp>

Are you sure?

Oops. Sorry. Typo. It should be #include <boost/test/unit_test.hpp>

I tried that, and it didn't work at all.

I looked at the documentation, and it showed:

#define BOOST_TEST_MODULE MyTest #define BOOST_TEST_MAIN #include <boost/test/unit_test.hpp>

Is that correct?

You do not need both BOOST_TEST_MAIN and BOOST_TEST_MODULE. Keep later , since it allows to name your test module's master test suite, but using just BOOST_TEST_MAIN allows to build and run as well. Gennadiy