Re: [boost] Some patches to remove obsolete MSVC version checks
On 09/13/2013 01:35 PM, Stephen Kelly wrote:
Hi,
I've attached patches to remove or simplify some ifdefs for MSVC versions which are now obsolete.
This is a followup to this thread:
http://thread.gmane.org/gmane.comp.lib.boost.devel/243094 (Removing old config macro and increasing compiler requirements., 2013-07-29)
The patches are most easily applied locally and reviewed with a git-svn checkout and git am.
I'll also apply to get SVN access so I can commit patches myself.
FYI, I've started cherry-picking, re-reviewing and committing these patches. I'll keep the patches small and single-issue. I would appreciate post-commit review from anyone for any of them, as some of the ifdef chains are complex. Thanks, Steve.
Hello Steve, On September 25, 2013 10:30:04 AM Stephen Kelly wrote:
I'll keep the patches small and single-issue. I would appreciate post-commit review from anyone for any of them, as some of the ifdef chains are complex.
So my Jenkins continuous integration build failed today at Revision: 85920 which was a bunch of your changes. The log is full of: gcc.compile.c++ bin.v2/libs/log/build/gcc-4.8/release/link-static/log-api- unix/threading-multi/filter_parser.o In file included from ./boost/proto/detail/decltype.hpp:32:0, from ./boost/proto/transform/default.hpp:30, from ./boost/phoenix/core/meta_grammar.hpp:17, from ./boost/phoenix/core/is_nullary.hpp:15, from ./boost/phoenix/core/actor.hpp:19, from ./boost/phoenix/core.hpp:15, from libs/log/src/filter_parser.cpp:31: ./boost/typeof/typeof.hpp:208:2: error: #endif without #if #endif//BOOST_TYPEOF_TYPEOF_HPP_INCLUDED ^ Can you take a look? Thanks, -Steve
On 09/26/2013 04:00 AM, Steve M. Robbins wrote:
Hello Steve,
On September 25, 2013 10:30:04 AM Stephen Kelly wrote:
I'll keep the patches small and single-issue. I would appreciate post-commit review from anyone for any of them, as some of the ifdef chains are complex. So my Jenkins continuous integration build failed today at Revision: 85920 which was a bunch of your changes. The log is full of:
gcc.compile.c++ bin.v2/libs/log/build/gcc-4.8/release/link-static/log-api- unix/threading-multi/filter_parser.o In file included from ./boost/proto/detail/decltype.hpp:32:0, from ./boost/proto/transform/default.hpp:30, from ./boost/phoenix/core/meta_grammar.hpp:17, from ./boost/phoenix/core/is_nullary.hpp:15, from ./boost/phoenix/core/actor.hpp:19, from ./boost/phoenix/core.hpp:15, from libs/log/src/filter_parser.cpp:31: ./boost/typeof/typeof.hpp:208:2: error: #endif without #if #endif//BOOST_TYPEOF_TYPEOF_HPP_INCLUDED ^
Can you take a look?
Hi Steve, This is probably fixed by revision 85925. Can you confirm? Thanks, Steve.
participants (2)
-
Stephen Kelly -
Steve M. Robbins