Geometry path length breaking windows regression runs
There has been a change to the geometry library, sometime around Nov 14, that is causing the windows regression runners I manage to crash. The issue is that it is creating *very* long filesystem paths, even with the regression --abbreviate-paths option set. There are a bunch of files such as: D:\teeks99-08\run\results\boost\bin.v2\libs\geometry\test\self_contained_headers\self-contained-algorithms-detail-buffer-buffered_piece_collection~hpp.test\msvc-14.1\dbg\adrs-mdl-64\async-excpt-on\thrd-mlt\self-contained-algorithms-detail-buffer-buffered_piece_collection~hpp.obj.rsp That seem to be created alright, but when I try to cleanup the run afterwards, windows doesn't allow me to delete the files. Tom
Hi Tom, Tom Kent Via Boost wrote:
There has been a change to the geometry library, sometime around Nov 14, that is causing the windows regression runners I manage to crash. The issue is that it is creating *very* long filesystem paths, even with the regression --abbreviate-paths option set.
There are a bunch of files such as: D:\teeks99-08\run\results\boost\bin.v2\libs\geometry\test\self_contained_headers\self-contained-algorithms-detail-buffer-buffered_piece_collection~hpp.test\msvc-14.1\dbg\adrs-mdl-64\async-excpt-on\thrd-mlt\self-contained-algorithms-detail-buffer-buffered_piece_collection~hpp.obj.rsp
That seem to be created alright, but when I try to cleanup the run afterwards, windows doesn't allow me to delete the files.
This was an attempt to test the library WRT violation of Boost headers policy. In particular: "Make sure that a translation unit consisting of just the contents of the header file will compile successfully". We noticed that they're causing trouble and they are no longer run by default. This is the commit disabling the tests: https://github.com/boostorg/geometry/commit/b432f28d9469903d2a8019db5a4c9036... which AFAIU corresponds to this Boost commit: https://github.com/boostorg/boost/commit/f8d41ca2c09c3f773b1efeb7e87c205fad9... which should be safe for testing. Sorry for inconvenience. If you require some additional help please let me know. Adam
On Fri, 23 Nov 2018 at 03:21, Adam Wulkiewicz via Boost-Testing
Tom Kent Via Boost wrote:
There has been a change to the geometry library, sometime around Nov 14, that is causing the windows regression runners I manage to crash. The issue is that it is creating *very* long filesystem paths, even with the regression --abbreviate-paths option set.
There are a bunch of files such as: D:\teeks99-08\run\results\boost\bin.v2\libs\geometry\test\self_contained_headers\self-contained-algorithms-detail-buffer-buffered_piece_collection~hpp.test\msvc-14.1\dbg\adrs-mdl-64\async-excpt-on\thrd-mlt\self-contained-algorithms-detail-buffer-buffered_piece_collection~hpp.obj.rsp
That seem to be created alright, but when I try to cleanup the run afterwards, windows doesn't allow me to delete the files.
This was an attempt to test the library WRT violation of Boost headers policy. In particular: "Make sure that a translation unit consisting of just the contents of the header file will compile successfully". We noticed that they're causing trouble and they are no longer run by default.
This is the commit disabling the tests:
https://github.com/boostorg/geometry/commit/b432f28d9469903d2a8019db5a4c9036...
Tom, this was my fault, sorry for inconvenience. I unintentionally ignored the regression runners, remembering only about the CI services (with CI env variable set). As Adam explained, it's been fixed now. Best regards -- Mateusz Loskot, http://mateusz.loskot.net
On Fri, 23 Nov 2018 at 03:45, Tom Kent via Boost
That seem to be created alright, but when I try to cleanup the run afterwards, windows doesn't allow me to delete the files.
On Win10 you can remove the 260 char path-limit: ------------------------------------------------------------------------------------------------------ Windows Registry Editor Version 5.00 [HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\FileSystem] "LongPathsEnabled"=dword:00000001 ------------------------------------------------------------------------------------------------------ Save the above as a .reg file and right click -> merge -> ok. degski -- *“If something cannot go on forever, it will stop" - Herbert Stein*
On 11/23/18 4:39 AM, Tom Kent via Boost wrote:
There has been a change to the geometry library, sometime around Nov 14, that is causing the windows regression runners I manage to crash. The issue is that it is creating *very* long filesystem paths, even with the regression --abbreviate-paths option set.
There are a bunch of files such as: D:\teeks99-08\run\results\boost\bin.v2\libs\geometry\test\self_contained_headers\self-contained-algorithms-detail-buffer-buffered_piece_collection~hpp.test\msvc-14.1\dbg\adrs-mdl-64\async-excpt-on\thrd-mlt\self-contained-algorithms-detail-buffer-buffered_piece_collection~hpp.obj.rsp
That seem to be created alright, but when I try to cleanup the run afterwards, windows doesn't allow me to delete the files.
Though the problem is reportedly fixed, you may still want to lift the path length limitation: https://www.howtogeek.com/266621/how-to-make-windows-10-accept-file-paths-ov...
participants (5)
-
Adam Wulkiewicz -
Andrey Semashev -
degski -
Mateusz Loskot -
Tom Kent