Re: [boost] [review][STLInterfaces] STLInterfaces review results (ready for merge)
On Thu, Dec 26, 2019 at 2:31 AM Barrett Adair <barrettellisadair@gmail.com> wrote:
Many thanks are owed to all who participated in the formal review of Zach
Laine's STLInterfaces library, especially during this busy holiday season:
* Hadriel Kaplan - ACCEPT * Andreas Wass - ACCEPT * Rainer Deyke - ACCEPT * Arthur Gruzauskas - ACCEPT * Krystian Stasiowski - ACCEPT * Daniela Engert - CONDITIONALLY ACCEPT * Gavin Lambert - Technical comments
(snip)
The reviews clearly demonstrate a consensus. Accordingly, I'm pleased to
announce that STLInterfaces is CONDITIONALLY ACCEPTED as a Boost library.
Conditions for acceptance: 1. Remove optional dependency on cmcstl2 (issue #27) 2. Add Boost license comments to all files, including appveyor.yml,
.travis.yml, README.md, */CMakeLists.txt (issue #26)
3. Support Boost.Build (issue #25) 4. Replace googletest with Boost equivalent (issue #24) 5. Remove usage of non-existent v2_dtl members in container_interface.hpp (issue #22) 6. Include <tuple> for std::tie usage in C++14 mode (issue #21) 7. Fix dangling parens in container_inteface.hpp:731 (issue #20) 8. Make Concepts usage C++20-conformant (issue #13) 9. Remove the destructor in container_interface (issue #12) 10. Add tests for non-copyable value types (issue #30)
(snip)
I've confirmed that STLInterfaces (https://github.com/tzlaine/stl_interfaces) has met the conditions for acceptance. Review wizards, please reply with any objections. Merge ticket here: https://github.com/boostorg/admin/issues/174 Thanks, Barrett
Can we get this merged now that master has re-opened after 1.73? On Wed, Mar 25, 2020 at 8:38 AM Barrett Adair via Boost < boost@lists.boost.org> wrote:
On Thu, Dec 26, 2019 at 2:31 AM Barrett Adair <barrettellisadair@gmail.com
wrote:
Many thanks are owed to all who participated in the formal review of Zach
Laine's STLInterfaces library, especially during this busy holiday season:
* Hadriel Kaplan - ACCEPT * Andreas Wass - ACCEPT * Rainer Deyke - ACCEPT * Arthur Gruzauskas - ACCEPT * Krystian Stasiowski - ACCEPT * Daniela Engert - CONDITIONALLY ACCEPT * Gavin Lambert - Technical comments
(snip)
The reviews clearly demonstrate a consensus. Accordingly, I'm pleased to
announce that STLInterfaces is CONDITIONALLY ACCEPTED as a Boost library.
Conditions for acceptance: 1. Remove optional dependency on cmcstl2 (issue #27) 2. Add Boost license comments to all files, including appveyor.yml,
.travis.yml, README.md, */CMakeLists.txt (issue #26)
3. Support Boost.Build (issue #25) 4. Replace googletest with Boost equivalent (issue #24) 5. Remove usage of non-existent v2_dtl members in container_interface.hpp (issue #22) 6. Include <tuple> for std::tie usage in C++14 mode (issue #21) 7. Fix dangling parens in container_inteface.hpp:731 (issue #20) 8. Make Concepts usage C++20-conformant (issue #13) 9. Remove the destructor in container_interface (issue #12) 10. Add tests for non-copyable value types (issue #30)
(snip)
I've confirmed that STLInterfaces ( https://github.com/tzlaine/stl_interfaces) has met the conditions for acceptance. Review wizards, please reply with any objections.
Merge ticket here: https://github.com/boostorg/admin/issues/174
Thanks, Barrett
_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
On Tue, Apr 28, 2020 at 11:49 AM Jeff Garland via Boost <boost@lists.boost.org> wrote:
Can we get this merged now that master has re-opened after 1.73?
Zach, transfer the stl_interfaces repository to glenfe on GitHub and I'll move it into boostorg. Glen
On Tue, Apr 28, 2020 at 11:52 AM Glen Fernandes via Boost <boost@lists.boost.org> wrote:
On Tue, Apr 28, 2020 at 11:49 AM Jeff Garland via Boost <boost@lists.boost.org> wrote:
Can we get this merged now that master has re-opened after 1.73?
Zach, transfer the stl_interfaces repository to glenfe on GitHub and I'll move it into boostorg.
Done. Thanks, Glen. Zach
On Wed, Apr 29, 2020 at 10:38 AM Zach Laine via Boost <boost@lists.boost.org> wrote:
On Tue, Apr 28, 2020 at 11:52 AM Glen Fernandes via Boost <boost@lists.boost.org> wrote:
On Tue, Apr 28, 2020 at 11:49 AM Jeff Garland via Boost <boost@lists.boost.org> wrote:
Can we get this merged now that master has re-opened after 1.73?
Zach, transfer the stl_interfaces repository to glenfe on GitHub and I'll move it into boostorg.
Done. Thanks, Glen.
Zach
You're all set: boostorg/stl_interfaces and libs/stl_interfaces sub-module. You have some tests which are using some deprecated facility that emits warnings. (use of boost/test/minimal.hpp). I'd suggest switching to boost/core/lightweight_test.hpp (which is header only and doesn't require you link against anything). If you want, I can submit a pull request. Glen
On Thu, Apr 30, 2020 at 10:01 AM Glen Fernandes <glen.fernandes@gmail.com> wrote:
On Wed, Apr 29, 2020 at 10:38 AM Zach Laine via Boost <boost@lists.boost.org> wrote:
On Tue, Apr 28, 2020 at 11:52 AM Glen Fernandes via Boost <boost@lists.boost.org> wrote:
On Tue, Apr 28, 2020 at 11:49 AM Jeff Garland via Boost <boost@lists.boost.org> wrote:
Can we get this merged now that master has re-opened after 1.73?
Zach, transfer the stl_interfaces repository to glenfe on GitHub and I'll move it into boostorg.
Done. Thanks, Glen.
Zach
You're all set: boostorg/stl_interfaces and libs/stl_interfaces sub-module.
You have some tests which are using some deprecated facility that emits warnings. (use of boost/test/minimal.hpp). I'd suggest switching to boost/core/lightweight_test.hpp (which is header only and doesn't require you link against anything). If you want, I can submit a pull request.
Glen
That would be very welcome, thanks! Zach
participants (4)
-
Barrett Adair -
Glen Fernandes -
Jeff Garland -
Zach Laine