Re: [boost] [review] Fusion review begins
----Original Message---- From: Powell, Gary
Oleg> I propose to change tuple manipulators to be:
Oleg> 1) tuple_bounds("(", ")") // if need to specify one bound, I Oleg> need to specify both. Oleg> 2) tuple_delimiter(",") // I'm happy with bounds, but Oleg> delimiter should be specified. Oleg> 3) tuple_punc("(", ",", ")") // I should specify all punctuation.
The issue is that if you use a facet to do punct, it's tied to the type of container.
I apologize for not looking at what the current code does, but the stuff I wrote orginally was tied directly to the tuples.
Also, you probably want to stick with 'C' not "C";
I don't think you should rule out: tuple_punc("<tuple>", "\n", "</tuple>") -- Martin Bonner Martin.Bonner@Pitechnology.com Pi Technology, Milton Hall, Ely Road, Milton, Cambridge, CB4 6WZ, ENGLAND Tel: +44 (0)1223 203894
Martin Bonner wrote:
----Original Message---- From: Powell, Gary
Oleg> I propose to change tuple manipulators to be:
Oleg> 1) tuple_bounds("(", ")") // if need to specify one bound, I Oleg> need to specify both. Oleg> 2) tuple_delimiter(",") // I'm happy with bounds, but Oleg> delimiter should be specified. Oleg> 3) tuple_punc("(", ",", ")") // I should specify all punctuation. The issue is that if you use a facet to do punct, it's tied to the type of container.
I apologize for not looking at what the current code does, but the stuff I wrote orginally was tied directly to the tuples.
Also, you probably want to stick with 'C' not "C";
I don't think you should rule out: tuple_punc("<tuple>", "\n", "</tuple>")
This is one of the main differences between the original boost tuple I/O manip and Fusion's. Fusion allows "C". So, "<tuple>" and "</tuple>" plus "\n" are definitely valid. Regards, -- Joel de Guzman http://www.boost-consulting.com http://spirit.sf.net
participants (2)
-
Joel de Guzman -
Martin Bonner