[thread] patch to suppress msvc warnings
Hi Vicente, I get lots of noisy warning from win32/thread_data.hpp Example: boost/thread/win32/thread_data.hpp(90) : warning C4251: 'boost::detail::thread_data_base::thread_handle' : class 'boost::detail::win32::handle_manager' needs to have dll-interface to be used by clients of struct 'boost::detail::thread_data_base' Patch suppressing those attached. Okay to commit? Yours, Jürgen -- * Dipl.-Math. Jürgen Hunold ! * voice: ++49 4257 300 ! Fährstraße 1 * fax : ++49 4257 300 ! 31609 Balge/Sebbenhausen * jhunold@gmx.eu ! Germany
Le 22/09/12 17:31, Jürgen Hunold a écrit :
Hi Vicente,
I get lots of noisy warning from win32/thread_data.hpp
Example:
boost/thread/win32/thread_data.hpp(90) : warning C4251: 'boost::detail::thread_data_base::thread_handle' : class 'boost::detail::win32::handle_manager' needs to have dll-interface to be used by clients of struct 'boost::detail::thread_data_base'
Patch suppressing those attached.
Okay to commit?
Yes, you can. But i will prefer to find out how to give dll-interface to? Do you know what can be done? Best, Vicente
Hi Vicente, On Saturday, 22. September 2012 18:08:06 Vicente J. Botet Escriba wrote:
Le 22/09/12 17:31, Jürgen Hunold a écrit :
boost/thread/win32/thread_data.hpp(90) : warning C4251: 'boost::detail::thread_data_base::thread_handle' : class 'boost::detail::win32::handle_manager' needs to have dll-interface to be used by clients of struct 'boost::detail::thread_data_base'
Yes, you can. But i will prefer to find out how to give dll-interface to? Do you know what can be done?
Sorry, this can be fixed by adding BOOST_THREAD_DECL. Patch attached. The rest are false positives from the standard library which have irritated me. Example: class 'std::vector<_Ty>' needs to have dll-interface to be used by clients of struct 'boost::detail::thread_data_base' and the same for std::map<> . Those can only be suppressed. See previous patch. Yours, Jürgen -- * Dipl.-Math. Jürgen Hunold ! * voice: ++49 4257 300 ! Fährstraße 1 * fax : ++49 4257 300 ! 31609 Balge/Sebbenhausen * jhunold@gmx.eu ! Germany
Le 22/09/12 18:24, Jürgen Hunold a écrit :
Hi Vicente,
On Saturday, 22. September 2012 18:08:06 Vicente J. Botet Escriba wrote:
Le 22/09/12 17:31, Jürgen Hunold a écrit :
boost/thread/win32/thread_data.hpp(90) : warning C4251: 'boost::detail::thread_data_base::thread_handle' : class 'boost::detail::win32::handle_manager' needs to have dll-interface to be used by clients of struct 'boost::detail::thread_data_base' Yes, you can. But i will prefer to find out how to give dll-interface to? Do you know what can be done? Sorry, this can be fixed by adding BOOST_THREAD_DECL. Patch attached.
The rest are false positives from the standard library which have irritated me.
Example:
class 'std::vector<_Ty>' needs to have dll-interface to be used by clients of struct 'boost::detail::thread_data_base'
and the same for std::map<> . Those can only be suppressed. See previous patch.
I believed that BOOST_THREAD_DECL was only needed for classes with definitions on the .cxx files. Ok, commit them then. Best, Vicente
participants (2)
-
Jürgen Hunold -
Vicente J. Botet Escriba