Re: [boost] [Review] xpressive - Doc comments

Thomas Witt wrote:
Joel de Guzman wrote:
David Abrahams wrote:
This may have more to do with boostbook/quickbook than with xpressive, but in my Windows XP FireFox browser, it appears that every place inline code is followed by regular text, there is no space separating them. Spaces also seem to be missing in a few other places, e.g. "usingnamespace" can be seen on http://boost-consulting.com/projects/xpressive/xpressive/user_s_guide.html#x...,
as can "representationof" ("representation" is in italics). So this probably applies to all style changes.
I'm almost sure that I already fixed that a few days ago. Ok, lemme check...
Ok, I just confirmed that this bug has been fixed. Eric, please run the docs using the latest QuickBook from Boost HEAD CVS.
Hmm... I just confirmed the bug still exists with inline code. CVS Head of now. This seems to be related to the xml pretty printing.
Thomas
The bug still exists, confirmed. I have disabled XML pretty printing and regenerated the docs. I've updated the download and put the clean docs at http://boost-sandbox.sf.net/libs/xpressive. (I also took the opportunity to patch a few portability issues in the code.) -- Eric Niebler Boost Consulting www.boost-consulting.com

| -----Original Message----- | From: boost-bounces@lists.boost.org | [mailto:boost-bounces@lists.boost.org] On Behalf Of Eric Niebler | Sent: 13 September 2005 17:45 | To: boost-docs@lists.sourceforge.net; boost@lists.boost.org | Subject: Re: [boost] [Review] xpressive - Doc comments | | | The bug still exists, confirmed. I have disabled XML pretty | printing and | regenerated the docs. I've updated the download and put the | clean docs | at http://boost-sandbox.sf.net/libs/xpressive. (I also took the | opportunity to patch a few portability issues in the code.) I confirm that this is better. I noted a problem with the layout on the 1st line of the "getting xpressive" is spread out so there are massive gaps between words at some font sizes (Firefox 1.0.6) Does the link need to be on a real newline? and speed of your brain deceiving the fingers at Beware Nested Quantifiers This is a pitfall common to many regular expression engines. Some patterns can cause exponentially bad performance. Often these patterns involve one quantified term nested withing another quiantifier <<<<<<<<<<<<< Not just xpressive but Impressive ;-) Paul Paul A Bristow Prizet Farmhouse, Kendal, Cumbria UK LA8 8AB +44 1539 561830 +44 7714 330204 mailto: pbristow@hetp.u-net.com www.hetp.u-net.com

"Paul A Bristow" <pbristow@hetp.u-net.com> writes:
boost-bounces@lists.boost.org wrote: |
| | The bug still exists, confirmed. I have disabled XML pretty | printing and | regenerated the docs. I've updated the download and put the | clean docs | at http://boost-sandbox.sf.net/libs/xpressive. (I also took the | opportunity to patch a few portability issues in the code.)
I confirm that this is better.
I noted a problem with the layout on the 1st line of the "getting xpressive"
is spread out so there are massive gaps between words at some font sizes (Firefox 1.0.6)
That's the full justification I was complaining about. -- Dave Abrahams Boost Consulting www.boost-consulting.com

David Abrahams wrote:
"Paul A Bristow" <pbristow@hetp.u-net.com> writes:
I noted a problem with the layout on the 1st line of the "getting xpressive" is spread out so there are massive gaps between words at some font sizes (Firefox 1.0.6)
That's the full justification I was complaining about.
I've fixed this issue at http://boost-sandbox.sf.net/libs/xpressive. I've also tweaked the CSS to remove full justification within tables. -- Eric Niebler Boost Consulting www.boost-consulting.com

Eric Niebler <eric@boost-consulting.com> writes:
Thomas Witt wrote:
Joel de Guzman wrote:
David Abrahams wrote:
This may have more to do with boostbook/quickbook than with xpressive, but in my Windows XP FireFox browser, it appears that every place inline code is followed by regular text, there is no space separating them. Spaces also seem to be missing in a few other places, e.g. "usingnamespace" can be seen on http://boost-consulting.com/projects/xpressive/xpressive/user_s_guide.html#x...,
as can "representationof" ("representation" is in italics). So this probably applies to all style changes.
I'm almost sure that I already fixed that a few days ago. Ok, lemme check...
Ok, I just confirmed that this bug has been fixed. Eric, please run the docs using the latest QuickBook from Boost HEAD CVS. Hmm... I just confirmed the bug still exists with inline code. CVS Head of now. This seems to be related to the xml pretty printing. Thomas
The bug still exists, confirmed. I have disabled XML pretty printing and regenerated the docs.
I don't see how it could be related to pretty printing and still account for "representationof." -- Dave Abrahams Boost Consulting www.boost-consulting.com

David Abrahams wrote:
Eric Niebler <eric@boost-consulting.com> writes:
The bug still exists, confirmed. I have disabled XML pretty printing and regenerated the docs.
I don't see how it could be related to pretty printing and still account for "representationof."
Joel added a new feature to quickbook to strip "insignificant" whitespace from the XML and format it beautifully. (The reason is so that we can implement a quickbook regression test which does a simple file-compare of the generated XML against a baseline.) Obviously, quickbook is a bit confused right now about what whitespace is significant and what isn't. We should probably put the pretty-print feature on a switch, for now at least. -- Eric Niebler Boost Consulting www.boost-consulting.com
participants (3)
-
David Abrahams
-
Eric Niebler
-
Paul A Bristow