Re: [boost] Review: Switch library
Joel de Guzman wrote:
And finally, every review should answer this question:
* Do you think the library should be accepted as a Boost library? Be sure to say this explicitly so that your other comments don't obscure your overall opinion.
Not at the moment. I think we need a more thorough discussion on alternative interfaces. We also need to discuss the issues that were raised in the review. I'm eager to hear Steven's replies. He seem to be a bit too quiet?
I'm really tempted to say "yes" and let Steven address the concerns raised (including mine). I'm very confident in Steven's abilities. He's one of those who still gives me the "oooh" feeling with his code. And, I really *NEED* such a switch utility now and not later.
So, please take this as a soft "no" vote for now. I encourage Steven to get more involved in the discussion and consider all the issues raised. As soon as these matters are ironed out, fire up another review ASAP.
Oh, perhaps I'd like to ask a review extension. If Steven can reply to my concerns and is willing to address them, I might still change my vote to a yes. I really need this facility now! Bottom line: more discussion please! This is a small library, yet it is (to me) very important. Let's get the design correct. Regards, -- Joel de Guzman http://www.boost-consulting.com http://spirit.sf.net
Joel de Guzman wrote:
Joel de Guzman wrote:
Oh, perhaps I'd like to ask a review extension. If Steven can reply to my concerns and is willing to address them, I might still change my vote to a yes. I really need this facility now! Bottom line: more discussion please! This is a small library, yet it is (to me) very important. Let's get the design correct.
For the record, I am changing my vote to "yes". I'm quite happy with the response to my concerns. I am very confident Steven will produce an amazing library from the very constructive discussions so far. I'm obviously very adamant in my posts, the reason being that I really need such a library now but I have certain use-cases that I need to be handled by the library, *now*, and not later in another lifetime. I can't wait for another review or another library to come along that's closer to my needs. I believe the switch_ library can, with additional thought and design, handle my needs. I also urge Steven to pursue the dynamic_switch idea I posted which employs perfect hashing at compile time whereby allowing equivalent or faster than a switch dispatch at runtime where the cases are dynamic (instead of compile time constants). Regards, -- Joel de Guzman http://www.boost-consulting.com http://spirit.sf.net
Joel de Guzman wrote:
Joel de Guzman wrote:
Joel de Guzman wrote:
Oh, perhaps I'd like to ask a review extension. If Steven can reply to my concerns and is willing to address them, I might still change my vote to a yes. I really need this facility now! Bottom line: more discussion please! This is a small library, yet it is (to me) very important. Let's get the design correct.
For the record, I am changing my vote to "yes". I'm quite happy with the response to my concerns. I am very confident Steven will produce an amazing library from the very constructive discussions so far. I'm obviously very adamant in my posts, the reason being that I really need such a library now but I have certain use-cases that I need to be handled by the library, *now*, and not later in another lifetime. I can't wait for another review or another library to come along that's closer to my needs. I believe the switch_ library can, with additional thought and design, handle my needs.
I also urge Steven to pursue the dynamic_switch idea I posted which employs perfect hashing at compile time whereby allowing
Oops, sorry. I meant: perfect hashing at runtime (where the cases are known beforehand at initialization time).
equivalent or faster than a switch dispatch at runtime where the cases are dynamic (instead of compile time constants).
Regards, -- Joel de Guzman http://www.boost-consulting.com http://spirit.sf.net
On Jan 12, 2008 5:22 PM, Joel de Guzman <joel@boost-consulting.com> wrote:
For the record, I am changing my vote to "yes". I'm quite happy with the response to my concerns. I am very confident Steven will produce an amazing library from the very constructive discussions so far. I'm obviously very adamant in my posts, the reason being that I really need such a library now but I have certain use-cases that I need to be handled by the library, *now*, and not later in another lifetime. I can't wait for another review or another library to come along that's closer to my needs. I believe the switch_ library can, with additional thought and design, handle my needs.
Thank you, Joel. Your contribution to this review is greatly appreciated. I do believe that without addressing your concerns the library would not be a true Boost.Switch. Regards, Stjepan
participants (2)
-
Joel de Guzman -
Stjepan Rajko