Help wanted: Open pull request reminders
As a library maintainer, I'd like to get periodic reminders of open pull requests for libraries I maintain and perhaps some other libraries I'm interested in. I'd like a email reminder, but others might prefer Slack or other forms of notification. A related need is for anyone to be able to find the total number of open pull requests for Boost as a whole, and perhaps get a sorted list of the per library counts. Or maybe we should just show today's count on the web site? Googling for "github open pull request reminders" shows that lots of others feel the same need. Would someone like to volunteer to review what others are doing to meet this need, and recommend an approach suitable for Boost? --Beman
On 23/10/2017 12:58, Beman Dawes via Boost wrote:
As a library maintainer, I'd like to get periodic reminders of open pull requests for libraries I maintain and perhaps some other libraries I'm interested in. I'd like a email reminder, but others might prefer Slack or other forms of notification.
A related need is for anyone to be able to find the total number of open pull requests for Boost as a whole, and perhaps get a sorted list of the per library counts. Or maybe we should just show today's count on the web site?
Googling for "github open pull request reminders" shows that lots of others feel the same need. Would someone like to volunteer to review what others are doing to meet this need, and recommend an approach suitable for Boost?
A python cronjob script emailing a list of open pull requests for a repo is trivially implementable using https://github.com/PyGithub/PyGithub As with all things, firing something together for personal use is a ten minute job, writing something reusable by others is many days of work. Niall -- ned Productions Limited Consulting http://www.nedproductions.biz/ http://ie.linkedin.com/in/nialldouglas/
On Mon, Oct 23, 2017 at 8:51 AM, Niall Douglas via Boost < boost@lists.boost.org> wrote:
A python cronjob script emailing a list of open pull requests for a repo is trivially implementable using https://github.com/PyGithub/PyGithub
Thanks. I'll take a look.
As with all things, firing something together for personal use is a ten minute job, writing something reusable by others is many days of work.
Understood. I am hoping someone will volunteer for something that would useful for Boost developers, but not necessarily so general that days of work would be required. --Beman
As with all things, firing something together for personal use is a ten minute job, writing something reusable by others is many days of work.
Understood. I am hoping someone will volunteer for something that would useful for Boost developers, but not necessarily so general that days of work would be required.
There is a big fat solution to Github reminders at https://github.com/StephenOTT/GitHub-Reminders, but it would require ongoing server maintenance as it's a Ruby stack. Much safer is a dumb weekly cronjob which sends reminders of all open issues and pull requests for all boostorg repos to their owners/maintainers. Niall -- ned Productions Limited Consulting http://www.nedproductions.biz/ http://ie.linkedin.com/in/nialldouglas/
Beman Dawes wrote:
As a library maintainer, I'd like to get periodic reminders of open pull requests for libraries I maintain and perhaps some other libraries I'm interested in.
I recently learned about the existence of http://www.boost.org/development/pull_requests.php but it doesn't e-mail people. :-)
On Mon, Oct 23, 2017 at 4:07 PM, Peter Dimov via Boost
Beman Dawes wrote:
As a library maintainer, I'd like to get periodic reminders of open pull requests for libraries I maintain and perhaps some other libraries I'm interested in.
I recently learned about the existence of
http://www.boost.org/development/pull_requests.php
but it doesn't e-mail people. :-)
Is there no way for https://github.com/pulls to show requests for all your repos? If not, a feature request to Github would make sense. -- Olaf
On 23 October 2017 at 15:07, Peter Dimov via Boost
Beman Dawes wrote:
As a library maintainer, I'd like to get periodic reminders of open pull
requests for libraries I maintain and perhaps some other libraries I'm interested in.
I recently learned about the existence of
http://www.boost.org/development/pull_requests.php
but it doesn't e-mail people. :-)
The amount of pull requests, most of which are really old, is quite scary. Do people not care about merging fixes in their code?
The amount of pull requests, most of which are really old, is quite scary. Do people not care about merging fixes in their code?
Not all fixes are created equally: some are incomplete and the author may be waiting on more information. Others may be work in progress: I have some against my stuff that begin with "Please don't merge yet, work in progress" or words to that effect. OK, I could just close them down on the grounds that they're not ready yet, but in most cases the authors of those PR's are actually working on them (or intending to do so). So there is an inevitable bind up of cruft: stuff that isn't a simple no brainer "yes I can merge this as is". Indeed some are very significant changes which require a fair bit of work before they can be merged, I don't necessarily want to close them as "won't apply", but I don't necessarily have the time to apply them correctly either just yet - so they'll sit there until I do. In an ideal world we would have a third status to "open" and "closed", something like "pending" or "waiting for information". John. --- This email has been checked for viruses by AVG. http://www.avg.com
On Tue, Oct 24, 2017 at 7:19 AM, John Maddock via Boost < boost@lists.boost.org> wrote:
The amount of pull requests, most of which are really old, is quite scary.
Do people not care about merging fixes in their code?
Not all fixes are created equally: some are incomplete and the author may be waiting on more information. Others may be work in progress: I have some against my stuff that begin with "Please don't merge yet, work in progress" or words to that effect. OK, I could just close them down on the grounds that they're not ready yet, but in most cases the authors of those PR's are actually working on them (or intending to do so). So there is an inevitable bind up of cruft: stuff that isn't a simple no brainer "yes I can merge this as is". Indeed some are very significant changes which require a fair bit of work before they can be merged, I don't necessarily want to close them as "won't apply", but I don't necessarily have the time to apply them correctly either just yet - so they'll sit there until I do. In an ideal world we would have a third status to "open" and "closed", something like "pending" or "waiting for information".
John.
You can use github labels to identify various states for issues or pull requests on a per-project basis. - Jim
On 23 October 2017 at 12:58, Beman Dawes via Boost
As a library maintainer, I'd like to get periodic reminders of open pull requests for libraries I maintain and perhaps some other libraries I'm interested in. I'd like a email reminder, but others might prefer Slack or other forms of notification.
The problem here is knowing who to email about which repositories. I'd rather not use the library metadata, as I'm sure there are people listed as maintainers who don't want to be pestered with emails. I guess what we could have an opt-in system which emails you periodically about the boostorg repos you are watching.
Daniel James wrote:
The problem here is knowing who to email about which repositories. I'd rather not use the library metadata, as I'm sure there are people listed as maintainers who don't want to be pestered with emails.
One might argue that the whole point of adding yourself as a maintainer along with an e-mail address is to be pestered with emails about the library. :-) Although I'd make the reminder monthly rather than weekly. Weekly would be a nuisance.
On 25.10.2017 08:10, Peter Dimov via Boost wrote:
Daniel James wrote:
The problem here is knowing who to email about which repositories. I'd rather not use the library metadata, as I'm sure there are people listed as maintainers who don't want to be pestered with emails.
One might argue that the whole point of adding yourself as a maintainer along with an e-mail address is to be pestered with emails about the library. :-)
I'd argue that the whole point of adding myself as a maintainer is to take responsibility for managing the project (including issues, PRs, etc.) myself. I certainly don't want to receive any additional emails telling me about things I'm already fully aware of.
Although I'd make the reminder monthly rather than weekly. Weekly would be a nuisance.
Having the ability to receive such reminders may be useful to some, but I expect this to be an "opt-in" service, not "opt-out". Stefan -- ...ich hab' noch einen Koffer in Berlin...
On Wed, Oct 25, 2017 at 8:10 AM, Peter Dimov via Boost < boost@lists.boost.org> wrote:
Daniel James wrote:
The problem here is knowing who to email about which repositories. I'd
rather not use the library metadata, as I'm sure there are people listed as maintainers who don't want to be pestered with emails.
One might argue that the whole point of adding yourself as a maintainer along with an e-mail address is to be pestered with emails about the library. :-)
Although I'd make the reminder monthly rather than weekly. Weekly would be a nuisance.
+1 I'd appreciate getting monthly reminders, but weekly would be way too often. --Beman
participants (9)
-
Beman Dawes -
Daniel James -
James E. King, III -
John Maddock -
Mathias Gaunard -
Niall Douglas -
Olaf van der Spek -
Peter Dimov -
Stefan Seefeld