[iostreams] Ticket #5237 - Chance to get fix applied into Boost 1.59?
Hi everyone, in our application we use Boost.Iostreams with GZip functionality to write some data into gzipped output-files. Eventually we realized, that we would get corrupted output-files if no data was available that could be written to the output-file By looking for a patch we stumbled across an issue-report [1] which seems to be open for more than 4 years, although a simple fix was already provided in its comments 3,5 years ago. My question is: Can somebody apply that fix to the development branch and could it still make it into the upcoming Boost 1.59 release? Thanks, Deniz [1] https://svn.boost.org/trac/boost/ticket/5237
Am 04.08.2015 um 17:10 schrieb Deniz Bahadir:
Hi everyone,
in our application we use Boost.Iostreams with GZip functionality to write some data into gzipped output-files. Eventually we realized, that we would get corrupted output-files if no data was available that could be written to the output-file
By looking for a patch we stumbled across an issue-report [1] which seems to be open for more than 4 years, although a simple fix was already provided in its comments 3,5 years ago.
My question is: Can somebody apply that fix to the development branch and could it still make it into the upcoming Boost 1.59 release?
I additionally created a pull-request [2] which has the simple fix already applied. Best regards, Deniz
[1] https://svn.boost.org/trac/boost/ticket/5237 [2] https://github.com/boostorg/iostreams/pull/16
On Wed, Aug 5, 2015 at 8:33 AM, Deniz Bahadir
Am 04.08.2015 um 17:10 schrieb Deniz Bahadir:
Hi everyone,
in our application we use Boost.Iostreams with GZip functionality to write some data into gzipped output-files. Eventually we realized, that we would get corrupted output-files if no data was available that could be written to the output-file
By looking for a patch we stumbled across an issue-report [1] which seems to be open for more than 4 years, although a simple fix was already provided in its comments 3,5 years ago.
My question is: Can somebody apply that fix to the development branch and could it still make it into the upcoming Boost 1.59 release?
I additionally created a pull-request [2] which has the simple fix already applied.
Best regards, Deniz
You know what would make this pull request even better? Tests. -- Marshall
You know what would make this pull request even better? Tests.
-- Marshall
Should I make a pull request for ticket https://svn.boost.org/trac/boost/ticket/10561 which include tests? Best regards Jorge
On Wed, Aug 5, 2015 at 9:10 AM, Jorge Lodos Vigil
You know what would make this pull request even better? Tests.
-- Marshall
Should I make a pull request for ticket https://svn.boost.org/trac/boost/ticket/10561 which include tests?
Yes, please!
-- Marshall
participants (4)
-
Deniz Bahadir -
Deniz Bahadir -
Jorge Lodos Vigil -
Marshall Clow